mbox series

[v8,net-next,0/4] Fix broken link on Xilinx's AXI Ethernet in SGMII mode

Message ID 20220405091929.670951-1-andy.chiu@sifive.com (mailing list archive)
Headers show
Series Fix broken link on Xilinx's AXI Ethernet in SGMII mode | expand

Message

Andy Chiu April 5, 2022, 9:19 a.m. UTC 
The Ethernet driver use phy-handle to reference the PCS/PMA PHY. This
could be a problem if one wants to configure an external PHY via phylink,
since it use the same phandle to get the PHY. To fix this, introduce a
dedicated pcs-handle to point to the PCS/PMA PHY and deprecate the use
of pointing it with phy-handle. A similar use case of pcs-handle can be
seen on dpaa2 as well.

--- patch v5 ---
 - Re-apply the v4 patch on the net tree.
 - Describe the pcs-handle DT binding at ethernet-controller level.
--- patch v6 ---
 - Remove "preferrably" to clearify usage of pcs_handle.
--- patch v7 ---
 - Rebase the patch on latest net/master
--- patch v8 ---
 - Rebase the patch on net-next/master
 - Add "reviewed-by" tag in PATCH 3/4: dt-bindings: net: add pcs-handle
   attribute
 - Remove "fix" tag in last commit message since this is not a critical
   bug and will not be back ported to stable.

Andy Chiu (4):
  net: axienet: setup mdio unconditionally
  net: axienet: factor out phy_node in struct axienet_local
  dt-bindings: net: add pcs-handle attribute
  net: axiemac: use a phandle to reference pcs_phy

 .../bindings/net/ethernet-controller.yaml     |  6 ++++
 .../bindings/net/xilinx_axienet.txt           |  8 ++++-
 drivers/net/ethernet/xilinx/xilinx_axienet.h  |  2 --
 .../net/ethernet/xilinx/xilinx_axienet_main.c | 33 ++++++++++---------
 4 files changed, 31 insertions(+), 18 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org April 6, 2022, 1:10 p.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue,  5 Apr 2022 17:19:25 +0800 you wrote:
> The Ethernet driver use phy-handle to reference the PCS/PMA PHY. This
> could be a problem if one wants to configure an external PHY via phylink,
> since it use the same phandle to get the PHY. To fix this, introduce a
> dedicated pcs-handle to point to the PCS/PMA PHY and deprecate the use
> of pointing it with phy-handle. A similar use case of pcs-handle can be
> seen on dpaa2 as well.
> 
> [...]

Here is the summary with links:
  - [v8,net-next,1/4] net: axienet: setup mdio unconditionally
    https://git.kernel.org/netdev/net/c/d1c4f93e3f0a
  - [v8,net-next,2/4] net: axienet: factor out phy_node in struct axienet_local
    https://git.kernel.org/netdev/net/c/ab3a5d4c6081
  - [v8,net-next,3/4] dt-bindings: net: add pcs-handle attribute
    https://git.kernel.org/netdev/net/c/dc48f04fd656
  - [v8,net-next,4/4] net: axiemac: use a phandle to reference pcs_phy
    https://git.kernel.org/netdev/net/c/19c7a43912c6

You are awesome, thank you!