mbox series

[net-next,v2,0/3] net: ethool: add support to get/set tx push by ethtool -G/g

Message ID 20220412020121.14140-1-huangguangbin2@huawei.com (mailing list archive)
Headers show
Series net: ethool: add support to get/set tx push by ethtool -G/g | expand

Message

Guangbin Huang April 12, 2022, 2:01 a.m. UTC
From: Jie Wang <wangjie125@huawei.com>

These three patches add tx push in ring params and adapt the set and get APIs
of ring params.

ChangeLog:

V1->V2
1.Add a mention in tx push description
2.Delete the redundant value check in ethnl_set_rings
3.Fix the Kdoc warning
link: https://lore.kernel.org/netdev/20220408071245.40554-1-huangguangbin2@huawei.com/

RFC V4->V1
1.Add detailed description about the tx push mode
2.Modify the patch subject title
link: https://lore.kernel.org/netdev/20220331084342.27043-1-wangjie125@huawei.com/

RFC V3->RFC V4
1.Put three request checks before rtnl_lock() in ethnl_set_rings
2.Add tx push feature description in Documentation/networking/ethtool-netlink.rst
3.Use netdev_dbg to track changes in hns3_set_tx_push
link: https://lore.kernel.org/netdev/20220329091913.17869-1-wangjie125@huawei.com/

RFC V2->RFC V3
1.Add tx push documentation in Documentation/networking/ethtool-netlink.rst
2.Use u8 to store tx push in struct kernel_ethtool_ringparam
3.Add ETHTOOL_RING_USE_TX_PUSH to reject setting for unsupported driver
4.Use NLA_POLICY_MAX(NLA_U8, 1) to limit the tx push value
link: https://lore.kernel.org/netdev/20220326085102.14111-1-wangjie125@huawei.com/

RFC V1->RFC V2
1.Extend tx push param in ringparam, suggested by Jakub Kicinski.
link: https://lore.kernel.org/netdev/20220315032108.57228-1-wangjie125@huawei.com/

Jie Wang (3):
  net: ethtool: extend ringparam set/get APIs for tx_push
  net: ethtool: move checks before rtnl_lock() in ethnl_set_rings
  net: hns3: add tx push support in hns3 ring param process

 Documentation/networking/ethtool-netlink.rst  |  9 ++++
 .../ethernet/hisilicon/hns3/hns3_ethtool.c    | 33 +++++++++++-
 include/linux/ethtool.h                       |  4 ++
 include/uapi/linux/ethtool_netlink.h          |  1 +
 net/ethtool/netlink.h                         |  2 +-
 net/ethtool/rings.c                           | 54 ++++++++++++-------
 6 files changed, 81 insertions(+), 22 deletions(-)

Comments

Jakub Kicinski April 12, 2022, 9:58 p.m. UTC | #1
On Tue, 12 Apr 2022 10:01:18 +0800 Guangbin Huang wrote:
> From: Jie Wang <wangjie125@huawei.com>
> 
> These three patches add tx push in ring params and adapt the set and get APIs
> of ring params.

Acked-by: Jakub Kicinski <kuba@kernel.org>
patchwork-bot+netdevbpf@kernel.org April 15, 2022, 9 p.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 12 Apr 2022 10:01:18 +0800 you wrote:
> From: Jie Wang <wangjie125@huawei.com>
> 
> These three patches add tx push in ring params and adapt the set and get APIs
> of ring params.
> 
> ChangeLog:
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/3] net: ethtool: extend ringparam set/get APIs for tx_push
    (no matching commit)
  - [net-next,v2,2/3] net: ethtool: move checks before rtnl_lock() in ethnl_set_rings
    https://git.kernel.org/netdev/net-next/c/bde292c07b48
  - [net-next,v2,3/3] net: hns3: add tx push support in hns3 ring param process
    https://git.kernel.org/netdev/net-next/c/1f702c1643f2

You are awesome, thank you!