From patchwork Tue Apr 12 16:55:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kui-Feng Lee X-Patchwork-Id: 12810969 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B221C433F5 for ; Tue, 12 Apr 2022 16:56:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234206AbiDLQ6r (ORCPT ); Tue, 12 Apr 2022 12:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232565AbiDLQ6r (ORCPT ); Tue, 12 Apr 2022 12:58:47 -0400 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E3CD5F8E7 for ; Tue, 12 Apr 2022 09:56:29 -0700 (PDT) Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23CG0tGr032707 for ; Tue, 12 Apr 2022 09:56:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=facebook; bh=lhNQy+GGaRLg/MBDv/8rgljix57m03hUii1N8vjTq80=; b=cL1PLKI6xiZlwcB1iv10xthvae6CwEJ01HJM0UjOnWCk1cEMl7KJ7SBBVD0MP1cv9BlG bOLdVPh3RUawZn803UR4CmCr7pViNMHDmGfbYjCZi/bmNsfYiNXQJyhT/IaMcLxEntaS NYMQbz1rGQkjrD5yAZI6zbjkzr8Ewcji9KM= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3fcy5qva9y-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 12 Apr 2022 09:56:28 -0700 Received: from twshared29473.14.frc2.facebook.com (2620:10d:c085:108::8) by mail.thefacebook.com (2620:10d:c085:11d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 12 Apr 2022 09:56:27 -0700 Received: by devbig931.frc1.facebook.com (Postfix, from userid 460691) id 7E615230915A; Tue, 12 Apr 2022 09:56:24 -0700 (PDT) From: Kui-Feng Lee To: , , , , CC: Kui-Feng Lee Subject: [PATCH bpf-next v5 0/5] Attach a cookie to a tracing program. Date: Tue, 12 Apr 2022 09:55:50 -0700 Message-ID: <20220412165555.4146407-1-kuifeng@fb.com> X-Mailer: git-send-email 2.30.2 X-FB-Internal: Safe X-Proofpoint-ORIG-GUID: CYfABFuPBcfbskS1qZRn0b4p-9eFbOII X-Proofpoint-GUID: CYfABFuPBcfbskS1qZRn0b4p-9eFbOII X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-12_06,2022-04-12_02,2022-02-23_01 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net Allow users to attach a 64-bits cookie to a bpf_link of fentry, fexit, or fmod_ret. This patchset includes several major changes. - Define struct bpf_tramp_links to replace bpf_tramp_prog. struct bpf_tramp_links collects bpf_links of a trampoline - Generate a trampoline to call bpf_progs of given bpf_links. - Trampolines always set/reset bpf_run_ctx before/after calling/leaving a tracing program. - Attach a cookie to a bpf_link of fentry/fexit/fmod_ret. The value will be available when running the associated bpf_prog. The major differences from v4: - Remove condition checking in __bpf_prog_{enter,exit) The major differences from v3: - rebase v3 to latest tip. The major differences from v2: - Move the allocations of run_ctx (struct bpf_tramp_run_ctx) out of invoke_bpf_prog(). - Move hlist_node out of bpf_link and introduce struct bpf_tramp_link to own hlist_node. - Store cookies at struct bpf_tracing_link. - Use SIB byte to reduce the number of instructions to set cookie values. (Use RSP directly) v1: https://lore.kernel.org/all/20220126214809.3868787-1-kuifeng@fb.com/ v2: https://lore.kernel.org/bpf/20220316004231.1103318-1-kuifeng@fb.com/ v3: https://lore.kernel.org/bpf/20220407192552.2343076-1-kuifeng@fb.com/ v4: https://lore.kernel.org/bpf/20220411173429.4139609-1-kuifeng@fb.com/ Kui-Feng Lee (5): bpf, x86: Generate trampolines from bpf_tramp_links bpf, x86: Create bpf_tramp_run_ctx on the caller thread's stack bpf, x86: Attach a cookie to fentry/fexit/fmod_ret. lib/bpf: Assign cookies to links in libbpf. selftest/bpf: The test cses of BPF cookie for fentry/fexit/fmod_ret. arch/x86/net/bpf_jit_comp.c | 98 +++++++++++++++---- include/linux/bpf.h | 56 ++++++++--- include/linux/bpf_types.h | 1 + include/uapi/linux/bpf.h | 9 ++ kernel/bpf/bpf_struct_ops.c | 69 ++++++++----- kernel/bpf/syscall.c | 57 +++++++---- kernel/bpf/trampoline.c | 93 +++++++++++------- kernel/trace/bpf_trace.c | 17 ++++ net/bpf/bpf_dummy_struct_ops.c | 35 ++++++- tools/bpf/bpftool/link.c | 1 + tools/include/uapi/linux/bpf.h | 8 ++ tools/lib/bpf/bpf.c | 7 ++ tools/lib/bpf/bpf.h | 3 + tools/lib/bpf/libbpf.c | 33 +++++++ tools/lib/bpf/libbpf.h | 12 +++ tools/lib/bpf/libbpf.map | 1 + .../selftests/bpf/prog_tests/bpf_cookie.c | 52 ++++++++++ .../selftests/bpf/progs/test_bpf_cookie.c | 24 +++++ 18 files changed, 459 insertions(+), 117 deletions(-)