mbox series

[bpf-next,v4,0/3] Enlarge offset check value in bpf_skb_load_bytes

Message ID 20220416105801.88708-1-liujian56@huawei.com (mailing list archive)
Headers show
Series Enlarge offset check value in bpf_skb_load_bytes | expand

Message

liujian (CE) April 16, 2022, 10:57 a.m. UTC
The data length of skb frags + frag_list may be greater than 0xffff,
and skb_header_pointer can not handle negative offset.
So here INT_MAX is used to check the validity of offset.

And add the test case for the change.

Liu Jian (3):
  net: Enlarge offset check value from 0xffff to INT_MAX in
    bpf_skb_load_bytes
  net: change skb_ensure_writable()'s write_len param to unsigned int
    type
  selftests: bpf: add test for skb_load_bytes

 include/linux/skbuff.h                        |  2 +-
 net/core/filter.c                             |  4 +-
 net/core/skbuff.c                             |  2 +-
 .../selftests/bpf/prog_tests/skb_load_bytes.c | 45 +++++++++++++++++++
 .../selftests/bpf/progs/skb_load_bytes.c      | 19 ++++++++
 5 files changed, 68 insertions(+), 4 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/skb_load_bytes.c
 create mode 100644 tools/testing/selftests/bpf/progs/skb_load_bytes.c

Comments

patchwork-bot+netdevbpf@kernel.org April 20, 2022, 9:50 p.m. UTC | #1
Hello:

This series was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Sat, 16 Apr 2022 18:57:58 +0800 you wrote:
> The data length of skb frags + frag_list may be greater than 0xffff,
> and skb_header_pointer can not handle negative offset.
> So here INT_MAX is used to check the validity of offset.
> 
> And add the test case for the change.
> 
> Liu Jian (3):
>   net: Enlarge offset check value from 0xffff to INT_MAX in
>     bpf_skb_load_bytes
>   net: change skb_ensure_writable()'s write_len param to unsigned int
>     type
>   selftests: bpf: add test for skb_load_bytes
> 
> [...]

Here is the summary with links:
  - [bpf-next,v4,1/3] net: Enlarge offset check value from 0xffff to INT_MAX in bpf_skb_load_bytes
    https://git.kernel.org/bpf/bpf-next/c/45969b4152c1
  - [bpf-next,v4,2/3] net: change skb_ensure_writable()'s write_len param to unsigned int type
    https://git.kernel.org/bpf/bpf-next/c/92ece28072f1
  - [bpf-next,v4,3/3] selftests: bpf: add test for skb_load_bytes
    https://git.kernel.org/bpf/bpf-next/c/127e7dca427b

You are awesome, thank you!