| Message ID | 20220422180305.301882-1-maxime.chevallier@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: ipqess: introduce Qualcomm IPQESS driver | expand |
On Fri, Apr 22, 2022 at 08:03:00PM +0200, Maxime Chevallier wrote: > Hello everyone, > > This series introduces a new driver, for the Qualcomm IPQESS Ethernet > Controller, found on the IPQ4019. > > The driver itself is pretty straightforward, but has lived out-of-tree > for a while. I've done my best to clean-up some outdated API calls, but > some might remain. > > This controller is somewhat special, since it's part of the IPQ4019 SoC > which also includes an QCA8K switch, and uses the IPQESS controller for > the CPU port. Does it exist in a form where it is not connected to a switch? As Florian has suggested, if we assume frames are always going to/coming from a switch, we can play around with the frame format a little. A dummy tag could be added to the head or tail of the frame, which the MAC driver then uses. That gives us a more normal structure. Andrew
On Fri, Apr 22, 2022 at 10:29 PM Andrew Lunn <andrew@lunn.ch> wrote: > > On Fri, Apr 22, 2022 at 08:03:00PM +0200, Maxime Chevallier wrote: > > Hello everyone, > > > > This series introduces a new driver, for the Qualcomm IPQESS Ethernet > > Controller, found on the IPQ4019. > > > > The driver itself is pretty straightforward, but has lived out-of-tree > > for a while. I've done my best to clean-up some outdated API calls, but > > some might remain. > > > > This controller is somewhat special, since it's part of the IPQ4019 SoC > > which also includes an QCA8K switch, and uses the IPQESS controller for > > the CPU port. > > Does it exist in a form where it is not connected to a switch? Hi Andrew, both the ethernet controller and the QCA8337N based switch are part of the SoC silicon and are always present. The ethernet controller is always connected to the switch port 0. Regards, Robert > > As Florian has suggested, if we assume frames are always going > to/coming from a switch, we can play around with the frame format a > little. A dummy tag could be added to the head or tail of the frame, > which the MAC driver then uses. That gives us a more normal structure. > > Andrew
Hello everyone, This series introduces a new driver, for the Qualcomm IPQESS Ethernet Controller, found on the IPQ4019. The driver itself is pretty straightforward, but has lived out-of-tree for a while. I've done my best to clean-up some outdated API calls, but some might remain. This controller is somewhat special, since it's part of the IPQ4019 SoC which also includes an QCA8K switch, and uses the IPQESS controller for the CPU port. The switch is so tightly intergrated with the MAC that it is connected to the MAC using an internal link (hence the fact that we only support PHY_INTERFACE_MODE_INTERNAL), and this has some consequences on the DSA side. The tagging for the switch isn't done inband as most switch do, but out-of-band, the DSA tag being included in the DMA descriptor. So, this series also includes a new DSA tagging protocol, that sets the DSA port index into skb->shinfo, so that the MAC driver can use it to build the descriptor. This is definitely unusual, so I'l very openned to suggestions, comments and reviews on the tagging side of this series. Thanks to the Sartura folks who worked on a base version of this driver, and provided test hardware. Best regards, Maxime Chevallier Maxime Chevallier (5): net: ipqess: introduce the Qualcomm IPQESS driver net: dsa: add out-of-band tagging protocol net: ipqess: Add out-of-band DSA tagging support net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet controller .../devicetree/bindings/net/qcom,ipqess.yaml | 94 ++ MAINTAINERS | 6 + arch/arm/boot/dts/qcom-ipq4019.dtsi | 42 + drivers/net/ethernet/qualcomm/Kconfig | 11 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/ipqess/Makefile | 8 + drivers/net/ethernet/qualcomm/ipqess/ipqess.c | 1258 +++++++++++++++++ drivers/net/ethernet/qualcomm/ipqess/ipqess.h | 515 +++++++ .../ethernet/qualcomm/ipqess/ipqess_ethtool.c | 168 +++ include/linux/skbuff.h | 7 + include/net/dsa.h | 2 + net/dsa/Kconfig | 7 + net/dsa/Makefile | 1 + net/dsa/tag_oob.c | 45 + 14 files changed, 2166 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/qcom,ipqess.yaml create mode 100644 drivers/net/ethernet/qualcomm/ipqess/Makefile create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess.c create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess.h create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess_ethtool.c create mode 100644 net/dsa/tag_oob.c