| Message ID | 20220428114049.1456382-1-michael@walle.cc (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: lan966x: remove PHY reset support | expand |
The 04/28/2022 13:40, Michael Walle wrote: > > Remove the unneeded PHY reset node as well as the driver support for it. > > This was already discussed [1] and I expect Microchip to Ack on this > removal. Since there is no user, no breakage is expected. This looks good to me: Acked-by: Horatiu Vultur <horatiu.vultur@microchip.com> > > I'm not sure it this should go through net or net-next and if the patches > should have a Fixes: tag or not. In upstream linux there was never any user > of it, so there is no bug to be fixed. But OTOH if the schema fix isn't > backported, then there might be an older schema version still containing > the reset node. Thoughts? > > The patches needed for the GPIO part are just waiting to be picked up by > Linus [2,3]. This patch and the GPIO parts are the last pieces of the > puzzle to get ethernet working on the LAN9668 on upstream linux. > > [1] https://lore.kernel.org/netdev/20220330110210.3374165-1-michael@walle.cc/ > [2] https://lore.kernel.org/linux-gpio/CACRpkdbxmN+SWt95aGHjA2ZGnN61aWaA7c5S4PaG+WePAj=htg@mail.gmail.com/ > [3] https://lore.kernel.org/linux-gpio/20220420191926.3411830-1-michael@walle.cc/ > > Michael Walle (2): > dt-bindings: net: lan966x: remove PHY reset > net: lan966x: remove PHY reset support > > .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 2 -- > drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 8 +------- > 2 files changed, 1 insertion(+), 9 deletions(-) > > -- > 2.30.2 >
On Thu, Apr 28, 2022 at 01:40:47PM +0200, Michael Walle wrote: > Remove the unneeded PHY reset node as well as the driver support for it. > > This was already discussed [1] and I expect Microchip to Ack on this > removal. Since there is no user, no breakage is expected. > > I'm not sure it this should go through net or net-next and if the patches > should have a Fixes: tag or not. In upstream linux there was never any user > of it, so there is no bug to be fixed. But OTOH if the schema fix isn't > backported, then there might be an older schema version still containing > the reset node. Thoughts? Is the switch driver usable in the last LTS kernel? Somebody could build a product around 5.15, and i assume they will have issues? That could be an argument for backporting. Andrew
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 28 Apr 2022 13:40:47 +0200 you wrote: > Remove the unneeded PHY reset node as well as the driver support for it. > > This was already discussed [1] and I expect Microchip to Ack on this > removal. Since there is no user, no breakage is expected. > > I'm not sure it this should go through net or net-next and if the patches > should have a Fixes: tag or not. In upstream linux there was never any user > of it, so there is no bug to be fixed. But OTOH if the schema fix isn't > backported, then there might be an older schema version still containing > the reset node. Thoughts? > > [...] Here is the summary with links: - [net-next,1/2] dt-bindings: net: lan966x: remove PHY reset https://git.kernel.org/netdev/net-next/c/4fdabd509df3 - [net-next,2/2] net: lan966x: remove PHY reset support https://git.kernel.org/netdev/net-next/c/5b06ef86826a You are awesome, thank you!