mbox series

[net-next,0/2] vsock/virtio: add support for device suspend/resume

Message ID 20220428132241.152679-1-sgarzare@redhat.com (mailing list archive)
Headers show
Series vsock/virtio: add support for device suspend/resume | expand

Message

Stefano Garzarella April 28, 2022, 1:22 p.m. UTC
Vilas reported that virtio-vsock no longer worked properly after
suspend/resume (echo mem >/sys/power/state).
It was impossible to connect to the host and vice versa.

Indeed, the support has never been implemented.

This series implement .freeze and .restore callbacks of struct virtio_driver
to support device suspend/resume.

The first patch factors our the code to initialize and delete VQs.
The second patch uses that code to support device suspend/resume.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>

Stefano Garzarella (2):
  vsock/virtio: factor our the code to initialize and delete VQs
  vsock/virtio: add support for device suspend/resume

 net/vmw_vsock/virtio_transport.c | 197 ++++++++++++++++++++-----------
 1 file changed, 131 insertions(+), 66 deletions(-)

Comments

Jakub Kicinski May 2, 2022, 9:35 p.m. UTC | #1
On Thu, 28 Apr 2022 15:22:39 +0200 Stefano Garzarella wrote:
> Vilas reported that virtio-vsock no longer worked properly after
> suspend/resume (echo mem >/sys/power/state).
> It was impossible to connect to the host and vice versa.
> 
> Indeed, the support has never been implemented.
> 
> This series implement .freeze and .restore callbacks of struct virtio_driver
> to support device suspend/resume.
> 
> The first patch factors our the code to initialize and delete VQs.
> The second patch uses that code to support device suspend/resume.

This set got a "Not Applicable" in patchwork, I'm not sure why.
Michael I presume net-next is fine? Can we get an Ack?
Michael S. Tsirkin May 2, 2022, 10:20 p.m. UTC | #2
On Thu, Apr 28, 2022 at 03:22:39PM +0200, Stefano Garzarella wrote:
> Vilas reported that virtio-vsock no longer worked properly after
> suspend/resume (echo mem >/sys/power/state).
> It was impossible to connect to the host and vice versa.
> 
> Indeed, the support has never been implemented.
> 
> This series implement .freeze and .restore callbacks of struct virtio_driver
> to support device suspend/resume.
> 
> The first patch factors our the code to initialize and delete VQs.
> The second patch uses that code to support device suspend/resume.
> 
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>


Acked-by: Michael S. Tsirkin <mst@redhat.com>

> Stefano Garzarella (2):
>   vsock/virtio: factor our the code to initialize and delete VQs
>   vsock/virtio: add support for device suspend/resume
> 
>  net/vmw_vsock/virtio_transport.c | 197 ++++++++++++++++++++-----------
>  1 file changed, 131 insertions(+), 66 deletions(-)
> 
> -- 
> 2.35.1
Jakub Kicinski May 2, 2022, 11:07 p.m. UTC | #3
On Mon, 2 May 2022 18:20:51 -0400 Michael S. Tsirkin wrote:
> On Thu, Apr 28, 2022 at 03:22:39PM +0200, Stefano Garzarella wrote:
> > Vilas reported that virtio-vsock no longer worked properly after
> > suspend/resume (echo mem >/sys/power/state).
> > It was impossible to connect to the host and vice versa.
> > 
> > Indeed, the support has never been implemented.
> > 
> > This series implement .freeze and .restore callbacks of struct virtio_driver
> > to support device suspend/resume.
> > 
> > The first patch factors our the code to initialize and delete VQs.
> > The second patch uses that code to support device suspend/resume.
> > 
> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>  
> 
> 
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

Commit 0530a683fc85 ("Merge branch
'vsock-virtio-add-support-for-device-suspend-resume'") in net-next, now.
Thank you!