From patchwork Fri May 13 18:33:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 12849235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD4DC433EF for ; Fri, 13 May 2022 18:34:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379396AbiEMSeR (ORCPT ); Fri, 13 May 2022 14:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231376AbiEMSeQ (ORCPT ); Fri, 13 May 2022 14:34:16 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99F185EBF8 for ; Fri, 13 May 2022 11:34:15 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id a19so8052193pgw.6 for ; Fri, 13 May 2022 11:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BacdIw/ayB1L43gXLgUeK7ycc77mDHARdZt0XFM6wXY=; b=pQJz5H/LKl61NsRvNzrXav2bZUGwDm/+RHriETY3BBGzNQo6vySfsGKsHyW9hso3IX sC9x8vf8q+++syKTRFmc/UM3daJNZrDRI+CiPFU56iOY6n1f+RBcthpO4mhyoQPXas4h zSb4oJm4Hr74y6fdUyf0egINM/JWToQFwsWiKFBTenMUdSITjHZ7B6qlK2UKCN170VYp vbLXen2XX3S2M1dx/vvnldUVk84ttGuSgKI3BCSAn2XAX/WH/ZRZM0qjrBWJnYMd0n/1 XgZ0LuvVnhA+8A8fWCutUE/hAylM8cnflXf9TWUGzm45nMdIWlDx3Qy/6w0pr+Uzyp72 fPVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BacdIw/ayB1L43gXLgUeK7ycc77mDHARdZt0XFM6wXY=; b=mGZ2pO9ky+Y2HuftX6QCJ9jzSQl68vM+9GCTf0Y0uMxxBdao7nRXbYjfpbbdxzjY2x 0uwSLCPFZjDcm4N1vXfLkyMzdkiKt2A9kuy5Z5jGO/gJsZCe4Bp5z7GzodVAyeXvdc7B F++RMEJcT5zY0x6R2CfVIAxRparUq87xzjC6jNalP7f3phw78S9OwIUKFLnaf7mXulW0 zhDbdC3MUb0yy+0INySOG55JiSwxpWHCu00kJ4bK8g55cOVprAZBqrUSmupd+G7Hwlx0 rddoxfx+snFnxmXx1reVnPSURuUT08ipYv0Dflf2Y5hoRri5t0RQEw8PF0eCdDr9cUBi XOWg== X-Gm-Message-State: AOAM530fuROcR74pfi0dS6e7m+fvyhsEeiAMvNW2PPSapa1PcBB22jiG dCRfj0LleuK9KCmKj7WvEGw= X-Google-Smtp-Source: ABdhPJz4tYnhdeWTveKF9ltsaP6PQUxKo3hb28m/fe07pDaaFk8OzckYjfDiIDxMzfUSSzJkC7gh8g== X-Received: by 2002:a05:6a00:1a12:b0:512:6f59:f5cf with SMTP id g18-20020a056a001a1200b005126f59f5cfmr5899199pfv.45.1652466855012; Fri, 13 May 2022 11:34:15 -0700 (PDT) Received: from edumazet1.svl.corp.google.com ([2620:15c:2c4:201:c436:3fa3:479f:a7a]) by smtp.gmail.com with ESMTPSA id q13-20020aa7842d000000b0050dc76281cesm2053566pfn.168.2022.05.13.11.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 11:34:14 -0700 (PDT) From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: netdev , Alexander Duyck , Coco Li , Eric Dumazet , Eric Dumazet Subject: [PATCH v7 net-next 00/13] tcp: BIG TCP implementation Date: Fri, 13 May 2022 11:33:55 -0700 Message-Id: <20220513183408.686447-1-eric.dumazet@gmail.com> X-Mailer: git-send-email 2.36.0.550.gb090851708-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Eric Dumazet This series implements BIG TCP as presented in netdev 0x15: https://netdevconf.info/0x15/session.html?BIG-TCP Jonathan Corbet made a nice summary: https://lwn.net/Articles/884104/ Standard TSO/GRO packet limit is 64KB With BIG TCP, we allow bigger TSO/GRO packet sizes for IPv6 traffic. Note that this feature is by default not enabled, because it might break some eBPF programs assuming TCP header immediately follows IPv6 header. While tcpdump recognizes the HBH/Jumbo header, standard pcap filters are unable to skip over IPv6 extension headers. Reducing number of packets traversing networking stack usually improves performance, as shown on this experiment using a 100Gbit NIC, and 4K MTU. 'Standard' performance with current (74KB) limits. for i in {1..10}; do ./netperf -t TCP_RR -H iroa23 -- -r80000,80000 -O MIN_LATENCY,P90_LATENCY,P99_LATENCY,THROUGHPUT|tail -1; done 77 138 183 8542.19 79 143 178 8215.28 70 117 164 9543.39 80 144 176 8183.71 78 126 155 9108.47 80 146 184 8115.19 71 113 165 9510.96 74 113 164 9518.74 79 137 178 8575.04 73 111 171 9561.73 Now enable BIG TCP on both hosts. ip link set dev eth0 gro_max_size 185000 gso_max_size 185000 for i in {1..10}; do ./netperf -t TCP_RR -H iroa23 -- -r80000,80000 -O MIN_LATENCY,P90_LATENCY,P99_LATENCY,THROUGHPUT|tail -1; done 57 83 117 13871.38 64 118 155 11432.94 65 116 148 11507.62 60 105 136 12645.15 60 103 135 12760.34 60 102 134 12832.64 62 109 132 10877.68 58 82 115 14052.93 57 83 124 14212.58 57 82 119 14196.01 We see an increase of transactions per second, and lower latencies as well. v7: adopt unsafe_memcpy() in mlx5 to avoid FORTIFY warnings. v6: fix a compilation error for CONFIG_IPV6=n in "net: allow gso_max_size to exceed 65536", reported by kernel bots. v5: Replaced two patches (that were adding new attributes) with patches from Alexander Duyck. Idea is to reuse existing gso_max_size/gro_max_size v4: Rebased on top of Jakub series (Merge branch 'tso-gso-limit-split') max_tso_size is now family independent. v3: Fixed a typo in RFC number (Alexander) Added Reviewed-by: tags from Tariq on mlx4/mlx5 parts. v2: Removed the MAX_SKB_FRAGS change, this belongs to a different series. Addressed feedback, for Alexander and nvidia folks. Alexander Duyck (2): net: allow gso_max_size to exceed 65536 net: allow gro_max_size to exceed 65536 Coco Li (1): ipv6: Add hop-by-hop header to jumbograms in ip6_output Eric Dumazet (10): net: add IFLA_TSO_{MAX_SIZE|SEGS} attributes net: limit GSO_MAX_SIZE to 524280 bytes tcp_cubic: make hystart_ack_delay() aware of BIG TCP ipv6: add struct hop_jumbo_hdr definition ipv6/gso: remove temporary HBH/jumbo header ipv6/gro: insert temporary HBH/jumbo header net: loopback: enable BIG TCP packets veth: enable BIG TCP packets mlx4: support BIG TCP packets mlx5: support BIG TCP packets drivers/net/ethernet/amd/xgbe/xgbe.h | 3 +- .../net/ethernet/mellanox/mlx4/en_netdev.c | 3 + drivers/net/ethernet/mellanox/mlx4/en_tx.c | 47 ++++++-- .../net/ethernet/mellanox/mlx5/core/en_main.c | 1 + .../net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_tx.c | 111 ++++++++++++++---- drivers/net/ethernet/sfc/ef100_nic.c | 3 +- drivers/net/ethernet/sfc/falcon/tx.c | 3 +- drivers/net/ethernet/sfc/tx_common.c | 3 +- drivers/net/ethernet/synopsys/dwc-xlgmac.h | 3 +- drivers/net/hyperv/rndis_filter.c | 2 +- drivers/net/loopback.c | 2 + drivers/net/veth.c | 1 + drivers/scsi/fcoe/fcoe.c | 2 +- include/linux/ipv6.h | 1 + include/linux/netdevice.h | 15 ++- include/net/ipv6.h | 44 +++++++ include/uapi/linux/if_link.h | 2 + net/bpf/test_run.c | 2 +- net/core/dev.c | 9 +- net/core/gro.c | 8 ++ net/core/rtnetlink.c | 16 ++- net/core/sock.c | 14 +++ net/ipv4/tcp_bbr.c | 2 +- net/ipv4/tcp_cubic.c | 4 +- net/ipv4/tcp_output.c | 2 +- net/ipv6/ip6_offload.c | 56 ++++++++- net/ipv6/ip6_output.c | 22 +++- net/sctp/output.c | 3 +- tools/include/uapi/linux/if_link.h | 2 + 30 files changed, 321 insertions(+), 67 deletions(-)