| Message ID | 20220517085143.3749-1-josua@solid-run.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | adin: add support for clock output | expand |
On Tue, 17 May 2022 11:51:36 +0300 Josua Mayer wrote: > This patch series adds support for configuring the two clock outputs of adin > 1200 and 1300 PHYs. Certain network controllers require an external reference > clock which can be provided by the PHY. > > One of the replies to v1 was asking why the common clock framework isn't used. > Currently no PHY driver has implemented providing a clock to the network > controller. Instead they rely on vendor extensions to make the appropriate > configuration. For example ar8035 uses qca,clk-out-frequency - this patchset > aimed to replicate the same functionality. > > Finally the 125MHz free-running clock is enabled in the device-tree for > SolidRun i.MX6 SoMs, to support revisions 1.9 and later, where the original phy > has been replaced with an adin 1300. > To avoid introducing new warning messages during boot for SoMs before rev 1.9, > the status field of the new phy node is disabled by default, and will be > enabled by U-Boot on demand. > > Changes since v4: > - removed recovered clock options Acked-by: Jakub Kicinski <kuba@kernel.org> Thanks!
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 17 May 2022 11:51:36 +0300 you wrote: > This patch series adds support for configuring the two clock outputs of adin > 1200 and 1300 PHYs. Certain network controllers require an external reference > clock which can be provided by the PHY. > > One of the replies to v1 was asking why the common clock framework isn't used. > Currently no PHY driver has implemented providing a clock to the network > controller. Instead they rely on vendor extensions to make the appropriate > configuration. For example ar8035 uses qca,clk-out-frequency - this patchset > aimed to replicate the same functionality. > > [...] Here is the summary with links: - [v5,1/3] dt-bindings: net: adin: document phy clock output properties https://git.kernel.org/netdev/net-next/c/1f77204e11f8 - [v5,2/3] net: phy: adin: add support for clock output https://git.kernel.org/netdev/net-next/c/ce3342161edc - [v5,3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 https://git.kernel.org/netdev/net-next/c/654cd22227e6 You are awesome, thank you!
This patch series adds support for configuring the two clock outputs of adin 1200 and 1300 PHYs. Certain network controllers require an external reference clock which can be provided by the PHY. One of the replies to v1 was asking why the common clock framework isn't used. Currently no PHY driver has implemented providing a clock to the network controller. Instead they rely on vendor extensions to make the appropriate configuration. For example ar8035 uses qca,clk-out-frequency - this patchset aimed to replicate the same functionality. Finally the 125MHz free-running clock is enabled in the device-tree for SolidRun i.MX6 SoMs, to support revisions 1.9 and later, where the original phy has been replaced with an adin 1300. To avoid introducing new warning messages during boot for SoMs before rev 1.9, the status field of the new phy node is disabled by default, and will be enabled by U-Boot on demand. Changes since v4: - removed recovered clock options Changes since v3: - fix coding style violations reported by Andrew and checkpatch - changed type of adi,phy-output-reference-clock from flag to boolean Changes since v2: - set new phy node status to disabled - fix integer-as-null-pointer compiler warning Reported-by: kernel test robot <lkp@intel.com> Changes since v1: - renamed device-tree property and changed to enum - added device-tree property for second clock output - implemented all bits from the clock configuration register Josua Mayer (3): dt-bindings: net: adin: document phy clock output properties net: phy: adin: add support for clock output ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 .../devicetree/bindings/net/adi,adin.yaml | 15 +++++++ arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 10 +++++ drivers/net/phy/adin.c | 40 +++++++++++++++++++ 3 files changed, 65 insertions(+)