From patchwork Tue May 17 16:34:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 12852738 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EFE6C43217 for ; Tue, 17 May 2022 16:35:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350955AbiEQQfD (ORCPT ); Tue, 17 May 2022 12:35:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350912AbiEQQfA (ORCPT ); Tue, 17 May 2022 12:35:00 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 567404EF40; Tue, 17 May 2022 09:34:56 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id E4FD41BF206; Tue, 17 May 2022 16:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1652805294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1C6/OoL4x3xbcNLsvvdThUQzvrdFL+c7yTwDjfyPM+g=; b=aD2gQn7j877VzjZrfHlvv3aeVXEe2vD9tSh0CZzOGNx5FKsxQweFODPmE0vzfdjfiySU5I 4GHPJDwyYt19Q1PtsEmkSo7xgP8qdpHUs1Ylhp9Nt39qS55Na+D6qCfkZqiYuGk3DhMLNa qAHitdAoTOopRg5LqOHt8YJAUItZtjkM98mENJTFtm4zx3oQrgV4gMAiZQS148Vgl0Xncu TQ9mQeJpLcr0XW3ksC8gpU8M8ClzKoa8kZ91oYJDTR7gggr+Oqvi/zvZfXhw2DmVhFLIlz CEy+ffUHeQOlOkCIXcoKuXhczNRbFrNnHWkqXWZroM7yrPudbIeMqN7463LuQA== From: Miquel Raynal To: Alexander Aring , Stefan Schmidt , linux-wpan@vger.kernel.org Cc: David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Thomas Petazzoni , "David S. Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Miquel Raynal Subject: [PATCH wpan-next v3 00/11] ieee802154: Synchronous Tx support Date: Tue, 17 May 2022 18:34:39 +0200 Message-Id: <20220517163450.240299-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, This series brings support for that famous synchronous Tx API for MLME commands. MLME commands will be used during scan operations. In this situation, we need to be sure that all transfers finished and that no transfer will be queued for a short moment. Cheers, Miquèl Changes in v3: * Tested with lockdep enabled, a more aggressive preemption level and the sleeping while atomic warnings enabled. * Changed the hold/release queue mutex into a spinlock. * Split the mlme_tx function into three, one to hold the queue, then another part that does takes the rtnl and has the real content, and a last helper to release the queue. * Fixed the warning condition in the slow path. * Used an unsigned long and test/set_bit helpers to follow the queue state instead of an atomic_t. Changes in v2: * Updated the main tx function error path. * Added a missing atomic_dec_at_test() call on the hold counter. * Always called (upon a certain condition) the queue wakeup helper from the release queue helper (and similarly in the hold helper) and squashed two existing patches in it to simplify the series. * Introduced a mutex to serialize accesses to the increment/decrement of the hold counter and the wake up call. * Added a warning in case an MLME Tx gets triggered while the device was stopped. * Used the rtnl to ensure the device cannot be stopped while an MLME transmission is ongoing. Changes in v1 since this series got extracted from a bigger change: * Introduced a new atomic variable to know when the queue is actually stopped. So far we only had an atomic to know when the queue was held (indicates a transitioning state towards a stopped queue only) and another atomic indicating if a transfer was still ongoing at this point (used by the wait logic as a condition to wake up). Miquel Raynal (11): net: mac802154: Rename the synchronous xmit worker net: mac802154: Rename the main tx_work struct net: mac802154: Enhance the error path in the main tx helper net: mac802154: Follow the count of ongoing transmissions net: mac802154: Bring the ability to hold the transmit queue net: mac802154: Create a hot tx path net: mac802154: Introduce a helper to disable the queue net: mac802154: Introduce a tx queue flushing mechanism net: mac802154: Introduce a synchronous API for MLME commands net: mac802154: Add a warning in the hot path net: mac802154: Add a warning in the slow path include/net/cfg802154.h | 9 ++- include/net/mac802154.h | 27 ------- net/ieee802154/core.c | 3 + net/mac802154/cfg.c | 4 +- net/mac802154/ieee802154_i.h | 37 ++++++++- net/mac802154/main.c | 2 +- net/mac802154/tx.c | 147 +++++++++++++++++++++++++++++++---- net/mac802154/util.c | 71 +++++++++++++++-- 8 files changed, 246 insertions(+), 54 deletions(-)