From patchwork Fri Jun 3 10:09:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugenio Perez Martin X-Patchwork-Id: 12868915 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4A0C433EF for ; Fri, 3 Jun 2022 10:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243424AbiFCKKG (ORCPT ); Fri, 3 Jun 2022 06:10:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243381AbiFCKJ6 (ORCPT ); Fri, 3 Jun 2022 06:09:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DE1703B02E for ; Fri, 3 Jun 2022 03:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654250995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=idp6ThZhNo+GCJ/QXSxEg9bFnM2OmX/SaaK0aBYeq44=; b=Xya8YLESeRDg1zwpZKmYqS7MDtc53YXCY+D8pDheF+NDy8+9lfDhMJsE0Y6bJpShXBRMB5 s+uhg6PkiDf06R76BuVQyyef+9FUI2eoCMEkh1pQo5RPUA5AoDQrEAAFRxvVazA9c6YPMm WdE+7QqZdI4A2Pt+0LLBIYE6+E9V+SU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-133-Knw5QX-HNVSZcpQAsToNAQ-1; Fri, 03 Jun 2022 06:09:54 -0400 X-MC-Unique: Knw5QX-HNVSZcpQAsToNAQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 494951C06EE5; Fri, 3 Jun 2022 10:09:53 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.40.192.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1964E492C3B; Fri, 3 Jun 2022 10:09:46 +0000 (UTC) From: =?utf-8?q?Eugenio_P=C3=A9rez?= To: kvm@vger.kernel.org, Jason Wang , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Christophe JAILLET , Longpeng , Stefano Garzarella , dinang@xilinx.com, Piotr.Uminski@intel.com, martinpo@xilinx.com, tanuj.kamde@amd.com, Parav Pandit , Zhang Min , habetsm.xilinx@gmail.com, Zhu Lingshan , lulu@redhat.com, hanand@xilinx.com, martinh@xilinx.com, Si-Wei Liu , gautam.dawar@amd.com, Xie Yongji , ecree.xilinx@gmail.com, pabloc@xilinx.com, lvivier@redhat.com, Eli Cohen , Wu Zongyong , Dan Carpenter Subject: [PATCH v5 0/4] Implement vdpasim suspend operation Date: Fri, 3 Jun 2022 12:09:40 +0200 Message-Id: <20220603100944.871727-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Implement suspend operation for vdpa_sim devices, so vhost-vdpa will offer that backend feature and userspace can effectively suspend the device. This is a must before getting virtqueue indexes (base) for live migration, since the device could modify them after userland gets them. There are individual ways to perform that action for some devices (VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there was no way to perform it for any vhost device (and, in particular, vhost-vdpa). After a successful return of ioctl with suspend = 1, the device must not process more virtqueue descriptors, and it must not send any config interrupt. The device can answer to read or writes of config fields as if it were not suspended. In particular, writing to "queue_enable" with a value of 1 will not make the device start processing buffers of the virtqueue until the device is resumed (suspend = 0). After a successful return of ioctl with suspend = 0, the device will start processing data of the virtqueues if other expected conditions are met (queue is enabled, DRIVER_OK has already been set to status, etc.) If not, the device should be in the same state as if no call to suspend callback with suspend = 1 has been performed. In the future, we will provide features similar to VHOST_USER_GET_INFLIGHT_FD so the device can save pending operations. Comments are welcome. v6: * s/stop/suspend/ to differentiate more from reset. * Clarify scope of the suspend operation. v5: * s/not stop/resume/ in doc. v4: * Replace VHOST_STOP to VHOST_VDPA_STOP in vhost ioctl switch case too. v3: * s/VHOST_STOP/VHOST_VDPA_STOP/ * Add documentation and requirements of the ioctl above its definition. v2: * Replace raw _F_STOP with BIT_ULL(_F_STOP). * Fix obtaining of stop ioctl arg (it was not obtained but written). * Add stop to vdpa_sim_blk. Eugenio Pérez (4): vdpa: Add suspend operation vhost-vdpa: introduce SUSPEND backend feature bit vhost-vdpa: uAPI to suspend the device vdpa_sim: Implement suspend vdpa op drivers/vdpa/vdpa_sim/vdpa_sim.c | 21 +++++++++++++ drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 + drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 3 ++ drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 3 ++ drivers/vhost/vdpa.c | 47 +++++++++++++++++++++++++++- include/linux/vdpa.h | 5 +++ include/uapi/linux/vhost.h | 14 +++++++++ include/uapi/linux/vhost_types.h | 2 ++ 8 files changed, 95 insertions(+), 1 deletion(-) --- 2.31.1