mbox series

[net-next,v4,0/3] reorganize the code of the enum skb_drop_reason

Message ID 20220606022436.331005-1-imagedong@tencent.com (mailing list archive)
Headers show
Series reorganize the code of the enum skb_drop_reason | expand

Message

Menglong Dong June 6, 2022, 2:24 a.m. UTC
From: Menglong Dong <imagedong@tencent.com>

The code of skb_drop_reason is a little wild, let's reorganize them.
Three things and three patches:

1) Move the enum 'skb_drop_reason' and related function to the standalone
   header 'dropreason.h', as Jakub Kicinski suggested, as the skb drop
   reasons are getting more and more.

2) use auto-generation to generate the source file that convert enum
   skb_drop_reason to string.

3) make the comment of skb drop reasons kernel-doc style.

Changes since v3:
3/3: remove some useless comment (Jakub Kicinski)

Changes since v2:
2/3: - add new line in the end of .gitignore
     - fix awk warning by make '\;' to ';', as ';' is not need to be
       escaped
     - export 'drop_reasons' in skbuff.c

Changes since v1:
1/3: move dropreason.h from include/linux/ to include/net/ (Jakub Kicinski)
2/3: generate source file instead of header file for drop reasons string
     array (Jakub Kicinski)
3/3: use inline comment (Jakub Kicinski)

Menglong Dong (3):
  net: skb: move enum skb_drop_reason to standalone header file
  net: skb: use auto-generation to convert skb drop reason to string
  net: dropreason: reformat the comment fo skb drop reasons

 include/linux/skbuff.h     | 179 +-------------------------
 include/net/dropreason.h   | 256 +++++++++++++++++++++++++++++++++++++
 include/trace/events/skb.h |  89 +------------
 net/core/.gitignore        |   1 +
 net/core/Makefile          |  23 +++-
 net/core/drop_monitor.c    |  13 --
 net/core/skbuff.c          |   3 +
 7 files changed, 284 insertions(+), 280 deletions(-)
 create mode 100644 include/net/dropreason.h
 create mode 100644 net/core/.gitignore

Comments

patchwork-bot+netdevbpf@kernel.org June 7, 2022, 11:10 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Mon,  6 Jun 2022 10:24:33 +0800 you wrote:
> From: Menglong Dong <imagedong@tencent.com>
> 
> The code of skb_drop_reason is a little wild, let's reorganize them.
> Three things and three patches:
> 
> 1) Move the enum 'skb_drop_reason' and related function to the standalone
>    header 'dropreason.h', as Jakub Kicinski suggested, as the skb drop
>    reasons are getting more and more.
> 
> [...]

Here is the summary with links:
  - [net-next,v4,1/3] net: skb: move enum skb_drop_reason to standalone header file
    https://git.kernel.org/netdev/net-next/c/ff8372a467fa
  - [net-next,v4,2/3] net: skb: use auto-generation to convert skb drop reason to string
    https://git.kernel.org/netdev/net-next/c/ec43908dd556
  - [net-next,v4,3/3] net: dropreason: reformat the comment fo skb drop reasons
    https://git.kernel.org/netdev/net-next/c/b160f7270e6d

You are awesome, thank you!