mbox series

[bpf-next,0/3] Fix few compiler warnings in selftests and libbpf

Message ID 20220705224818.4026623-1-andrii@kernel.org (mailing list archive)
Headers show
Series Fix few compiler warnings in selftests and libbpf | expand

Message

Andrii Nakryiko July 5, 2022, 10:48 p.m. UTC
Few small patches fixing compiler warning issues detected by Coverity or by
building selftests in -O2 mode.

Andrii Nakryiko (3):
  selftests/bpf: fix bogus uninitialized variable warning
  selftests/bpf: fix few more compiler warnings
  libbpf: remove unnecessary usdt_rel_ip assignments

 tools/lib/bpf/usdt.c                                       | 6 ++----
 tools/testing/selftests/bpf/network_helpers.c              | 2 +-
 tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 4 ++--
 tools/testing/selftests/bpf/prog_tests/usdt.c              | 2 +-
 tools/testing/selftests/bpf/prog_tests/xdp_synproxy.c      | 2 +-
 5 files changed, 7 insertions(+), 9 deletions(-)

Comments

Yonghong Song July 6, 2022, 6:47 a.m. UTC | #1
On 7/5/22 3:48 PM, Andrii Nakryiko wrote:
> Few small patches fixing compiler warning issues detected by Coverity or by
> building selftests in -O2 mode.
> 
> Andrii Nakryiko (3):
>    selftests/bpf: fix bogus uninitialized variable warning
>    selftests/bpf: fix few more compiler warnings
>    libbpf: remove unnecessary usdt_rel_ip assignments
> 
>   tools/lib/bpf/usdt.c                                       | 6 ++----
>   tools/testing/selftests/bpf/network_helpers.c              | 2 +-
>   tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 4 ++--
>   tools/testing/selftests/bpf/prog_tests/usdt.c              | 2 +-
>   tools/testing/selftests/bpf/prog_tests/xdp_synproxy.c      | 2 +-
>   5 files changed, 7 insertions(+), 9 deletions(-)
> 
Ack for the whole series:

Acked-by: Yonghong Song <yhs@fb.com>
Jiri Olsa July 6, 2022, 8:11 a.m. UTC | #2
On Tue, Jul 05, 2022 at 03:48:15PM -0700, Andrii Nakryiko wrote:
> Few small patches fixing compiler warning issues detected by Coverity or by
> building selftests in -O2 mode.
> 
> Andrii Nakryiko (3):
>   selftests/bpf: fix bogus uninitialized variable warning
>   selftests/bpf: fix few more compiler warnings
>   libbpf: remove unnecessary usdt_rel_ip assignments
> 
>  tools/lib/bpf/usdt.c                                       | 6 ++----
>  tools/testing/selftests/bpf/network_helpers.c              | 2 +-
>  tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 4 ++--
>  tools/testing/selftests/bpf/prog_tests/usdt.c              | 2 +-
>  tools/testing/selftests/bpf/prog_tests/xdp_synproxy.c      | 2 +-
>  5 files changed, 7 insertions(+), 9 deletions(-)

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka
patchwork-bot+netdevbpf@kernel.org July 6, 2022, 2:50 p.m. UTC | #3
Hello:

This series was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Tue, 5 Jul 2022 15:48:15 -0700 you wrote:
> Few small patches fixing compiler warning issues detected by Coverity or by
> building selftests in -O2 mode.
> 
> Andrii Nakryiko (3):
>   selftests/bpf: fix bogus uninitialized variable warning
>   selftests/bpf: fix few more compiler warnings
>   libbpf: remove unnecessary usdt_rel_ip assignments
> 
> [...]

Here is the summary with links:
  - [bpf-next,1/3] selftests/bpf: fix bogus uninitialized variable warning
    https://git.kernel.org/bpf/bpf-next/c/645d5d3bc001
  - [bpf-next,2/3] selftests/bpf: fix few more compiler warnings
    https://git.kernel.org/bpf/bpf-next/c/c46a12200114
  - [bpf-next,3/3] libbpf: remove unnecessary usdt_rel_ip assignments
    https://git.kernel.org/bpf/bpf-next/c/7c8121af1bfe

You are awesome, thank you!