[stable,5.15,0/1] Revert "selftests/bpf: Add test for bpf_timer overwriting crash"

Message

Po-Hsu Lin July 7, 2022, 9:42 a.m. UTC

The bpf_timer overwriting crash test will cause bpf selftest build
fail on the stable 5.15 tree with:

progs/timer_crash.c:8:19: error: field has incomplete type 'struct bpf_timer'
        struct bpf_timer timer;
                         ^
/home/ubuntu/linux/tools/testing/selftests/bpf/tools/include/bpf/bpf_helper_defs.h:39:8:
note: forward declaration of 'struct bpf_timer'
struct bpf_timer;
       ^
1 error generated.

Test shows this can only be built with 5.17 and newer kernels. Let's
revert it for the 5.15 tree.

Po-Hsu Lin (1):
  Revert "selftests/bpf: Add test for bpf_timer overwriting crash"

 .../testing/selftests/bpf/prog_tests/timer_crash.c | 32 -------------
 tools/testing/selftests/bpf/progs/timer_crash.c    | 54 ----------------------
 2 files changed, 86 deletions(-)
 delete mode 100644 tools/testing/selftests/bpf/prog_tests/timer_crash.c
 delete mode 100644 tools/testing/selftests/bpf/progs/timer_crash.c

Comments

Greg Kroah-Hartman July 7, 2022, 6:05 p.m. UTC | #1

On Thu, Jul 07, 2022 at 05:42:06PM +0800, Po-Hsu Lin wrote:
> The bpf_timer overwriting crash test will cause bpf selftest build
> fail on the stable 5.15 tree with:
> 
> progs/timer_crash.c:8:19: error: field has incomplete type 'struct bpf_timer'
>         struct bpf_timer timer;
>                          ^
> /home/ubuntu/linux/tools/testing/selftests/bpf/tools/include/bpf/bpf_helper_defs.h:39:8:
> note: forward declaration of 'struct bpf_timer'
> struct bpf_timer;
>        ^
> 1 error generated.
> 
> Test shows this can only be built with 5.17 and newer kernels. Let's
> revert it for the 5.15 tree.
> 
> Po-Hsu Lin (1):
>   Revert "selftests/bpf: Add test for bpf_timer overwriting crash"
> 
>  .../testing/selftests/bpf/prog_tests/timer_crash.c | 32 -------------
>  tools/testing/selftests/bpf/progs/timer_crash.c    | 54 ----------------------
>  2 files changed, 86 deletions(-)
>  delete mode 100644 tools/testing/selftests/bpf/prog_tests/timer_crash.c
>  delete mode 100644 tools/testing/selftests/bpf/progs/timer_crash.c
> 
> -- 
> 2.7.4
> 

Now queued up, thanks.

greg k-h