From patchwork Thu Aug 25 18:12:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 12955111 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E660FECAA24 for ; Thu, 25 Aug 2022 18:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240817AbiHYSMw (ORCPT ); Thu, 25 Aug 2022 14:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243182AbiHYSMp (ORCPT ); Thu, 25 Aug 2022 14:12:45 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80D177333E for ; Thu, 25 Aug 2022 11:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661451161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=KiSNPKBlPRcccx1lRe0Q2eNIt6M0VYiwkWljd6A0lLc=; b=N2CJ1UhpeSdBXFA4SHLSF2rJyePwUcBdVxLzXMEf2gUSzOF1ra+6cUgHR8MBkul+Cy5ta4 uDGT7vBoHScDItk8Q52eNZ2t/yTb0qVFRozw9+/QoX54WPega1fVcgjnk1/Muboyqr0NOn vHbIudeiD4KhX/0QzFnbQGYraMxr/iQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-195--Pw9OLLFMGC3MfM3n1iocw-1; Thu, 25 Aug 2022 14:12:40 -0400 X-MC-Unique: -Pw9OLLFMGC3MfM3n1iocw-1 Received: by mail-wm1-f70.google.com with SMTP id i132-20020a1c3b8a000000b003a537064611so11202063wma.4 for ; Thu, 25 Aug 2022 11:12:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=KiSNPKBlPRcccx1lRe0Q2eNIt6M0VYiwkWljd6A0lLc=; b=icybjxDCHmjs7VlS2awo/6KkBWNft8NQj6rsjU4osI+fPa6pQd3xTwHvxIO/5Tjcht 3JHOjSQeq1cb34g+XDNpO8JwzhH+uxUggj29N9mLDRT7qLvxG08xIhMRN6QEM3TWjU1y QLE7bszA5ZZTxqa5FF4SmdAhoIP06RpClhovB1HSlxziDx8BMxXx8aEwRxfOOOvjM7SA 5Z0GbYeqQhUvPmEMB28YtkaxilSr+pwlOIqOL/LD6U6/cV26AkHHhHCfahqawQj8cMKb 8juvhVBNQvrvMEMQlIe4JAA4IMTYcNYFV6oGk6Rps1JpNc1fbIpi7D2W/UqnC7BzvUDd gMwQ== X-Gm-Message-State: ACgBeo1iv2l2JjMGkUVkqONtvzmrtf7LjSlYEtbbVBUU+hpOCRvWhbB9 rdmU+zsZTTvhyaczK0Eaxq0LdPvTqN8dpRIrRzDyfSQk1eheBrIM9slxswuClo3d5CGLS2n9vm+ aiPXU393vmDAjuuQIJb8cFUqCNMYCUtqfpVlMpYrcFuejmaUUTexbKGqag289tQ2ilKnJ X-Received: by 2002:a05:6000:1f19:b0:225:6e25:aa01 with SMTP id bv25-20020a0560001f1900b002256e25aa01mr2885528wrb.236.1661451159154; Thu, 25 Aug 2022 11:12:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR5/VNF/YtNl2382koJzD84Jd7vQmcSTDh7XnUSh9pQOvX49DkPEm+3sX79ZyFI9hYG7dU+Mbg== X-Received: by 2002:a05:6000:1f19:b0:225:6e25:aa01 with SMTP id bv25-20020a0560001f1900b002256e25aa01mr2885493wrb.236.1661451158813; Thu, 25 Aug 2022 11:12:38 -0700 (PDT) Received: from vschneid.remote.csb ([185.11.37.247]) by smtp.gmail.com with ESMTPSA id w1-20020a05600018c100b00225250f2d1bsm20371622wrq.94.2022.08.25.11.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 11:12:38 -0700 (PDT) From: Valentin Schneider To: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Mel Gorman , Greg Kroah-Hartman , Heiko Carstens , Tony Luck , Jonathan Cameron , Gal Pressman , Tariq Toukan , Jesse Brandeburg Subject: [PATCH v3 0/9] sched, net: NUMA-aware CPU spreading interface Date: Thu, 25 Aug 2022 19:12:01 +0100 Message-Id: <20220825181210.284283-1-vschneid@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi folks, Tariq pointed out in [1] that drivers allocating IRQ vectors would benefit from having smarter NUMA-awareness (cpumask_local_spread() doesn't quite cut it). The proposed interface involved an array of CPUs and a temporary cpumask, and being my difficult self what I'm proposing here is an interface that doesn't require any temporary storage other than some stack variables (at the cost of one wild macro). Patch 9/9 is just there to showcase how the thing would be used. If this doesn't get hated on, I'll let Tariq pick this up and push it with his networking driver changes (with actual changelogs). [1]: https://lore.kernel.org/all/20220728191203.4055-1-tariqt@nvidia.com/ A note on treewide use of for_each_cpu_andnot() =============================================== I've used the below coccinelle script to find places that could be patched (I couldn't figure out the valid syntax to patch from coccinelle itself): ,----- @tmpandnot@ expression tmpmask; iterator for_each_cpu; position p; statement S; @@ cpumask_andnot(tmpmask, ...); ... ( for_each_cpu@p(..., tmpmask, ...) S | for_each_cpu@p(..., tmpmask, ...) { ... } ) @script:python depends on tmpandnot@ p << tmpandnot.p; @@ coccilib.report.print_report(p[0], "andnot loop here") '----- Which yields (against c40e8341e3b3): .//arch/powerpc/kernel/smp.c:1587:1-13: andnot loop here .//arch/powerpc/kernel/smp.c:1530:1-13: andnot loop here .//arch/powerpc/kernel/smp.c:1440:1-13: andnot loop here .//arch/powerpc/platforms/powernv/subcore.c:306:2-14: andnot loop here .//arch/x86/kernel/apic/x2apic_cluster.c:62:1-13: andnot loop here .//drivers/acpi/acpi_pad.c:110:1-13: andnot loop here .//drivers/cpufreq/armada-8k-cpufreq.c:148:1-13: andnot loop here .//drivers/cpufreq/powernv-cpufreq.c:931:1-13: andnot loop here .//drivers/net/ethernet/sfc/efx_channels.c:73:1-13: andnot loop here .//drivers/net/ethernet/sfc/siena/efx_channels.c:73:1-13: andnot loop here .//kernel/sched/core.c:345:1-13: andnot loop here .//kernel/sched/core.c:366:1-13: andnot loop here .//net/core/dev.c:3058:1-13: andnot loop here A lot of those are actually of the shape for_each_cpu(cpu, mask) { ... cpumask_andnot(mask, ...); } I think *some* of the powerpc ones would be a match for for_each_cpu_andnot(), but I decided to just stick to the one obvious one in __sched_core_flip(). Revisions ========= v2 -> v3 ++++++++ o Added for_each_cpu_and() and for_each_cpu_andnot() tests (Yury) o New patches to fix issues raised by running the above o New patch to use for_each_cpu_andnot() in sched/core.c (Yury) v1 -> v2 ++++++++ o Split _find_next_bit() @invert into @invert1 and @invert2 (Yury) o Rebase onto v6.0-rc1 Cheers, Valentin Valentin Schneider (9): cpumask: Make cpumask_full() check for nr_cpu_ids bits lib/test_cpumask: Make test_cpumask_last check for nr_cpu_ids bits bitops: Introduce find_next_andnot_bit() cpumask: Introduce for_each_cpu_andnot() lib/test_cpumask: Add for_each_cpu_and(not) tests sched/core: Merge cpumask_andnot()+for_each_cpu() into for_each_cpu_andnot() sched/topology: Introduce sched_numa_hop_mask() sched/topology: Introduce for_each_numa_hop_cpu() SHOWCASE: net/mlx5e: Leverage for_each_numa_hop_cpu() drivers/net/ethernet/mellanox/mlx5/core/eq.c | 12 ++++- include/linux/cpumask.h | 41 ++++++++++++++++- include/linux/find.h | 44 ++++++++++++++++--- include/linux/topology.h | 46 ++++++++++++++++++++ kernel/sched/core.c | 5 +-- kernel/sched/topology.c | 28 ++++++++++++ lib/find_bit.c | 23 +++++----- lib/test_cpumask.c | 23 +++++++++- 8 files changed, 196 insertions(+), 26 deletions(-) --- 2.31.1