From patchwork Tue Sep 6 12:13:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shaozhengchao X-Patchwork-Id: 12967347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F1FC6FA83 for ; Tue, 6 Sep 2022 12:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234241AbiIFMLo (ORCPT ); Tue, 6 Sep 2022 08:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237863AbiIFMLn (ORCPT ); Tue, 6 Sep 2022 08:11:43 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28905786FC; Tue, 6 Sep 2022 05:11:41 -0700 (PDT) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MMPKd0Jw3zmVB1; Tue, 6 Sep 2022 20:08:05 +0800 (CST) Received: from huawei.com (10.175.101.6) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 6 Sep 2022 20:11:37 +0800 From: Zhengchao Shao To: , , , , , , , , , , CC: , , , , , , , , , , , , Subject: [PATCH net-next,v2 00/22] refactor the walk and lookup hook functions in tc_action_ops Date: Tue, 6 Sep 2022 20:13:24 +0800 Message-ID: <20220906121346.71578-1-shaozhengchao@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500026.china.huawei.com (7.185.36.106) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The implementation logic of the walk/lookup hook function in each action module is the same. Therefore, the two functions can be reconstructed. When registering tc_action_ops of each action module, the corresponding net_id is saved to tc_action_ops. In this way, the net_id of the corresponding module can be directly obtained in act_api without executing the specific walk and lookup hook functions. Then, generic functions can be added to replace the walk and lookup hook functions of each action module. Last, modify each action module in alphabetical order. Reserve the walk and lookup interfaces and delete them when they are no longer used. This patchset has been tested by using TDC, and I will add selftest in other patchset. Acked-by: Jamal Hadi Salim --- v1: save the net_id of each TC action module to the tc_action_ops structure --- Zhengchao Shao (22): net: sched: act: move global static variable net_id to tc_action_ops net: sched: act_api: implement generic walker and search for tc action net: sched: act_bpf: get rid of tcf_bpf_walker and tcf_bpf_search net: sched: act_connmark: get rid of tcf_connmark_walker and tcf_connmark_search net: sched: act_csum: get rid of tcf_csum_walker and tcf_csum_search net: sched: act_ct: get rid of tcf_ct_walker and tcf_ct_search net: sched: act_ctinfo: get rid of tcf_ctinfo_walker and tcf_ctinfo_search net: sched: act_gact: get rid of tcf_gact_walker and tcf_gact_search net: sched: act_gate: get rid of tcf_gate_walker and tcf_gate_search net: sched: act_ife: get rid of tcf_ife_walker and tcf_ife_search net: sched: act_ipt: get rid of tcf_ipt_walker/tcf_xt_walker and tcf_ipt_search/tcf_xt_search net: sched: act_mirred: get rid of tcf_mirred_walker and tcf_mirred_search net: sched: act_mpls: get rid of tcf_mpls_walker and tcf_mpls_search net: sched: act_nat: get rid of tcf_nat_walker and tcf_nat_search net: sched: act_pedit: get rid of tcf_pedit_walker and tcf_pedit_search net: sched: act_police: get rid of tcf_police_walker and tcf_police_search net: sched: act_sample: get rid of tcf_sample_walker and tcf_sample_search net: sched: act_simple: get rid of tcf_simp_walker and tcf_simp_search net: sched: act_skbedit: get rid of tcf_skbedit_walker and tcf_skbedit_search net: sched: act_skbmod: get rid of tcf_skbmod_walker and tcf_skbmod_search net: sched: act_tunnel_key: get rid of tunnel_key_walker and tunnel_key_search net: sched: act_vlan: get rid of tcf_vlan_walker and tcf_vlan_search include/net/act_api.h | 1 + net/sched/act_api.c | 33 ++++++++++++++++++--- net/sched/act_bpf.c | 28 +++-------------- net/sched/act_connmark.c | 28 +++-------------- net/sched/act_csum.c | 28 +++-------------- net/sched/act_ct.c | 32 ++++---------------- net/sched/act_ctinfo.c | 28 +++-------------- net/sched/act_gact.c | 28 +++-------------- net/sched/act_gate.c | 28 +++-------------- net/sched/act_ife.c | 28 +++-------------- net/sched/act_ipt.c | 61 +++++++------------------------------- net/sched/act_mirred.c | 28 +++-------------- net/sched/act_mpls.c | 28 +++-------------- net/sched/act_nat.c | 28 +++-------------- net/sched/act_pedit.c | 28 +++-------------- net/sched/act_police.c | 28 +++-------------- net/sched/act_sample.c | 28 +++-------------- net/sched/act_simple.c | 28 +++-------------- net/sched/act_skbedit.c | 28 +++-------------- net/sched/act_skbmod.c | 28 +++-------------- net/sched/act_tunnel_key.c | 28 +++-------------- net/sched/act_vlan.c | 28 +++-------------- 22 files changed, 118 insertions(+), 513 deletions(-)