mbox series

[0/7] cpumask: repair cpumask_check()

Message ID 20220919210559.1509179-1-yury.norov@gmail.com (mailing list archive)
Headers show
Series cpumask: repair cpumask_check() | expand

Message

Yury Norov Sept. 19, 2022, 9:05 p.m. UTC
After switching cpumask to use nr_cpu_ids in [1], cpumask_check() started
generating many false-positive warnings. There are some more issues with
the cpumask_check() that brake it.

This series fixes cpumask_check() mess and addresses most of the
false-positive warnings observed on boot of x86_64 and arm64.

[1] https://lore.kernel.org/lkml/20220905230820.3295223-4-yury.norov@gmail.com/T/

Yury Norov (7):
  cpumask: fix checking valid cpu range
  net: fix cpu_max_bits_warn() usage in netif_attrmask_next{,_and}
  cpumask: switch for_each_cpu{,_not} to use for_each_bit()
  lib/find_bit: add find_next{,_and}_bit_wrap
  lib/bitmap: introduce for_each_set_bit_wrap() macro
  lib/find: optimize for_each() macros
  lib/bitmap: add tests for for_each() iterators

 include/linux/cpumask.h   |  37 ++----
 include/linux/find.h      | 140 +++++++++++++++++-----
 include/linux/netdevice.h |  10 +-
 lib/cpumask.c             |  12 +-
 lib/test_bitmap.c         | 244 +++++++++++++++++++++++++++++++++++++-
 5 files changed, 375 insertions(+), 68 deletions(-)

Comments

Yury Norov Sept. 25, 2022, 3:47 p.m. UTC | #1
Ping?

On Mon, Sep 19, 2022 at 2:06 PM Yury Norov <yury.norov@gmail.com> wrote:
>
> After switching cpumask to use nr_cpu_ids in [1], cpumask_check() started
> generating many false-positive warnings. There are some more issues with
> the cpumask_check() that brake it.
>
> This series fixes cpumask_check() mess and addresses most of the
> false-positive warnings observed on boot of x86_64 and arm64.
>
> [1] https://lore.kernel.org/lkml/20220905230820.3295223-4-yury.norov@gmail.com/T/
>
> Yury Norov (7):
>   cpumask: fix checking valid cpu range
>   net: fix cpu_max_bits_warn() usage in netif_attrmask_next{,_and}
>   cpumask: switch for_each_cpu{,_not} to use for_each_bit()
>   lib/find_bit: add find_next{,_and}_bit_wrap
>   lib/bitmap: introduce for_each_set_bit_wrap() macro
>   lib/find: optimize for_each() macros
>   lib/bitmap: add tests for for_each() iterators
>
>  include/linux/cpumask.h   |  37 ++----
>  include/linux/find.h      | 140 +++++++++++++++++-----
>  include/linux/netdevice.h |  10 +-
>  lib/cpumask.c             |  12 +-
>  lib/test_bitmap.c         | 244 +++++++++++++++++++++++++++++++++++++-
>  5 files changed, 375 insertions(+), 68 deletions(-)
>
> --
> 2.34.1
>
Jakub Kicinski Sept. 26, 2022, 3:09 p.m. UTC | #2
On Sun, 25 Sep 2022 08:47:24 -0700 Yury Norov wrote:
> Ping?

Sugar sweet, you really need to say more than ping. You put the entire
recipient list in the To:, I have no idea what kind of feedback you
expect and from whom.
Yury Norov Sept. 26, 2022, 4:27 p.m. UTC | #3
On Mon, Sep 26, 2022 at 08:09:10AM -0700, Jakub Kicinski wrote:
> On Sun, 25 Sep 2022 08:47:24 -0700 Yury Norov wrote:
> > Ping?
> 
> Sugar sweet, you really need to say more than ping. You put the entire
> recipient list in the To:, I have no idea what kind of feedback you
> expect and from whom.

From you I'd like to have a feedback on patch #2