| Message ID | 20220921181054.40249-1-saeed@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mlx5 MACSec Extended packet number and replay window offload | expand |
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 21 Sep 2022 11:10:44 -0700 you wrote: > From: Saeed Mahameed <saeedm@nvidia.com> > > v2->v3: > - rebased > > v1->v2: > - Fix 32bit build isse > - Replay protection can work without EPN being enabled so moved the code out > of the EPN enabled check > > [...] Here is the summary with links: - [net-next,V3,01/10] net: macsec: Expose extended packet number (EPN) properties to macsec offload https://git.kernel.org/netdev/net-next/c/0a6e9b718dbb - [net-next,V3,02/10] net/mlx5: Fix fields name prefix in MACsec https://git.kernel.org/netdev/net-next/c/21803630c4ff - [net-next,V3,03/10] net/mlx5e: Fix MACsec initialization error path https://git.kernel.org/netdev/net-next/c/6c5e0b25db3a - [net-next,V3,04/10] net/mlx5e: Fix MACsec initial packet number https://git.kernel.org/netdev/net-next/c/cb6d3c0f1bae - [net-next,V3,05/10] net/mlx5: Add ifc bits for MACsec extended packet number (EPN) and replay protection https://git.kernel.org/netdev/net-next/c/23cc83c6ca87 - [net-next,V3,06/10] net/mlx5e: Expose memory key creation (mkey) function https://git.kernel.org/netdev/net-next/c/0e1e03c02f12 - [net-next,V3,07/10] net/mlx5e: Create advanced steering operation (ASO) object for MACsec https://git.kernel.org/netdev/net-next/c/1f53da676439 - [net-next,V3,08/10] net/mlx5e: Move MACsec initialization from profile init stage to profile enable stage https://git.kernel.org/netdev/net-next/c/3fd3fb6b6b88 - [net-next,V3,09/10] net/mlx5e: Support MACsec offload extended packet number (EPN) https://git.kernel.org/netdev/net-next/c/4411a6c0abd3 - [net-next,V3,10/10] net/mlx5e: Support MACsec offload replay window https://git.kernel.org/netdev/net-next/c/eb43846b43c3 You are awesome, thank you!
From: Saeed Mahameed <saeedm@nvidia.com> v2->v3: - rebased v1->v2: - Fix 32bit build isse - Replay protection can work without EPN being enabled so moved the code out of the EPN enabled check This is a follow up series to the previously submitted mlx5 MACsec offload [1] earlier this release cycle. In this series we add the support for MACsec Extended packet number and replay window offloads. First patch is a simple modification (code movements) to the core macsec code to allow exposing the EPN related user properties to the offloading device driver. The rest of the patches are mlx5 specific, we start off with fixing some trivial issues with mlx5 MACsec code, and a simple refactoring to allow additional functionality in mlx5 macsec to support EPN and window replay offloads. A) Expose mkey creation functionality to MACsec B) Expose ASO object to MACsec, to allow advanced steering operations, ASO objects are used to modify MACsec steering objects in fastpath. 1) Support MACsec offload extended packet number (EPN) MACsec EPN splits the packet number (PN) into two 32-bits fields, epn_lsb (32 least significant bits (LSBs) of PN) and epn_msb (32 most significant bits (MSBs) of PN). Epn_msb bits are managed by SW and for that HW is required to send an object change event of type EPN event notifying the SW to update the epn_msb in addition, once epn_msb is updated SW update HW with the new epn_msb value for HW to perform replay protection. To prevent HW from stopping while handling the event, SW manages another bit for HW called epn_overlap, HW uses the latter to get an indication regarding how to read the epn_msb value correctly while still receiving packets. Add epn event handling that updates the epn_overlap and epn_msb for every 2^31 packets according to the following logic: if epn_lsb crosses 2^31 (half sequence number wraparound) upon HW relevant event, SW updates the esn_overlap value to OLD (value = 1). When the epn_lsb crosses 2^32 (full sequence number wraparound) upon HW relevant event, SW updates the esn_overlap to NEW (value = 0) and increment the esn_msb. When using MACsec EPN a salt and short secure channel id (ssci) needs to be provided by the user, when offloading EPN need to pass this salt and ssci to the HW to be used in the initial vector (IV) calculations. 2) Support MACsec offload replay window Support setting replay window size for MACsec offload. Currently supported window size of 32, 64, 128 and 256 bit. Other values will be returned as invalid parameter. [1] https://lore.kernel.org/netdev/20220906052129.104507-1-saeed@kernel.org/ Emeel Hakim (10): net: macsec: Expose extended packet number (EPN) properties to macsec offload net/mlx5: Fix fields name prefix in MACsec net/mlx5e: Fix MACsec initialization error path net/mlx5e: Fix MACsec initial packet number net/mlx5: Add ifc bits for MACsec extended packet number (EPN) and replay protection net/mlx5e: Expose memory key creation (mkey) function net/mlx5e: Create advanced steering operation (ASO) object for MACsec net/mlx5e: Move MACsec initialization from profile init stage to profile enable stage net/mlx5e: Support MACsec offload extended packet number (EPN) net/mlx5e: Support MACsec offload replay window drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 + .../mellanox/mlx5/core/en_accel/macsec.c | 631 +++++++++++++++++- .../mellanox/mlx5/core/en_accel/macsec.h | 1 - .../ethernet/mellanox/mlx5/core/en_common.c | 3 +- .../net/ethernet/mellanox/mlx5/core/en_main.c | 11 +- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 3 + .../net/ethernet/mellanox/mlx5/core/events.c | 3 + .../net/ethernet/mellanox/mlx5/core/lib/aso.h | 3 + drivers/net/macsec.c | 24 +- include/linux/mlx5/device.h | 8 + include/linux/mlx5/mlx5_ifc.h | 35 +- 11 files changed, 670 insertions(+), 53 deletions(-)