mbox series

[net-next,v2,00/13] net: sunhme: Cleanups and logging improvements

Message ID 20220924015339.1816744-1-seanga2@gmail.com (mailing list archive)
Headers show
Series net: sunhme: Cleanups and logging improvements | expand

Message

Sean Anderson Sept. 24, 2022, 1:53 a.m. UTC
This series is a continuation of [1] with a focus on logging improvements (in
the style of commit b11e5f6a3a5c ("net: sunhme: output link status with a single
print.")). I have included several of Rolf's patches in the series where
appropriate (with slight modifications). After this series is applied, many more
messages from this driver will come with driver/device information.
Additionally, most messages (especially debug messages) have been condensed onto
one line (as KERN_CONT messages get split).

[1] https://lore.kernel.org/netdev/4686583.GXAFRqVoOG@eto.sf-tec.de/

Changes in v2:
- Remove space after pci_enable_device
- Use memset to clear p->happy_meals
- Set err inside error branches
- sumhme -> sunhme
- Remove repeated newline
- Remove another excess debug

Rolf Eike Beer (3):
  sunhme: remove unused tx_dump_ring()
  sunhme: forward the error code from pci_enable_device()
  sunhme: switch to devres

Sean Anderson (10):
  sunhme: Remove version
  sunhme: Return an ERR_PTR from quattro_pci_find
  sunhme: Regularize probe errors
  sunhme: Convert FOO((...)) to FOO(...)
  sunhme: Clean up debug infrastructure
  sunhme: Convert printk(KERN_FOO ...) to pr_foo(...)
  sunhme: Use (net)dev_foo wherever possible
  sunhme: Combine continued messages
  sunhme: Use vdbg for spam-y prints
  sunhme: Add myself as a maintainer

 MAINTAINERS                       |   5 +
 drivers/net/ethernet/sun/sunhme.c | 661 ++++++++++++------------------
 2 files changed, 264 insertions(+), 402 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 27, 2022, 12:50 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 23 Sep 2022 21:53:26 -0400 you wrote:
> This series is a continuation of [1] with a focus on logging improvements (in
> the style of commit b11e5f6a3a5c ("net: sunhme: output link status with a single
> print.")). I have included several of Rolf's patches in the series where
> appropriate (with slight modifications). After this series is applied, many more
> messages from this driver will come with driver/device information.
> Additionally, most messages (especially debug messages) have been condensed onto
> one line (as KERN_CONT messages get split).
> 
> [...]

Here is the summary with links:
  - [net-next,v2,01/13] sunhme: remove unused tx_dump_ring()
    https://git.kernel.org/netdev/net-next/c/8247ab50c2ad
  - [net-next,v2,02/13] sunhme: Remove version
    https://git.kernel.org/netdev/net-next/c/6478c6e99455
  - [net-next,v2,03/13] sunhme: forward the error code from pci_enable_device()
    https://git.kernel.org/netdev/net-next/c/acb3f35f920b
  - [net-next,v2,04/13] sunhme: Return an ERR_PTR from quattro_pci_find
    https://git.kernel.org/netdev/net-next/c/d6f1e89bdbb8
  - [net-next,v2,05/13] sunhme: Regularize probe errors
    https://git.kernel.org/netdev/net-next/c/5b3dc6dda6b1
  - [net-next,v2,06/13] sunhme: switch to devres
    https://git.kernel.org/netdev/net-next/c/914d9b2711dd
  - [net-next,v2,07/13] sunhme: Convert FOO((...)) to FOO(...)
    https://git.kernel.org/netdev/net-next/c/03290907a5d1
  - [net-next,v2,08/13] sunhme: Clean up debug infrastructure
    https://git.kernel.org/netdev/net-next/c/30931367ba80
  - [net-next,v2,09/13] sunhme: Convert printk(KERN_FOO ...) to pr_foo(...)
    https://git.kernel.org/netdev/net-next/c/0bc1f45410ea
  - [net-next,v2,10/13] sunhme: Use (net)dev_foo wherever possible
    https://git.kernel.org/netdev/net-next/c/8acf878f29d0
  - [net-next,v2,11/13] sunhme: Combine continued messages
    https://git.kernel.org/netdev/net-next/c/24cddbc3ef11
  - [net-next,v2,12/13] sunhme: Use vdbg for spam-y prints
    https://git.kernel.org/netdev/net-next/c/26657c70b91c
  - [net-next,v2,13/13] sunhme: Add myself as a maintainer
    https://git.kernel.org/netdev/net-next/c/77ceb3731e12

You are awesome, thank you!