mbox series

[net-next,v2,0/3] nfp: IPsec offload support

Message ID 20220927102707.479199-1-simon.horman@corigine.com (mailing list archive)
Headers show
Series nfp: IPsec offload support | expand

Message

Simon Horman Sept. 27, 2022, 10:27 a.m. UTC
Huanhuan Wang says:

this short series is support IPsec offload for the NFP driver.

It covers three enhancements:

1. Patches 1/3:
   - Extend the capability word and control word to to support
     new features.

2. Patch 2/3:
   - Add framework to support IPsec offloading for NFP driver,
     but IPsec offload control plane interface xfrm callbacks which
     interact with upper layer are not implemented in this patch.

3. Patch 3/3:
   - IPsec control plane interface xfrm callbacks are implemented
     in this patch.

Changes since v1
* Explicitly return failure when XFRM_STATE_ESN is set
* Fix the issue that AEAD algorithm is not correctly offloaded

Huanhuan Wang (2):
  nfp: add framework to support ipsec offloading
  nfp: implement xfrm callbacks and expose ipsec offload feature to
    upper layer

Yinjun Zhang (1):
  nfp: extend capability and control words

 drivers/net/ethernet/netronome/Kconfig        |  11 +
 drivers/net/ethernet/netronome/nfp/Makefile   |   6 +
 .../ethernet/netronome/nfp/crypto/crypto.h    |  35 +
 .../net/ethernet/netronome/nfp/crypto/ipsec.c | 774 ++++++++++++++++++
 drivers/net/ethernet/netronome/nfp/nfd3/dp.c  |  43 +-
 .../net/ethernet/netronome/nfp/nfd3/ipsec.c   |  19 +
 .../net/ethernet/netronome/nfp/nfd3/nfd3.h    |   8 +
 drivers/net/ethernet/netronome/nfp/nfp_net.h  |  11 +
 .../ethernet/netronome/nfp/nfp_net_common.c   |  17 +-
 .../net/ethernet/netronome/nfp/nfp_net_ctrl.h |  22 +-
 10 files changed, 934 insertions(+), 12 deletions(-)
 create mode 100644 drivers/net/ethernet/netronome/nfp/crypto/ipsec.c
 create mode 100644 drivers/net/ethernet/netronome/nfp/nfd3/ipsec.c

Comments

Jakub Kicinski Sept. 29, 2022, 2:42 a.m. UTC | #1
On Tue, 27 Sep 2022 12:27:04 +0200 Simon Horman wrote:
> this short series is support IPsec offload for the NFP driver.
> 
> It covers three enhancements:
> 
> 1. Patches 1/3:
>    - Extend the capability word and control word to to support
>      new features.
> 
> 2. Patch 2/3:
>    - Add framework to support IPsec offloading for NFP driver,
>      but IPsec offload control plane interface xfrm callbacks which
>      interact with upper layer are not implemented in this patch.
> 
> 3. Patch 3/3:
>    - IPsec control plane interface xfrm callbacks are implemented
>      in this patch.

Should this not CC Steffen?
Simon Horman Sept. 29, 2022, 8:48 a.m. UTC | #2
On Wed, Sep 28, 2022 at 07:42:20PM -0700, Jakub Kicinski wrote:
> On Tue, 27 Sep 2022 12:27:04 +0200 Simon Horman wrote:
> > this short series is support IPsec offload for the NFP driver.
> > 
> > It covers three enhancements:
> > 
> > 1. Patches 1/3:
> >    - Extend the capability word and control word to to support
> >      new features.
> > 
> > 2. Patch 2/3:
> >    - Add framework to support IPsec offloading for NFP driver,
> >      but IPsec offload control plane interface xfrm callbacks which
> >      interact with upper layer are not implemented in this patch.
> > 
> > 3. Patch 3/3:
> >    - IPsec control plane interface xfrm callbacks are implemented
> >      in this patch.
> 
> Should this not CC Steffen?

Thanks Jakub,

in light of this and Leon's review, we'll plan to post a v3.