mbox series

[bpf-next,v4,0/6] Fix bugs found by ASAN when running selftests

Message ID 20221011120108.782373-1-xukuohai@huaweicloud.com (mailing list archive)
Headers show
Series Fix bugs found by ASAN when running selftests | expand

Message

Xu Kuohai Oct. 11, 2022, 12:01 p.m. UTC
From: Xu Kuohai <xukuohai@huawei.com>

This series fixes bugs found by ASAN when running bpf selftests on arm64.

v4:
- Address Andrii's suggestions

v3: https://lore.kernel.org/bpf/5311e154-c2d4-91a5-ccb8-f5adede579ed@huawei.com
- Fix error failure of case test_xdp_adjust_tail_grow exposed by this series

v2: https://lore.kernel.org/bpf/20221010070454.577433-1-xukuohai@huaweicloud.com
- Rebase and fix conflict

v1: https://lore.kernel.org/bpf/20221009131830.395569-1-xukuohai@huaweicloud.com

Xu Kuohai (6):
  libbpf: Fix use-after-free in btf_dump_name_dups
  libbpf: Fix memory leak in parse_usdt_arg()
  selftests/bpf: Fix memory leak caused by not destroying skeleton
  selftest/bpf: Fix memory leak in kprobe_multi_test
  selftests/bpf: Fix error failure of case test_xdp_adjust_tail_grow
  selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c

 tools/lib/bpf/btf_dump.c                      | 30 +++++++++++++++++--
 tools/lib/bpf/usdt.c                          | 11 +++----
 .../bpf/prog_tests/kprobe_multi_test.c        | 26 ++++++++--------
 .../selftests/bpf/prog_tests/map_kptr.c       |  3 +-
 .../selftests/bpf/prog_tests/tracing_struct.c |  3 +-
 .../bpf/prog_tests/xdp_adjust_tail.c          |  7 +++--
 6 files changed, 53 insertions(+), 27 deletions(-)

Comments

Martin KaFai Lau Oct. 12, 2022, 11:41 p.m. UTC | #1
On 10/11/22 5:01 AM, Xu Kuohai wrote:
> From: Xu Kuohai <xukuohai@huawei.com>
> 
> This series fixes bugs found by ASAN when running bpf selftests on arm64

Overall lgtm.

Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
patchwork-bot+netdevbpf@kernel.org Oct. 13, 2022, 3:50 p.m. UTC | #2
Hello:

This series was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Tue, 11 Oct 2022 08:01:02 -0400 you wrote:
> From: Xu Kuohai <xukuohai@huawei.com>
> 
> This series fixes bugs found by ASAN when running bpf selftests on arm64.
> 
> v4:
> - Address Andrii's suggestions
> 
> [...]

Here is the summary with links:
  - [bpf-next,v4,1/6] libbpf: Fix use-after-free in btf_dump_name_dups
    https://git.kernel.org/bpf/bpf-next/c/02c1e5b0bbb8
  - [bpf-next,v4,2/6] libbpf: Fix memory leak in parse_usdt_arg()
    https://git.kernel.org/bpf/bpf-next/c/cd168cc6f685
  - [bpf-next,v4,3/6] selftests/bpf: Fix memory leak caused by not destroying skeleton
    https://git.kernel.org/bpf/bpf-next/c/fbca16071678
  - [bpf-next,v4,4/6] selftest/bpf: Fix memory leak in kprobe_multi_test
    https://git.kernel.org/bpf/bpf-next/c/159c69121102
  - [bpf-next,v4,5/6] selftests/bpf: Fix error failure of case test_xdp_adjust_tail_grow
    https://git.kernel.org/bpf/bpf-next/c/496848b47126
  - [bpf-next,v4,6/6] selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c
    https://git.kernel.org/bpf/bpf-next/c/cafecc0e3df3

You are awesome, thank you!