[v2,net,0/2] openvswitch: syzbot splat fix and introduce selftest

Message

Aaron Conole Oct. 25, 2022, 10:50 a.m. UTC

Syzbot recently caught a splat when dropping features from
openvswitch datapaths that are in-use.  The WARN() call is
definitely too large a hammer for the situation, so change
to pr_warn.

Second patch in the series introduces a new selftest suite which
can help show that an issue is fixed.  This change might be
more suited to net-next tree, so it has been separated out
as an additional patch and can be either applied to either tree
based on preference.

Aaron Conole (2):
  openvswitch: switch from WARN to pr_warn
  selftests: add openvswitch selftest suite

 MAINTAINERS                                   |   1 +
 net/openvswitch/datapath.c                    |   3 +-
 tools/testing/selftests/Makefile              |   1 +
 .../selftests/net/openvswitch/Makefile        |  13 +
 .../selftests/net/openvswitch/openvswitch.sh  | 218 +++++++++++
 .../selftests/net/openvswitch/ovs-dpctl.py    | 351 ++++++++++++++++++
 6 files changed, 586 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/net/openvswitch/Makefile
 create mode 100755 tools/testing/selftests/net/openvswitch/openvswitch.sh
 create mode 100644 tools/testing/selftests/net/openvswitch/ovs-dpctl.py

Comments

[e-mail] Oct. 27, 2022, 10:50 a.m. UTC | #1

Hello:

This series was applied to netdev/net.git (master)
by Paolo Abeni <[e-mail]>:

On Tue, 25 Oct 2022 06:50:16 -0400 you wrote:
> Syzbot recently caught a splat when dropping features from
> openvswitch datapaths that are in-use.  The WARN() call is
> definitely too large a hammer for the situation, so change
> to pr_warn.
> 
> Second patch in the series introduces a new selftest suite which
> can help show that an issue is fixed.  This change might be
> more suited to net-next tree, so it has been separated out
> as an additional patch and can be either applied to either tree
> based on preference.
> 
> [...]

Here is the summary with links:
  - [v2,net,1/2] openvswitch: switch from WARN to pr_warn
    https://git.kernel.org/netdev/net/c/fd954cc1919e
  - [v2,net,2/2] selftests: add openvswitch selftest suite
    https://git.kernel.org/netdev/net/c/25f16c873fb1

You are awesome, thank you!