mbox series

[RFC,v2,0/2] can: virtio: virtio-can driver

Message ID 20221104172421.8271-1-Harald.Mommer@opensynergy.com (mailing list archive)
Headers show
Series can: virtio: virtio-can driver | expand

Message

Harald Mommer Nov. 4, 2022, 5:24 p.m. UTC 
Hello,

this is a new virtio-can driver. 

The proposed addition to the virtio specification which should match
this driver has been sent 25-Aug-2022 and can be found here:

https://lore.kernel.org/all/20220825133410.18367-1-harald.mommer@opensynergy.com/

(Got no comments on the updated specification proposal now.)

The RFC driver version has been sent 25-Aug-2022 and can be found here:

https://lore.kernel.org/all/20220825134449.18803-1-harald.mommer@opensynergy.com/

- Small update to be compilable against newest kernel

  - netif_napi_add() prototype change

- Address the review comments got from Arnd Bergmann, Oliver Hartkopp,
  Marc Kleine-Budde:

  - Remove virtio_can_hexdump()
  - Use completion instead of polling
  - Restructure usage of spinlock in virtio_can_start_xmit()
  - Save kicks in virtio_can_start_xmit()
  - Minimize usage of BUG_ON()
  - Make driver less noisy
  - Move register_virtio_candev() down in code
  - Remove unwanted MISRA habits used to in a former life
  - Treat bitmasks as bitmasks
  - Remove excessive usage of netdev_warn() silently sanitizing
  - Fix RTR frame handling with payload != 0
  - Work through checkpatch problems
  - Clarify license
  - Remove some pointless leftover comments

Regards
Harald