mbox series

[0/6] Build output clean up

Message ID 20221117004356.279422-1-irogers@google.com (mailing list archive)
Headers show
Series Build output clean up | expand

Message

Ian Rogers Nov. 17, 2022, 12:43 a.m. UTC
Reduce build spam from commands not prefixed with @. Make
install_headers targets distinguishable by adding in the library name
so:
INSTALL headers
becomes:
INSTALL libapi_headers

Ian Rogers (6):
  tools lib api: clean up install_headers
  tools lib bpf: Avoid install_headers make warning
  tools lib symbol: clean up build output
  tools lib perf: Make install_headers clearer
  tools lib subcmd: Make install_headers clearer
  tools lib traceevent: Make install_headers clearer

 tools/lib/api/Makefile        | 4 ++--
 tools/lib/bpf/Makefile        | 1 +
 tools/lib/perf/Makefile       | 2 +-
 tools/lib/subcmd/Makefile     | 2 +-
 tools/lib/symbol/Makefile     | 4 ++--
 tools/lib/traceevent/Makefile | 4 ++--
 6 files changed, 9 insertions(+), 8 deletions(-)

Comments

Arnaldo Carvalho de Melo Nov. 17, 2022, 3:40 p.m. UTC | #1
Em Wed, Nov 16, 2022 at 04:43:50PM -0800, Ian Rogers escreveu:
> Reduce build spam from commands not prefixed with @. Make
> install_headers targets distinguishable by adding in the library name
> so:
> INSTALL headers
> becomes:
> INSTALL libapi_headers
> 
> Ian Rogers (6):
>   tools lib api: clean up install_headers
>   tools lib bpf: Avoid install_headers make warning
>   tools lib symbol: clean up build output
>   tools lib perf: Make install_headers clearer
>   tools lib subcmd: Make install_headers clearer
>   tools lib traceevent: Make install_headers clearer

Andrii, are you ok with that? Can I carry this on my next (perf/core)
branch?

Testing it now.

- Arnaldo
 
>  tools/lib/api/Makefile        | 4 ++--
>  tools/lib/bpf/Makefile        | 1 +
>  tools/lib/perf/Makefile       | 2 +-
>  tools/lib/subcmd/Makefile     | 2 +-
>  tools/lib/symbol/Makefile     | 4 ++--
>  tools/lib/traceevent/Makefile | 4 ++--
>  6 files changed, 9 insertions(+), 8 deletions(-)
> 
> -- 
> 2.38.1.431.g37b22c650d-goog
Andrii Nakryiko Nov. 17, 2022, 7:32 p.m. UTC | #2
On Thu, Nov 17, 2022 at 7:40 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Wed, Nov 16, 2022 at 04:43:50PM -0800, Ian Rogers escreveu:
> > Reduce build spam from commands not prefixed with @. Make
> > install_headers targets distinguishable by adding in the library name
> > so:
> > INSTALL headers
> > becomes:
> > INSTALL libapi_headers
> >
> > Ian Rogers (6):
> >   tools lib api: clean up install_headers
> >   tools lib bpf: Avoid install_headers make warning
> >   tools lib symbol: clean up build output
> >   tools lib perf: Make install_headers clearer
> >   tools lib subcmd: Make install_headers clearer
> >   tools lib traceevent: Make install_headers clearer
>
> Andrii, are you ok with that? Can I carry this on my next (perf/core)
> branch?

yep, lgtm. Please take it through your tree, in-kernel Makefile is not
even synced into Github, so there is no downsides in terms of libbpf
sync.

Acked-by: Andrii Nakryiko <andrii@kernel.org>

>
> Testing it now.
>
> - Arnaldo
>
> >  tools/lib/api/Makefile        | 4 ++--
> >  tools/lib/bpf/Makefile        | 1 +
> >  tools/lib/perf/Makefile       | 2 +-
> >  tools/lib/subcmd/Makefile     | 2 +-
> >  tools/lib/symbol/Makefile     | 4 ++--
> >  tools/lib/traceevent/Makefile | 4 ++--
> >  6 files changed, 9 insertions(+), 8 deletions(-)
> >
> > --
> > 2.38.1.431.g37b22c650d-goog
>
> --
>
> - Arnaldo
Arnaldo Carvalho de Melo Nov. 17, 2022, 8:12 p.m. UTC | #3
Em Thu, Nov 17, 2022 at 11:32:10AM -0800, Andrii Nakryiko escreveu:
> On Thu, Nov 17, 2022 at 7:40 AM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > Em Wed, Nov 16, 2022 at 04:43:50PM -0800, Ian Rogers escreveu:
> > > Reduce build spam from commands not prefixed with @. Make
> > > install_headers targets distinguishable by adding in the library name
> > > so:
> > > INSTALL headers
> > > becomes:
> > > INSTALL libapi_headers
> > >
> > > Ian Rogers (6):
> > >   tools lib api: clean up install_headers
> > >   tools lib bpf: Avoid install_headers make warning
> > >   tools lib symbol: clean up build output
> > >   tools lib perf: Make install_headers clearer
> > >   tools lib subcmd: Make install_headers clearer
> > >   tools lib traceevent: Make install_headers clearer
> >
> > Andrii, are you ok with that? Can I carry this on my next (perf/core)
> > branch?
> 
> yep, lgtm. Please take it through your tree, in-kernel Makefile is not
> even synced into Github, so there is no downsides in terms of libbpf
> sync.
> 
> Acked-by: Andrii Nakryiko <andrii@kernel.org>

Thanks, done.

- Arnaldo