| Message ID | 20221118221041.1402445-1-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | IEEE 802.15.4 PAN discovery handling | expand |
Hi, On Fri, Nov 18, 2022 at 5:13 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Hello, > > Last preparation step before the introduction of the scanning feature > (really): generic helpers to handle PAN discovery upon beacon > reception. We need to tell user space about the discoveries. > > In all the past, current and future submissions, David and Romuald from > Qorvo are credited in various ways (main author, co-author, > suggested-by) depending of the amount of rework that was involved on > each patch, reflecting as much as possible the open-source guidelines we > follow in the kernel. All this effort is made possible thanks to Qorvo > Inc which is pushing towards a featureful upstream WPAN support. > Acked-by: Alexander Aring <aahringo@redhat.com> I am sorry, I saw this series today. Somehow I mess up my mails if we are still writing something on v1 but v2 is already submitted. I will try to keep up next time. - Alex
Hi Alexander, aahringo@redhat.com wrote on Mon, 28 Nov 2022 17:11:38 -0500: > Hi, > > On Fri, Nov 18, 2022 at 5:13 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > Hello, > > > > Last preparation step before the introduction of the scanning feature > > (really): generic helpers to handle PAN discovery upon beacon > > reception. We need to tell user space about the discoveries. > > > > In all the past, current and future submissions, David and Romuald from > > Qorvo are credited in various ways (main author, co-author, > > suggested-by) depending of the amount of rework that was involved on > > each patch, reflecting as much as possible the open-source guidelines we > > follow in the kernel. All this effort is made possible thanks to Qorvo > > Inc which is pushing towards a featureful upstream WPAN support. > > > > Acked-by: Alexander Aring <aahringo@redhat.com> > > I am sorry, I saw this series today. Somehow I mess up my mails if we > are still writing something on v1 but v2 is already submitted. I will > try to keep up next time. Haha I was asking myself wether or not you saw it, no problem :) I did send it after your main review but we continued discussing on v1 (about the preambles) so I did not ping for the time the discussion would settle. I'll continued with the scan interface which I think is the next step! Thanks, Miquèl
Hello. On 29.11.22 09:03, Miquel Raynal wrote: > Hi Alexander, > > aahringo@redhat.com wrote on Mon, 28 Nov 2022 17:11:38 -0500: > >> Hi, >> >> On Fri, Nov 18, 2022 at 5:13 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote: >>> >>> Hello, >>> >>> Last preparation step before the introduction of the scanning feature >>> (really): generic helpers to handle PAN discovery upon beacon >>> reception. We need to tell user space about the discoveries. >>> >>> In all the past, current and future submissions, David and Romuald from >>> Qorvo are credited in various ways (main author, co-author, >>> suggested-by) depending of the amount of rework that was involved on >>> each patch, reflecting as much as possible the open-source guidelines we >>> follow in the kernel. All this effort is made possible thanks to Qorvo >>> Inc which is pushing towards a featureful upstream WPAN support. >>> >> >> Acked-by: Alexander Aring <aahringo@redhat.com> >> >> I am sorry, I saw this series today. Somehow I mess up my mails if we >> are still writing something on v1 but v2 is already submitted. I will >> try to keep up next time. > > Haha I was asking myself wether or not you saw it, no problem :) I did > send it after your main review but we continued discussing on v1 (about > the preambles) so I did not ping for the time the discussion would > settle. I was trying to apply these two patches, but the first one does not apply: Failed to apply patch: error: patch failed: include/net/nl802154.h:58 error: include/net/nl802154.h: patch does not apply hint: Use 'git am --show-current-patch=diff' to see the failed patch Applying: ieee802154: Advertize coordinators discovery Patch failed at 0001 ieee802154: Advertize coordinators discovery It seems you need a rebase as there is commit 8254393663f9b8cb8b84cdce1abb118833c22a54 which touches this area of the file and removes a comment and ifdef. Should be fine to go in after the rebase. regards Stefan Schmidt
Hi Stefan, stefan@datenfreihafen.org wrote on Tue, 29 Nov 2022 13:41:32 +0100: > Hello. > > On 29.11.22 09:03, Miquel Raynal wrote: > > Hi Alexander, > > > > aahringo@redhat.com wrote on Mon, 28 Nov 2022 17:11:38 -0500: > > > >> Hi, > >> > >> On Fri, Nov 18, 2022 at 5:13 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > >>> > >>> Hello, > >>> > >>> Last preparation step before the introduction of the scanning feature > >>> (really): generic helpers to handle PAN discovery upon beacon > >>> reception. We need to tell user space about the discoveries. > >>> > >>> In all the past, current and future submissions, David and Romuald from > >>> Qorvo are credited in various ways (main author, co-author, > >>> suggested-by) depending of the amount of rework that was involved on > >>> each patch, reflecting as much as possible the open-source guidelines we > >>> follow in the kernel. All this effort is made possible thanks to Qorvo > >>> Inc which is pushing towards a featureful upstream WPAN support. > >>> >> > >> Acked-by: Alexander Aring <aahringo@redhat.com> > >> > >> I am sorry, I saw this series today. Somehow I mess up my mails if we > >> are still writing something on v1 but v2 is already submitted. I will > >> try to keep up next time. > > > > Haha I was asking myself wether or not you saw it, no problem :) I did > > send it after your main review but we continued discussing on v1 (about > > the preambles) so I did not ping for the time the discussion would > > settle. > > I was trying to apply these two patches, but the first one does not apply: > > > Failed to apply patch: > error: patch failed: include/net/nl802154.h:58 > error: include/net/nl802154.h: patch does not apply > hint: Use 'git am --show-current-patch=diff' to see the failed patch > Applying: ieee802154: Advertize coordinators discovery > Patch failed at 0001 ieee802154: Advertize coordinators discovery > > It seems you need a rebase as there is commit 8254393663f9b8cb8b84cdce1abb118833c22a54 which touches this area of the file and removes a comment and ifdef. Should be fine to go in after the rebase. Oh crap, this is gonna conflict with a dozen of my patches /o\. Not hard to solve though. Let me fix this by moving all new commands in this header above the security commands. I'll also have to update the wpan tools to use the same commands. Thanks, Miquèl