mbox series

[0/2] Revert "veth: Avoid drop packets when xdp_redirect performs" and its fix

Message ID 20221122035015.19296-1-hengqi@linux.alibaba.com (mailing list archive)
Headers show
Series Revert "veth: Avoid drop packets when xdp_redirect performs" and its fix | expand

Message

Heng Qi Nov. 22, 2022, 3:50 a.m. UTC
This patch 2e0de6366ac16 enables napi of the peer veth automatically when the
veth loads the xdp, but it breaks down as reported by Paolo and John. So reverting
it and its fix, we will rework the patch and make it more robust based on comments.

Heng Qi (2):
  Revert "bpf: veth driver panics when xdp prog attached before
    veth_open"
  Revert "veth: Avoid drop packets when xdp_redirect performs"

 drivers/net/veth.c | 88 +++++++---------------------------------------
 1 file changed, 12 insertions(+), 76 deletions(-)

Comments

Jakub Kicinski Nov. 22, 2022, 4:35 a.m. UTC | #1
On Tue, 22 Nov 2022 11:50:13 +0800 Heng Qi wrote:
> This patch 2e0de6366ac16 enables napi of the peer veth automatically when the
> veth loads the xdp, but it breaks down as reported by Paolo and John. So reverting
> it and its fix, we will rework the patch and make it more robust based on comments.

Did anything change since the previous posting?
Heng Qi Nov. 22, 2022, 7:57 a.m. UTC | #2
在 2022/11/22 下午12:35, Jakub Kicinski 写道:
> On Tue, 22 Nov 2022 11:50:13 +0800 Heng Qi wrote:
>> This patch 2e0de6366ac16 enables napi of the peer veth automatically when the
>> veth loads the xdp, but it breaks down as reported by Paolo and John. So reverting
>> it and its fix, we will rework the patch and make it more robust based on comments.
> Did anything change since the previous posting?

Do you mean this positing?
https://lore.kernel.org/all/20221121112848.51388-1-hengqi@linux.alibaba.com/

If yes, there is no difference between this posting and the posting 
posted by the link. This posting is to make it easier to merge.
patchwork-bot+netdevbpf@kernel.org Nov. 23, 2022, 4:52 a.m. UTC | #3
Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 22 Nov 2022 11:50:13 +0800 you wrote:
> This patch 2e0de6366ac16 enables napi of the peer veth automatically when the
> veth loads the xdp, but it breaks down as reported by Paolo and John. So reverting
> it and its fix, we will rework the patch and make it more robust based on comments.
> 
> Heng Qi (2):
>   Revert "bpf: veth driver panics when xdp prog attached before
>     veth_open"
>   Revert "veth: Avoid drop packets when xdp_redirect performs"
> 
> [...]

Here is the summary with links:
  - [1/2] Revert "bpf: veth driver panics when xdp prog attached before veth_open"
    https://git.kernel.org/netdev/net-next/c/b535d681adda
  - [2/2] Revert "veth: Avoid drop packets when xdp_redirect performs"
    https://git.kernel.org/netdev/net-next/c/5e8d3dc73e80

You are awesome, thank you!