| Message ID | 20221129070900.3142427-1-martin.lau@linux.dev (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests/bpf: Remove unnecessary mount/umount dance | expand |
On 11/28, Martin KaFai Lau wrote: > From: Martin KaFai Lau <martin.lau@kernel.org> > Some of the tests do mount/umount dance when switching netns. > It is error-prone like > https://lore.kernel.org/bpf/20221123200829.2226254-1-sdf@google.com/ > Another issue is, there are many left over after running some of the > tests: > #> mount | egrep sysfs | wc -l > 19 > Instead of further debugging this dance, this set is to avoid the needs > to > do this remounting altogether. It will then allow those tests to be run > in parallel again. Looks great, thank you for taking care of this! Since I'm partly to blame for the mess, took a quick look at the series: Acked-by: Stanislav Fomichev <sdf@google.com> > Martin KaFai Lau (7): > selftests/bpf: Use if_nametoindex instead of reading the > /sys/net/class/*/ifindex > selftests/bpf: Avoid pinning bpf prog in the tc_redirect_dtime test > selftests/bpf: Avoid pinning bpf prog in the tc_redirect_peer_l3 test > selftests/bpf: Avoid pinning bpf prog in the netns_load_bpf() callers > selftests/bpf: Remove the "/sys" mount and umount dance in > {open,close}_netns > selftests/bpf: Remove serial from tests using {open,close}_netns > selftests/bpf: Avoid pinning prog when attaching to tc ingress in > btf_skc_cls_ingress > tools/testing/selftests/bpf/network_helpers.c | 51 +-- > .../bpf/prog_tests/btf_skc_cls_ingress.c | 25 +- > .../selftests/bpf/prog_tests/empty_skb.c | 2 +- > .../selftests/bpf/prog_tests/tc_redirect.c | 314 +++++++++--------- > .../selftests/bpf/prog_tests/test_tunnel.c | 2 +- > .../bpf/prog_tests/xdp_do_redirect.c | 2 +- > .../selftests/bpf/prog_tests/xdp_synproxy.c | 2 +- > 7 files changed, 178 insertions(+), 220 deletions(-) > -- > 2.30.2
Hello: This series was applied to bpf/bpf-next.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Mon, 28 Nov 2022 23:08:53 -0800 you wrote: > From: Martin KaFai Lau <martin.lau@kernel.org> > > Some of the tests do mount/umount dance when switching netns. > It is error-prone like https://lore.kernel.org/bpf/20221123200829.2226254-1-sdf@google.com/ > > Another issue is, there are many left over after running some of the tests: > #> mount | egrep sysfs | wc -l > 19 > > [...] Here is the summary with links: - [bpf-next,1/7] selftests/bpf: Use if_nametoindex instead of reading the /sys/net/class/*/ifindex https://git.kernel.org/bpf/bpf-next/c/052c82dcdcbb - [bpf-next,2/7] selftests/bpf: Avoid pinning bpf prog in the tc_redirect_dtime test https://git.kernel.org/bpf/bpf-next/c/57d0863f1d28 - [bpf-next,3/7] selftests/bpf: Avoid pinning bpf prog in the tc_redirect_peer_l3 test https://git.kernel.org/bpf/bpf-next/c/f1b73577bb3c - [bpf-next,4/7] selftests/bpf: Avoid pinning bpf prog in the netns_load_bpf() callers https://git.kernel.org/bpf/bpf-next/c/5dc42a7fc286 - [bpf-next,5/7] selftests/bpf: Remove the "/sys" mount and umount dance in {open,close}_netns https://git.kernel.org/bpf/bpf-next/c/3084097c369c - [bpf-next,6/7] selftests/bpf: Remove serial from tests using {open,close}_netns https://git.kernel.org/bpf/bpf-next/c/9b6a77739737 - [bpf-next,7/7] selftests/bpf: Avoid pinning prog when attaching to tc ingress in btf_skc_cls_ingress https://git.kernel.org/bpf/bpf-next/c/443f216448ab You are awesome, thank you!
From: Martin KaFai Lau <martin.lau@kernel.org> Some of the tests do mount/umount dance when switching netns. It is error-prone like https://lore.kernel.org/bpf/20221123200829.2226254-1-sdf@google.com/ Another issue is, there are many left over after running some of the tests: #> mount | egrep sysfs | wc -l 19 Instead of further debugging this dance, this set is to avoid the needs to do this remounting altogether. It will then allow those tests to be run in parallel again. Martin KaFai Lau (7): selftests/bpf: Use if_nametoindex instead of reading the /sys/net/class/*/ifindex selftests/bpf: Avoid pinning bpf prog in the tc_redirect_dtime test selftests/bpf: Avoid pinning bpf prog in the tc_redirect_peer_l3 test selftests/bpf: Avoid pinning bpf prog in the netns_load_bpf() callers selftests/bpf: Remove the "/sys" mount and umount dance in {open,close}_netns selftests/bpf: Remove serial from tests using {open,close}_netns selftests/bpf: Avoid pinning prog when attaching to tc ingress in btf_skc_cls_ingress tools/testing/selftests/bpf/network_helpers.c | 51 +-- .../bpf/prog_tests/btf_skc_cls_ingress.c | 25 +- .../selftests/bpf/prog_tests/empty_skb.c | 2 +- .../selftests/bpf/prog_tests/tc_redirect.c | 314 +++++++++--------- .../selftests/bpf/prog_tests/test_tunnel.c | 2 +- .../bpf/prog_tests/xdp_do_redirect.c | 2 +- .../selftests/bpf/prog_tests/xdp_synproxy.c | 2 +- 7 files changed, 178 insertions(+), 220 deletions(-)