[v5,net-next,0/8]

Message

Sebastian Andrzej Siewior Nov. 29, 2022, 4:48 p.m. UTC

I started playing with HSR and run into a problem. Tested latest
upstream -rc and noticed more problems. Now it appears to work.
For testing I have a small three node setup with iperf and ping. While
iperf doesn't complain ping reports missing packets and duplicates.

v4…v5:
- Added __rcu annotation ub patch #7
- Spelling fixes in #2 and #6.

v3…v4:
- Targeting net-next now.
- Added patch #7 back to basket. Kurt's review comments are addressed.
- Added a basic test for HSRv0.

v2…v3:
- dropped patch #7 was an optimisation.

v1…v2:
- Replaced cmpxchg() from patch #6 with lock because RiscV does not provide
  cmpxchg() for 16bit.
- Added patch #3 which fixes the random crashes I observed on latest rc5 while
  testing.

Sebastian

Comments

[e-mail] Dec. 2, 2022, 4:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[e-mail]>:

On Tue, 29 Nov 2022 17:48:07 +0100 you wrote:
> I started playing with HSR and run into a problem. Tested latest
> upstream -rc and noticed more problems. Now it appears to work.
> For testing I have a small three node setup with iperf and ping. While
> iperf doesn't complain ping reports missing packets and duplicates.
> 
> v4…v5:
> - Added __rcu annotation ub patch #7
> - Spelling fixes in #2 and #6.
> 
> [...]

Here is the summary with links:
  - [v5,net-next,1/8] Revert "net: hsr: use hlist_head instead of list_head for mac addresses"
    (no matching commit)
  - [v5,net-next,2/8] hsr: Add a rcu-read lock to hsr_forward_skb().
    https://git.kernel.org/netdev/net-next/c/5aa2820177af
  - [v5,net-next,3/8] hsr: Avoid double remove of a node.
    https://git.kernel.org/netdev/net-next/c/0c74d9f79ec4
  - [v5,net-next,4/8] hsr: Disable netpoll.
    https://git.kernel.org/netdev/net-next/c/d5c7652eb16f
  - [v5,net-next,5/8] hsr: Synchronize sending frames to have always incremented outgoing seq nr.
    https://git.kernel.org/netdev/net-next/c/06afd2c31d33
  - [v5,net-next,6/8] hsr: Synchronize sequence number updates.
    https://git.kernel.org/netdev/net-next/c/5c7aa13210c3
  - [v5,net-next,7/8] hsr: Use a single struct for self_node.
    https://git.kernel.org/netdev/net-next/c/20d3c1e9b861
  - [v5,net-next,8/8] selftests: Add a basic HSR test.
    https://git.kernel.org/netdev/net-next/c/7d0455e97072

You are awesome, thank you!