| Message ID | 20221206185119.380138-1-shayd@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | devlink: Add port function attribute to enable/disable Roce and migratable | expand |
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 6 Dec 2022 20:51:11 +0200 you wrote: > This series is a complete rewrite of the series "devlink: Add port > function attribute to enable/disable roce" > link: > https://lore.kernel.org/netdev/20221102163954.279266-1-danielj@nvidia.com/ > > Currently mlx5 PCI VF and SF are enabled by default for RoCE > functionality. And mlx5 PCI VF is disable by dafault for migratable > functionality. > > [...] Here is the summary with links: - [net-next,V4,1/8] net/mlx5: Introduce IFC bits for migratable https://git.kernel.org/netdev/net-next/c/df268f6ca7da - [net-next,V4,2/8] devlink: Validate port function request https://git.kernel.org/netdev/net-next/c/c0bea69d1ca7 - [net-next,V4,3/8] devlink: Move devlink port function hw_addr attr documentation https://git.kernel.org/netdev/net-next/c/875cd5eeba96 - [net-next,V4,4/8] devlink: Expose port function commands to control RoCE https://git.kernel.org/netdev/net-next/c/da65e9ff3bf6 - [net-next,V4,5/8] net/mlx5: Add generic getters for other functions caps https://git.kernel.org/netdev/net-next/c/47d0c500d76c - [net-next,V4,6/8] net/mlx5: E-Switch, Implement devlink port function cmds to control RoCE https://git.kernel.org/netdev/net-next/c/7db98396ef45 - [net-next,V4,7/8] devlink: Expose port function commands to control migratable https://git.kernel.org/netdev/net-next/c/a8ce7b26a51e - [net-next,V4,8/8] net/mlx5: E-Switch, Implement devlink port function cmds to control migratable https://git.kernel.org/netdev/net-next/c/e5b9642a33be You are awesome, thank you!
This series is a complete rewrite of the series "devlink: Add port function attribute to enable/disable roce" link: https://lore.kernel.org/netdev/20221102163954.279266-1-danielj@nvidia.com/ Currently mlx5 PCI VF and SF are enabled by default for RoCE functionality. And mlx5 PCI VF is disable by dafault for migratable functionality. Currently a user does not have the ability to disable RoCE for a PCI VF/SF device before such device is enumerated by the driver. User is also incapable to do such setting from smartnic scenario for a VF from the smartnic. Current 'enable_roce' device knob is limited to do setting only at driverinit time. By this time device is already created and firmware has already allocated necessary system memory for supporting RoCE. Also, Currently a user does not have the ability to enable migratable for a PCI VF. The above are a hyper visor level control, to set the functionality of devices passed through to guests. This is achieved by extending existing 'port function' object to control capabilities of a function. This enables users to control capability of the device before enumeration. Examples when user prefers to disable RoCE for a VF when using switchdev mode: $ devlink port show pci/0000:06:00.0/1 pci/0000:06:00.0/1: type eth netdev pf0vf0 flavour pcivf controller 0 pfnum 0 vfnum 0 external false splittable false function: hw_addr 00:00:00:00:00:00 roce enable $ devlink port function set pci/0000:06:00.0/1 roce disable $ devlink port show pci/0000:06:00.0/1 pci/0000:06:00.0/1: type eth netdev pf0vf0 flavour pcivf controller 0 pfnum 0 vfnum 0 external false splittable false function: hw_addr 00:00:00:00:00:00 roce disable FAQs: ----- 1. What does roce enable/disable do? Ans: It disables RoCE capability of the function before its enumerated, so when driver reads the capability from the device firmware, it is disabled. At this point RDMA stack will not be able to create UD, QP1, RC, XRC type of QPs. When RoCE is disabled, the GID table of all ports of the device is disabled in the device and software stack. 2. How is the roce 'port function' option different from existing devlink param? Ans: RoCE attribute at the port function level disables the RoCE capability at the specific function level; while enable_roce only does at the software level. 3. Why is this option for disabling only RoCE and not the whole RDMA device? Ans: Because user still wants to use the RDMA device for non RoCE commands in more memory efficient way. Patch summary: Patch-1 introduce ifc bits for migratable command Patch-2 avoid partial port function request processing Patch-3 move devlink hw_addr attribute doc to devlink file Patch-4 adds devlink attribute to control roce Patch-5 add generic setters/getters for other functions caps Patch-6 implements mlx5 callbacks for roce control Patch-7 adds devlink attribute to control migratable Patch-8 implements mlx5 callbacks for migratable control --- v3->v4: - see patches 4,6-8 for a changelog. v2->v3: - see patches 2,4,7 for a changelog. v1->v2: - see patch 7 for a changelog. Shay Drory (6): devlink: Validate port function request devlink: Move devlink port function hw_addr attr documentation devlink: Expose port function commands to control RoCE net/mlx5: Add generic getters for other functions caps devlink: Expose port function commands to control migratable net/mlx5: E-Switch, Implement devlink port function cmds to control migratable Yishai Hadas (2): net/mlx5: Introduce IFC bits for migratable net/mlx5: E-Switch, Implement devlink port function cmds to control RoCE .../device_drivers/ethernet/mellanox/mlx5.rst | 46 ++-- .../networking/devlink/devlink-port.rst | 122 +++++++++- .../net/ethernet/mellanox/mlx5/core/devlink.c | 4 + .../net/ethernet/mellanox/mlx5/core/eswitch.c | 43 ++++ .../net/ethernet/mellanox/mlx5/core/eswitch.h | 11 +- .../mellanox/mlx5/core/eswitch_offloads.c | 211 +++++++++++++++++- .../ethernet/mellanox/mlx5/core/mlx5_core.h | 5 +- .../net/ethernet/mellanox/mlx5/core/pci_irq.c | 3 +- .../net/ethernet/mellanox/mlx5/core/vport.c | 30 ++- include/linux/mlx5/mlx5_ifc.h | 6 +- include/linux/mlx5/vport.h | 2 + include/net/devlink.h | 39 ++++ include/uapi/linux/devlink.h | 13 ++ net/core/devlink.c | 200 ++++++++++++++++- 14 files changed, 686 insertions(+), 49 deletions(-)