mbox series

[net,v2,0/4] net: don't call dev_kfree_skb() under spin_lock_irqsave()

Message ID 20221207135258.34193-1-yangyingliang@huawei.com (mailing list archive)
Headers show
Series net: don't call dev_kfree_skb() under spin_lock_irqsave() | expand

Message

Yang Yingliang Dec. 7, 2022, 1:52 p.m. UTC
It is not allowed to call consume_skb() from hardware interrupt context
or with interrupts being disabled. This patchset replace dev_kfree_skb()
with dev_consume_skb_irq() under spin_lock_irqsave() in some drivers, or
move dev_kfree_skb() after spin_unlock_irqrestore().

v1 -> v2:
  patch #2 Move dev_kfree_skb() after spin_unlock_irqrestore()

Yang Yingliang (4):
  net: emaclite: don't call dev_kfree_skb() under spin_lock_irqsave()
  net: ethernet: dnet: don't call dev_kfree_skb() under
    spin_lock_irqsave()
  hamradio: don't call dev_kfree_skb() under spin_lock_irqsave()
  net: amd: lance: don't call dev_kfree_skb() under spin_lock_irqsave()

 drivers/net/ethernet/amd/atarilance.c         | 2 +-
 drivers/net/ethernet/amd/lance.c              | 2 +-
 drivers/net/ethernet/dnet.c                   | 4 ++--
 drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +-
 drivers/net/hamradio/scc.c                    | 6 +++---
 5 files changed, 8 insertions(+), 8 deletions(-)

Comments

Jakub Kicinski Dec. 8, 2022, 2:50 a.m. UTC | #1
On Wed, 7 Dec 2022 21:52:54 +0800 Yang Yingliang wrote:
> It is not allowed to call consume_skb() from hardware interrupt context
> or with interrupts being disabled. This patchset replace dev_kfree_skb()
> with dev_consume_skb_irq() under spin_lock_irqsave() in some drivers, or
> move dev_kfree_skb() after spin_unlock_irqrestore().

You must CC all authors / reviewers of commits under Fixes:
Run get_maintainer on the _patch file_ not on the path.