mbox series

[net,v3,0/2] l2tp: fix race conditions in l2tp_tunnel_register()

Message ID 20230114030137.672706-1-xiyou.wangcong@gmail.com (mailing list archive)
Headers show
Series l2tp: fix race conditions in l2tp_tunnel_register() | expand

Message

Cong Wang Jan. 14, 2023, 3:01 a.m. UTC
From: Cong Wang <cong.wang@bytedance.com>

This patchset contains two patches, the first one is a preparation for
the second one which is the actual fix. Please find more details in
each patch description.

I have ran the l2tp test (https://github.com/katalix/l2tp-ktest),
all test cases are passed.

---
v3: preserve EEXIST errno for user-space
v2: move IDR allocation to l2tp_tunnel_register()

Cong Wang (2):
  l2tp: convert l2tp_tunnel_list to idr
  l2tp: close all race conditions in l2tp_tunnel_register()

 net/l2tp/l2tp_core.c | 105 +++++++++++++++++++++----------------------
 1 file changed, 52 insertions(+), 53 deletions(-)

Comments

Tom Parkin Jan. 16, 2023, 11:38 a.m. UTC | #1
On  Fri, Jan 13, 2023 at 19:01:35 -0800, Cong Wang wrote:
> From: Cong Wang <cong.wang@bytedance.com>
> 
> This patchset contains two patches, the first one is a preparation for
> the second one which is the actual fix. Please find more details in
> each patch description.
> 
> I have ran the l2tp test (https://github.com/katalix/l2tp-ktest),
> all test cases are passed.
> 
> ---
> v3: preserve EEXIST errno for user-space
> v2: move IDR allocation to l2tp_tunnel_register()
> 
> Cong Wang (2):
>   l2tp: convert l2tp_tunnel_list to idr
>   l2tp: close all race conditions in l2tp_tunnel_register()
> 
>  net/l2tp/l2tp_core.c | 105 +++++++++++++++++++++----------------------
>  1 file changed, 52 insertions(+), 53 deletions(-)
> 
> -- 
> 2.34.1
> 

Thanks Cong, this looks good to me now.

Reviewed-by: Tom Parkin <tparkin@katalix.com>
patchwork-bot+netdevbpf@kernel.org Jan. 16, 2023, 1:50 p.m. UTC | #2
Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 13 Jan 2023 19:01:35 -0800 you wrote:
> From: Cong Wang <cong.wang@bytedance.com>
> 
> This patchset contains two patches, the first one is a preparation for
> the second one which is the actual fix. Please find more details in
> each patch description.
> 
> I have ran the l2tp test (https://github.com/katalix/l2tp-ktest),
> all test cases are passed.
> 
> [...]

Here is the summary with links:
  - [net,v3,1/2] l2tp: convert l2tp_tunnel_list to idr
    https://git.kernel.org/netdev/net/c/c4d48a58f32c
  - [net,v3,2/2] l2tp: close all race conditions in l2tp_tunnel_register()
    https://git.kernel.org/netdev/net/c/0b2c59720e65

You are awesome, thank you!