[net-next,v5,0/9] tsnep: XDP support

Message

Gerhard Engleder Jan. 16, 2023, 8:24 p.m. UTC

Implement XDP support for tsnep driver. I tried to follow existing
drivers like igb/igc as far as possible. Some prework was already done
in previous patch series, so in this series only actual XDP stuff is
included.

Thanks for the NetDev 0x14 slides "Add XDP support on a NIC driver".

Some commits contain changes not related to XDP but found during review
of XDP support patches.

v5:
- fix spelling of 'subtract' in commit message (Alexander Duyck)
- call txq_trans_cond_update() only if TX is complete (Alexander Duyck)
- remove const from static functions (Alexander Duyck)
- replace TX spin_lock with __netif_tx_lock (Alexander Duyck)
- use xdp_return_frame_rx_napi() instead of xdp_return_frame_bulk() (Alexander Duyck)
- eliminate __TSNEP_DOWN (Alexander Duyck)
- introduce single function for xdp_rxq and napi init (Alexander Duyck)
- use TX queue of pair instead of expensive processor id modulo for XDP_TX (Alexander Duyck)
- eliminate processor id modulo in tsnep_netdev_xdp_xmit (Alexander Duyck)
- use bitmap for TX type and add fragment type (Alexander Duyck)
- always use XDP_PACKET_HEADROOM and DMA_BIDIRECTIONAL

v4:
- remove process context from spin_lock_bh commit message (Alexander Lobakin)
- move tsnep_adapter::state to prevent 4 byte hole (Alexander Lobakin)
- braces for bitops in combination logical ops (Alexander Lobakin)
- make various pointers const (Alexander Lobakin)
- '!i' instead of 'i == 0' (Alexander Lobakin)
- removed redundant braces (Alexander Lobakin)
- squash variables into same line if same type (Alexander Lobakin)
- use fact that ::skb and ::xdpf use same slot for simplification (Alexander Lobakin)
- use u32 for smp_processor_id() (Alexander Lobakin)
- don't add $(tsnep-y) to $(tsnep-objs) (Alexander Lobakin)
- use rev xmas tree in tsnep_netdev_open() (Alexander Lobakin)
- do not move tsnep_queue::napi (Alexander Lobakin)
- call xdp_init_buff() only once (Alexander Lobakin)
- get nq and tx only once for XDP TX (Alexander Lobakin)
- move XDP BPF program setup to end of patch series (Alexander Lobakin)
- check for XDP state change and prevent redundant down-ups (Alexander Lobakin)
- access tsnep_adapter::xdp_prog only with READ_ONCE in RX path (Alexander Lobakin)
- forward NAPI budget to napi_consume_skb() (Alexander Lobakin)
- fix errno leftover in tsnep_xdp_xmit_back() (Dan Carpenter)
- eliminate tsnep_xdp_is_enabled() by setting RX offset during init

v3:
- use spin_lock_bh for TX (Paolo Abeni)
- add comment for XDP TX descriptor available check (Maciej Fijalkowski)
- return value bool for tsnep_xdp_xmit_frame_ring() (Saeed Mahameed)
- do not print DMA mapping error (Saeed Mahameed)
- use reverse xmas tree variable declaration (Saeed Mahameed)
- move struct xdp_rxq_info to end of struct tsnep_rx (Maciej Fijalkowski)
- check __TSNEP_DOWN flag on close to prevent double free (Saeed Mahameed)
- describe TSNEP_RX_INLINE_METADATA_SIZE in comment (Maciej Fijalkowski)
- substract TSNEP_RX_INLINE_METADATA_SIZE after DMA sync (Maciej Fijalkowski)
- use enum tsnep_tx_type for tsnep_xdp_tx_map (Saeed Mahameed)
- use nxmit as loop iterator in tsnep_netdev_xdp_xmit (Saeed Mahameed)
- stop netdev in tsnep_netdev_close() which is called during BPF prog setup

v2:
- move tsnep_xdp_xmit_back() to commit where it is used (Paolo Abeni)
- remove inline from tsnep_rx_offset() (Paolo Abeni)
- remove inline from tsnep_rx_offset_xdp() (Paolo Abeni)
- simplify tsnep_xdp_run_prog() call by moving xdp_status update to it (Paolo Abeni)

Gerhard Engleder (9):
  tsnep: Replace TX spin_lock with __netif_tx_lock
  tsnep: Forward NAPI budget to napi_consume_skb()
  tsnep: Do not print DMA mapping error
  tsnep: Add XDP TX support
  tsnep: Subtract TSNEP_RX_INLINE_METADATA_SIZE once
  tsnep: Prepare RX buffer for XDP support
  tsnep: Add RX queue info for XDP support
  tsnep: Add XDP RX support
  tsnep: Support XDP BPF program setup

 drivers/net/ethernet/engleder/Makefile     |   2 +-
 drivers/net/ethernet/engleder/tsnep.h      |  16 +-
 drivers/net/ethernet/engleder/tsnep_main.c | 474 ++++++++++++++++++---
 drivers/net/ethernet/engleder/tsnep_xdp.c  |  19 +
 4 files changed, 445 insertions(+), 66 deletions(-)
 create mode 100644 drivers/net/ethernet/engleder/tsnep_xdp.c

Comments

[e-mail] Jan. 18, 2023, 1:20 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Mon, 16 Jan 2023 21:24:49 +0100 you wrote:
> Implement XDP support for tsnep driver. I tried to follow existing
> drivers like igb/igc as far as possible. Some prework was already done
> in previous patch series, so in this series only actual XDP stuff is
> included.
> 
> Thanks for the NetDev 0x14 slides "Add XDP support on a NIC driver".
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/9] tsnep: Replace TX spin_lock with __netif_tx_lock
    https://git.kernel.org/netdev/net-next/c/25faa6a4c5ca
  - [net-next,v5,2/9] tsnep: Forward NAPI budget to napi_consume_skb()
    https://git.kernel.org/netdev/net-next/c/0625dff38b17
  - [net-next,v5,3/9] tsnep: Do not print DMA mapping error
    https://git.kernel.org/netdev/net-next/c/95337b938476
  - [net-next,v5,4/9] tsnep: Add XDP TX support
    https://git.kernel.org/netdev/net-next/c/d24bc0bcbbff
  - [net-next,v5,5/9] tsnep: Subtract TSNEP_RX_INLINE_METADATA_SIZE once
    https://git.kernel.org/netdev/net-next/c/59d562aa1983
  - [net-next,v5,6/9] tsnep: Prepare RX buffer for XDP support
    https://git.kernel.org/netdev/net-next/c/cc3e254f9443
  - [net-next,v5,7/9] tsnep: Add RX queue info for XDP support
    https://git.kernel.org/netdev/net-next/c/e77832abd90a
  - [net-next,v5,8/9] tsnep: Add XDP RX support
    https://git.kernel.org/netdev/net-next/c/65b28c810035
  - [net-next,v5,9/9] tsnep: Support XDP BPF program setup
    https://git.kernel.org/netdev/net-next/c/f0f6460f9130

You are awesome, thank you!