Message ID | 20230119221536.3349901-1-sdf@google.com (mailing list archive) |
---|---|
Headers | show |
Series | xdp: hints via kfuncs | expand |
Hello: This series was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <martin.lau@kernel.org>: On Thu, 19 Jan 2023 14:15:19 -0800 you wrote: > Please see the first patch in the series for the overall > design and use-cases. > > See the following email from Toke for the per-packet metadata overhead: > https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 > > Recent changes: > - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq) > > [...] Here is the summary with links: - [bpf-next,v8,01/17] bpf: Document XDP RX metadata (no matching commit) - [bpf-next,v8,02/17] bpf: Rename bpf_{prog,map}_is_dev_bound to is_offloaded (no matching commit) - [bpf-next,v8,03/17] bpf: Move offload initialization into late_initcall (no matching commit) - [bpf-next,v8,04/17] bpf: Reshuffle some parts of bpf/offload.c (no matching commit) - [bpf-next,v8,05/17] bpf: Introduce device-bound XDP programs (no matching commit) - [bpf-next,v8,06/17] selftests/bpf: Update expected test_offload.py messages (no matching commit) - [bpf-next,v8,07/17] bpf: XDP metadata RX kfuncs (no matching commit) - [bpf-next,v8,08/17] bpf: Support consuming XDP HW metadata from fext programs (no matching commit) - [bpf-next,v8,09/17] veth: Introduce veth_xdp_buff wrapper for xdp_buff (no matching commit) - [bpf-next,v8,10/17] veth: Support RX XDP metadata (no matching commit) - [bpf-next,v8,11/17] selftests/bpf: Verify xdp_metadata xdp->af_xdp path (no matching commit) - [bpf-next,v8,12/17] net/mlx4_en: Introduce wrapper for xdp_buff (no matching commit) - [bpf-next,v8,13/17] net/mlx4_en: Support RX XDP metadata (no matching commit) - [bpf-next,v8,14/17] xsk: Add cb area to struct xdp_buff_xsk (no matching commit) - [bpf-next,v8,15/17] net/mlx5e: Introduce wrapper for xdp_buff https://git.kernel.org/bpf/bpf-next/c/384a13ca8a5d - [bpf-next,v8,16/17] net/mlx5e: Support RX XDP metadata https://git.kernel.org/bpf/bpf-next/c/bc8d405b1ba9 - [bpf-next,v8,17/17] selftests/bpf: Simple program to dump XDP RX metadata (no matching commit) You are awesome, thank you!
On 1/19/23 2:15 PM, Stanislav Fomichev wrote: > Please see the first patch in the series for the overall > design and use-cases. > > See the following email from Toke for the per-packet metadata overhead: > https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 > > Recent changes: > - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq) > > - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) > > - Clarify xdp_buff vs 'XDP frame' (Jesper) > > - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper) > > - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead > of ifname (due to recent xsk.h refactoring) Applied with the minor changes in the selftests discussed in patch 11 and 17. Thanks!
On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau <martin.lau@linux.dev> wrote: > > On 1/19/23 2:15 PM, Stanislav Fomichev wrote: > > Please see the first patch in the series for the overall > > design and use-cases. > > > > See the following email from Toke for the per-packet metadata overhead: > > https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 > > > > Recent changes: > > - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq) > > > > - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) > > > > - Clarify xdp_buff vs 'XDP frame' (Jesper) > > > > - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper) > > > > - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead > > of ifname (due to recent xsk.h refactoring) > > Applied with the minor changes in the selftests discussed in patch 11 and 17. > Thanks! Awesome, thanks! I was gonna resend around Wed, but thank you for taking care of that!
From: Stanislav Fomichev <sdf@google.com> Date: Mon, 23 Jan 2023 10:55:52 -0800 > On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau <martin.lau@linux.dev> wrote: >> >> On 1/19/23 2:15 PM, Stanislav Fomichev wrote: >>> Please see the first patch in the series for the overall >>> design and use-cases. >>> >>> See the following email from Toke for the per-packet metadata overhead: >>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 >>> >>> Recent changes: >>> - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq) >>> >>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) >>> >>> - Clarify xdp_buff vs 'XDP frame' (Jesper) >>> >>> - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper) >>> >>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead >>> of ifname (due to recent xsk.h refactoring) >> >> Applied with the minor changes in the selftests discussed in patch 11 and 17. >> Thanks! > > Awesome, thanks! I was gonna resend around Wed, but thank you for > taking care of that! Great stuff, congrats! :) Olek
Alexander Lobakin <alexandr.lobakin@intel.com> writes: > From: Stanislav Fomichev <sdf@google.com> > Date: Mon, 23 Jan 2023 10:55:52 -0800 > >> On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau <martin.lau@linux.dev> wrote: >>> >>> On 1/19/23 2:15 PM, Stanislav Fomichev wrote: >>>> Please see the first patch in the series for the overall >>>> design and use-cases. >>>> >>>> See the following email from Toke for the per-packet metadata overhead: >>>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 >>>> >>>> Recent changes: >>>> - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq) >>>> >>>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) >>>> >>>> - Clarify xdp_buff vs 'XDP frame' (Jesper) >>>> >>>> - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper) >>>> >>>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead >>>> of ifname (due to recent xsk.h refactoring) >>> >>> Applied with the minor changes in the selftests discussed in patch 11 and 17. >>> Thanks! >> >> Awesome, thanks! I was gonna resend around Wed, but thank you for >> taking care of that! > Great stuff, congrats! :) Yeah! Thanks for carrying this forward, Stanislav! :) -Toke
On 24/01/2023 12.49, Toke Høiland-Jørgensen wrote: > Alexander Lobakin <alexandr.lobakin@intel.com> writes: > >> From: Stanislav Fomichev <sdf@google.com> >> Date: Mon, 23 Jan 2023 10:55:52 -0800 >> >>> On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau <martin.lau@linux.dev> wrote: >>>> >>>> On 1/19/23 2:15 PM, Stanislav Fomichev wrote: >>>>> Please see the first patch in the series for the overall >>>>> design and use-cases. >>>>> >>>>> See the following email from Toke for the per-packet metadata overhead: >>>>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 >>>>> >>>>> Recent changes: >>>>> - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq) >>>>> >>>>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) >>>>> >>>>> - Clarify xdp_buff vs 'XDP frame' (Jesper) >>>>> >>>>> - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper) >>>>> >>>>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead >>>>> of ifname (due to recent xsk.h refactoring) >>>> >>>> Applied with the minor changes in the selftests discussed in patch 11 and 17. >>>> Thanks! >>> >>> Awesome, thanks! I was gonna resend around Wed, but thank you for >>> taking care of that! >> Great stuff, congrats! :) > > Yeah! Thanks for carrying this forward, Stanislav! :) +1000 -- great work everybody! :-) To Alexander (Cc Jesse and Tony), do you think someone from Intel could look at extending drivers: drivers/net/ethernet/intel/igb/ - chip i210 drivers/net/ethernet/intel/igc/ - chip i225 drivers/net/ethernet/stmicro/stmmac - for CPU integrated LAN ports We have a customer that have been eager to get hardware RX-timestamping for their AF_XDP use-case (PoC code[1] use software timestamping via bpf_ktime_get_ns() today). Getting driver support will qualify this hardware as part of their HW solution. --Jesper [1] https://github.com/xdp-project/bpf-examples/blob/master/AF_XDP-interaction/af_xdp_kern.c#L77
On Tue, Jan 24, 2023 at 4:23 AM Jesper Dangaard Brouer <jbrouer@redhat.com> wrote: > > > On 24/01/2023 12.49, Toke Høiland-Jørgensen wrote: > > Alexander Lobakin <alexandr.lobakin@intel.com> writes: > > > >> From: Stanislav Fomichev <sdf@google.com> > >> Date: Mon, 23 Jan 2023 10:55:52 -0800 > >> > >>> On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau <martin.lau@linux.dev> wrote: > >>>> > >>>> On 1/19/23 2:15 PM, Stanislav Fomichev wrote: > >>>>> Please see the first patch in the series for the overall > >>>>> design and use-cases. > >>>>> > >>>>> See the following email from Toke for the per-packet metadata overhead: > >>>>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 > >>>>> > >>>>> Recent changes: > >>>>> - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq) > >>>>> > >>>>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) > >>>>> > >>>>> - Clarify xdp_buff vs 'XDP frame' (Jesper) > >>>>> > >>>>> - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper) > >>>>> > >>>>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead > >>>>> of ifname (due to recent xsk.h refactoring) > >>>> > >>>> Applied with the minor changes in the selftests discussed in patch 11 and 17. > >>>> Thanks! > >>> > >>> Awesome, thanks! I was gonna resend around Wed, but thank you for > >>> taking care of that! > >> Great stuff, congrats! :) > > > > Yeah! Thanks for carrying this forward, Stanislav! :) Thank you all as well for the valuable feedback and reviews! > +1000 -- great work everybody! :-) > > To Alexander (Cc Jesse and Tony), do you think someone from Intel could > look at extending drivers: > > drivers/net/ethernet/intel/igb/ - chip i210 > drivers/net/ethernet/intel/igc/ - chip i225 > drivers/net/ethernet/stmicro/stmmac - for CPU integrated LAN ports > > We have a customer that have been eager to get hardware RX-timestamping > for their AF_XDP use-case (PoC code[1] use software timestamping via > bpf_ktime_get_ns() today). Getting driver support will qualify this > hardware as part of their HW solution. > > --Jesper > [1] > https://github.com/xdp-project/bpf-examples/blob/master/AF_XDP-interaction/af_xdp_kern.c#L77 >
From: Jesper Dangaard Brouer <jbrouer@redhat.com> Date: Tue, 24 Jan 2023 13:23:49 +0100 > > On 24/01/2023 12.49, Toke Høiland-Jørgensen wrote: >> Alexander Lobakin <alexandr.lobakin@intel.com> writes: >> >>> From: Stanislav Fomichev <sdf@google.com> >>> Date: Mon, 23 Jan 2023 10:55:52 -0800 >>> >>>> On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau >>>> <martin.lau@linux.dev> wrote: >>>>> >>>>> On 1/19/23 2:15 PM, Stanislav Fomichev wrote: >>>>>> Please see the first patch in the series for the overall >>>>>> design and use-cases. >>>>>> >>>>>> See the following email from Toke for the per-packet metadata >>>>>> overhead: >>>>>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 >>>>>> >>>>>> Recent changes: >>>>>> - Keep new functions in en/xdp.c, do 'extern >>>>>> mlx5_xdp_metadata_ops' (Tariq) >>>>>> >>>>>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) >>>>>> >>>>>> - Clarify xdp_buff vs 'XDP frame' (Jesper) >>>>>> >>>>>> - Explicitly mention that AF_XDP RX descriptor lacks metadata size >>>>>> (Jesper) >>>>>> >>>>>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead >>>>>> of ifname (due to recent xsk.h refactoring) >>>>> >>>>> Applied with the minor changes in the selftests discussed in patch >>>>> 11 and 17. >>>>> Thanks! >>>> >>>> Awesome, thanks! I was gonna resend around Wed, but thank you for >>>> taking care of that! >>> Great stuff, congrats! :) >> >> Yeah! Thanks for carrying this forward, Stanislav! :) > > +1000 -- great work everybody! :-) > > To Alexander (Cc Jesse and Tony), do you think someone from Intel could > look at extending drivers: > > drivers/net/ethernet/intel/igb/ - chip i210 > drivers/net/ethernet/intel/igc/ - chip i225 > drivers/net/ethernet/stmicro/stmmac - for CPU integrated LAN ports Sorry, just noticed :s I work with ice only, but seems like the responsible teams started some work already. At least for i225. They may write some follow-ups soon. > > We have a customer that have been eager to get hardware RX-timestamping > for their AF_XDP use-case (PoC code[1] use software timestamping via > bpf_ktime_get_ns() today). Getting driver support will qualify this > hardware as part of their HW solution. > > --Jesper > [1] > https://github.com/xdp-project/bpf-examples/blob/master/AF_XDP-interaction/af_xdp_kern.c#L77 > Thanks, Olek
> >From: Jesper Dangaard Brouer <jbrouer@redhat.com> >Date: Tue, 24 Jan 2023 13:23:49 +0100 > >> >> On 24/01/2023 12.49, Toke Høiland-Jørgensen wrote: >>> Alexander Lobakin <alexandr.lobakin@intel.com> writes: >>> >>>> From: Stanislav Fomichev <sdf@google.com> >>>> Date: Mon, 23 Jan 2023 10:55:52 -0800 >>>> >>>>> On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau >>>>> <martin.lau@linux.dev> wrote: >>>>>> >>>>>> On 1/19/23 2:15 PM, Stanislav Fomichev wrote: >>>>>>> Please see the first patch in the series for the overall design >>>>>>> and use-cases. >>>>>>> >>>>>>> See the following email from Toke for the per-packet metadata >>>>>>> overhead: >>>>>>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.c >>>>>>> om/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 >>>>>>> >>>>>>> Recent changes: >>>>>>> - Keep new functions in en/xdp.c, do 'extern >>>>>>> mlx5_xdp_metadata_ops' (Tariq) >>>>>>> >>>>>>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) >>>>>>> >>>>>>> - Clarify xdp_buff vs 'XDP frame' (Jesper) >>>>>>> >>>>>>> - Explicitly mention that AF_XDP RX descriptor lacks metadata >>>>>>> size >>>>>>> (Jesper) >>>>>>> >>>>>>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex >>>>>>> instead >>>>>>> of ifname (due to recent xsk.h refactoring) >>>>>> >>>>>> Applied with the minor changes in the selftests discussed in patch >>>>>> 11 and 17. >>>>>> Thanks! >>>>> >>>>> Awesome, thanks! I was gonna resend around Wed, but thank you for >>>>> taking care of that! >>>> Great stuff, congrats! :) >>> >>> Yeah! Thanks for carrying this forward, Stanislav! :) >> >> +1000 -- great work everybody! :-) >> >> To Alexander (Cc Jesse and Tony), do you think someone from Intel >> could look at extending drivers: >> >> drivers/net/ethernet/intel/igb/ - chip i210 >> drivers/net/ethernet/intel/igc/ - chip i225 >> drivers/net/ethernet/stmicro/stmmac - for CPU integrated LAN ports > >Sorry, just noticed :s > >I work with ice only, but seems like the responsible teams started some work >already. At least for i225. They may write some follow-ups soon. > Hi Jesper, FYI, me and my team will enable Rx metadata on stmmac and igc for Rx HWTS. Will submit the patches for review after done. >> >> We have a customer that have been eager to get hardware >> RX-timestamping for their AF_XDP use-case (PoC code[1] use software >> timestamping via >> bpf_ktime_get_ns() today). Getting driver support will qualify this >> hardware as part of their HW solution. >> >> --Jesper >> [1] >> https://github.com/xdp-project/bpf-examples/blob/master/AF_XDP-interac >> tion/af_xdp_kern.c#L77 >> > >Thanks, >Olek Thanks & Regards Siang