| Message ID | 20230126074356.431306-1-francesco@dolcini.it (mailing list archive) |
|---|---|
| Headers | show |
| Series | Bluetooth: hci_mrvl: Add serdev support for 88W8997 | expand |
Hello all, On Thu, Jan 26, 2023 at 08:43:51AM +0100, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > support for changing the baud rate. The command to change the baud rate is > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > interfaces) from NXP. Just a gently ping on this series, patches 1,2 with DT binding changes are reviewed/acked, patch 5 with the DTS change should just be on hold till patches 1-4 are merged. No feedback on patches 4 (and 3), with the BT serdev driver code changes, any plan on those? Thanks a lot! Francesco
Hi Francesco, On Fri, Feb 10, 2023 at 12:40 AM Francesco Dolcini <francesco@dolcini.it> wrote: > > Hello all, > > On Thu, Jan 26, 2023 at 08:43:51AM +0100, Francesco Dolcini wrote: > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > > support for changing the baud rate. The command to change the baud rate is > > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > > interfaces) from NXP. > > Just a gently ping on this series, patches 1,2 with DT binding changes > are reviewed/acked, patch 5 with the DTS change should just be on hold > till patches 1-4 are merged. > > No feedback on patches 4 (and 3), with the BT serdev driver code > changes, any plan on those? bots have detected errors on these changes > Thanks a lot! > Francesco >
On Fri, Feb 10, 2023 at 10:52:43AM -0800, Luiz Augusto von Dentz wrote: > Hi Francesco, > > On Fri, Feb 10, 2023 at 12:40 AM Francesco Dolcini <francesco@dolcini.it> wrote: > > > > Hello all, > > > > On Thu, Jan 26, 2023 at 08:43:51AM +0100, Francesco Dolcini wrote: > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > > > support for changing the baud rate. The command to change the baud rate is > > > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > > > interfaces) from NXP. > > > > Just a gently ping on this series, patches 1,2 with DT binding changes > > are reviewed/acked, patch 5 with the DTS change should just be on hold > > till patches 1-4 are merged. > > > > No feedback on patches 4 (and 3), with the BT serdev driver code > > changes, any plan on those? > > bots have detected errors on these changes From what I can understand from this point of view v2 is fine, the error was in v1, if I'm wrong just let me know. Said that I'll do the change you asked regarding __hci_cmd_sync_status and send a v3. Thanks, Francesco
Hi Francesco, On Fri, Feb 10, 2023 at 11:04 AM Francesco Dolcini <francesco@dolcini.it> wrote: > > On Fri, Feb 10, 2023 at 10:52:43AM -0800, Luiz Augusto von Dentz wrote: > > Hi Francesco, > > > > On Fri, Feb 10, 2023 at 12:40 AM Francesco Dolcini <francesco@dolcini.it> wrote: > > > > > > Hello all, > > > > > > On Thu, Jan 26, 2023 at 08:43:51AM +0100, Francesco Dolcini wrote: > > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > > > > support for changing the baud rate. The command to change the baud rate is > > > > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > > > > interfaces) from NXP. > > > > > > Just a gently ping on this series, patches 1,2 with DT binding changes > > > are reviewed/acked, patch 5 with the DTS change should just be on hold > > > till patches 1-4 are merged. > > > > > > No feedback on patches 4 (and 3), with the BT serdev driver code > > > changes, any plan on those? > > > > bots have detected errors on these changes > > From what I can understand from this point of view v2 is fine, the error > was in v1, if I'm wrong just let me know. > > Said that I'll do the change you asked regarding __hci_cmd_sync_status > and send a v3. Great, for some reason your set is not being tested by our CI though, @Tedd Ho-Jeong An do you know why? > Thanks, > Francesco >
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 26 Jan 2023 08:43:51 +0100 you wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes > support for changing the baud rate. The command to change the baud rate is > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth > interfaces) from NXP. > > [...] Here is the summary with links: - [v2,1/5] dt-bindings: bluetooth: marvell: add 88W8997 https://git.kernel.org/bluetooth/bluetooth-next/c/f48823aa0c4f - [v2,2/5] dt-bindings: bluetooth: marvell: add max-speed property https://git.kernel.org/bluetooth/bluetooth-next/c/d7303dce9fcb - [v2,3/5] Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids https://git.kernel.org/bluetooth/bluetooth-next/c/e275614465ec - [v2,4/5] Bluetooth: hci_mrvl: Add serdev support for 88W8997 (no matching commit) - [v2,5/5] arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4 (no matching commit) You are awesome, thank you!
From: Francesco Dolcini <francesco.dolcini@toradex.com> Add serdev support for the 88W8997 from NXP (previously Marvell). It includes support for changing the baud rate. The command to change the baud rate is taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth interfaces) from NXP. v2: - Fix the subject as pointed out by Krzysztof. Thanks! - Fix indentation in marvell-bluetooth.yaml - Fix compiler warning for kernel builds without CONFIG_OF enabled Stefan Eichenberger (5): dt-bindings: bluetooth: marvell: add 88W8997 dt-bindings: bluetooth: marvell: add max-speed property Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids Bluetooth: hci_mrvl: Add serdev support for 88W8997 arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4 .../bindings/net/marvell-bluetooth.yaml | 20 +++- .../dts/freescale/imx8mp-verdin-wifi.dtsi | 5 + drivers/bluetooth/hci_mrvl.c | 92 +++++++++++++++++-- 3 files changed, 106 insertions(+), 11 deletions(-)