mbox series

[net-next,v2,00/12] devlink: Cleanup params usage

Message ID 20230126075838.1643665-1-jiri@resnulli.us (mailing list archive)
Headers show
Series devlink: Cleanup params usage | expand

Message

Jiri Pirko Jan. 26, 2023, 7:58 a.m. UTC
From: Jiri Pirko <jiri@nvidia.com>

This patchset takes care of small cleanup of devlink params usage.
Some of the patches (first 2/3) are cosmetic, but I would like to
point couple of interesting ones:

Patch 9 is the main one of this set and introduces devlink instance
locking for params, similar to other devlink objects. That allows params
to be registered/unregistered when devlink instance is registered.

Patches 10-12 change mlx5 code to register non-driverinit params in the
code they are related to, and thanks to patch 8 this might be when
devlink instance is registered - for example during devlink reload.

---
v1->v2:
- Just small fix in the last patch

Jiri Pirko (12):
  net/mlx5: Change devlink param register/unregister function names
  net/mlx5: Covert devlink params registration to use
    devlink_params_register/unregister()
  devlink: make devlink_param_register/unregister static
  devlink: don't work with possible NULL pointer in
    devlink_param_unregister()
  ice: remove pointless calls to devlink_param_driverinit_value_set()
  qed: remove pointless call to devlink_param_driverinit_value_set()
  devlink: make devlink_param_driverinit_value_set() return void
  devlink: put couple of WARN_ONs in
    devlink_param_driverinit_value_get()
  devlink: protect devlink param list by instance lock
  net/mlx5: Move fw reset devlink param to fw reset code
  net/mlx5: Move flow steering devlink param to flow steering code
  net/mlx5: Move eswitch port metadata devlink param to flow eswitch
    code

 drivers/net/ethernet/intel/ice/ice_devlink.c  |  20 +-
 drivers/net/ethernet/mellanox/mlx4/main.c     |  80 ++---
 drivers/net/ethernet/mellanox/mlx5/core/dev.c |  18 +-
 .../net/ethernet/mellanox/mlx5/core/devlink.c | 283 +++++-------------
 .../net/ethernet/mellanox/mlx5/core/devlink.h |   4 +-
 drivers/net/ethernet/mellanox/mlx5/core/eq.c  |  12 +-
 .../net/ethernet/mellanox/mlx5/core/eswitch.c |  10 +-
 .../net/ethernet/mellanox/mlx5/core/eswitch.h |   4 +-
 .../mellanox/mlx5/core/eswitch_offloads.c     |  92 +++++-
 .../net/ethernet/mellanox/mlx5/core/fs_core.c |  84 +++++-
 .../ethernet/mellanox/mlx5/core/fw_reset.c    |  44 ++-
 .../ethernet/mellanox/mlx5/core/fw_reset.h    |   2 -
 .../net/ethernet/mellanox/mlx5/core/main.c    |  22 +-
 drivers/net/ethernet/mellanox/mlxsw/core.c    |  18 +-
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |  16 +-
 .../ethernet/netronome/nfp/devlink_param.c    |   8 +-
 .../net/ethernet/netronome/nfp/nfp_net_main.c |   7 +-
 drivers/net/ethernet/qlogic/qed/qed_devlink.c |   6 -
 drivers/net/netdevsim/dev.c                   |  36 +--
 include/net/devlink.h                         |  20 +-
 net/devlink/leftover.c                        | 185 ++++++------
 21 files changed, 521 insertions(+), 450 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 27, 2023, 12:50 p.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 26 Jan 2023 08:58:26 +0100 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> This patchset takes care of small cleanup of devlink params usage.
> Some of the patches (first 2/3) are cosmetic, but I would like to
> point couple of interesting ones:
> 
> Patch 9 is the main one of this set and introduces devlink instance
> locking for params, similar to other devlink objects. That allows params
> to be registered/unregistered when devlink instance is registered.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,01/12] net/mlx5: Change devlink param register/unregister function names
    https://git.kernel.org/netdev/net-next/c/c8aebff4599f
  - [net-next,v2,02/12] net/mlx5: Covert devlink params registration to use devlink_params_register/unregister()
    https://git.kernel.org/netdev/net-next/c/a756185ac3b9
  - [net-next,v2,03/12] devlink: make devlink_param_register/unregister static
    https://git.kernel.org/netdev/net-next/c/020dd127a3fe
  - [net-next,v2,04/12] devlink: don't work with possible NULL pointer in devlink_param_unregister()
    https://git.kernel.org/netdev/net-next/c/bb9bb6bfd1c3
  - [net-next,v2,05/12] ice: remove pointless calls to devlink_param_driverinit_value_set()
    https://git.kernel.org/netdev/net-next/c/2fc631b5d75d
  - [net-next,v2,06/12] qed: remove pointless call to devlink_param_driverinit_value_set()
    https://git.kernel.org/netdev/net-next/c/6fd6eda0e65d
  - [net-next,v2,07/12] devlink: make devlink_param_driverinit_value_set() return void
    https://git.kernel.org/netdev/net-next/c/85fe0b324c83
  - [net-next,v2,08/12] devlink: put couple of WARN_ONs in devlink_param_driverinit_value_get()
    https://git.kernel.org/netdev/net-next/c/3f716a620e13
  - [net-next,v2,09/12] devlink: protect devlink param list by instance lock
    https://git.kernel.org/netdev/net-next/c/075935f0ae0f
  - [net-next,v2,10/12] net/mlx5: Move fw reset devlink param to fw reset code
    https://git.kernel.org/netdev/net-next/c/c2077fbc42ae
  - [net-next,v2,11/12] net/mlx5: Move flow steering devlink param to flow steering code
    https://git.kernel.org/netdev/net-next/c/db492c1e5b1b
  - [net-next,v2,12/12] net/mlx5: Move eswitch port metadata devlink param to flow eswitch code
    https://git.kernel.org/netdev/net-next/c/d2a651ef18c0

You are awesome, thank you!