| Message ID | 20230211005017.48134-1-shannon.nelson@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ionic: on-chip descriptors | expand |
On Fri, 10 Feb 2023 16:50:13 -0800 Shannon Nelson wrote: > v4: added rx-push attributes to ethtool netlink > converted CMB feature from using a priv-flag to using ethtool tx/rx-push Neat, so it is close enough to how hns3 uses it? Or at least the behavior of the knob as documented?
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 10 Feb 2023 16:50:13 -0800 you wrote: > We start with a couple of house-keeping patches that were originally > presented for 'net', then we add support for on-chip descriptor rings > for tx-push, as well as adding support for rx-push. > > I have a patch for the ethtool userland utility that I can send out > once this has been accepted. > > [...] Here is the summary with links: - [v4,net-next,1/4] ionic: remove unnecessary indirection https://git.kernel.org/netdev/net-next/c/7bb990097db7 - [v4,net-next,2/4] ionic: remove unnecessary void casts https://git.kernel.org/netdev/net-next/c/896de449f804 - [v4,net-next,3/4] net: ethtool: extend ringparam set/get APIs for rx_push https://git.kernel.org/netdev/net-next/c/5b4e9a7a71ab - [v4,net-next,4/4] ionic: add tx/rx-push support with device Component Memory Buffers https://git.kernel.org/netdev/net-next/c/40bc471dc714 You are awesome, thank you!
On 2/10/23 5:45 PM, Jakub Kicinski wrote: > On Fri, 10 Feb 2023 16:50:13 -0800 Shannon Nelson wrote: >> v4: added rx-push attributes to ethtool netlink >> converted CMB feature from using a priv-flag to using ethtool tx/rx-push > > Neat, so it is close enough to how hns3 uses it? > Or at least the behavior of the knob as documented? Yes, I think so. I'll send out an update for the ethtool utility in the next day or so. sln
We start with a couple of house-keeping patches that were originally presented for 'net', then we add support for on-chip descriptor rings for tx-push, as well as adding support for rx-push. I have a patch for the ethtool userland utility that I can send out once this has been accepted. v4: added rx-push attributes to ethtool netlink converted CMB feature from using a priv-flag to using ethtool tx/rx-push v3: edited commit message to describe interface-down limitation added warn msg if cmb_inuse alloc fails removed unnecessary clearing of phy_cmb_pages and cmb_npages changed cmb_rings_toggle to use cmb_inuse removed unrelated pci_set_drvdata() removed unnecessary (u32) cast added static inline func for writing CMB descriptors v2: dropped the rx buffers patch Shannon Nelson (4): ionic: remove unnecessary indirection ionic: remove unnecessary void casts net: ethtool: extend ringparam set/get APIs for rx_push ionic: add tx/rx-push support with device Component Memory Buffers Documentation/networking/ethtool-netlink.rst | 6 +- .../ethernet/pensando/ionic/ionic_bus_pci.c | 6 +- .../net/ethernet/pensando/ionic/ionic_dev.c | 67 +++++++ .../net/ethernet/pensando/ionic/ionic_dev.h | 13 ++ .../ethernet/pensando/ionic/ionic_ethtool.c | 117 ++++++++++++- .../net/ethernet/pensando/ionic/ionic_if.h | 3 +- .../net/ethernet/pensando/ionic/ionic_lif.c | 165 ++++++++++++++++-- .../net/ethernet/pensando/ionic/ionic_lif.h | 40 ++++- .../net/ethernet/pensando/ionic/ionic_main.c | 4 +- .../net/ethernet/pensando/ionic/ionic_phc.c | 2 +- .../ethernet/pensando/ionic/ionic_rx_filter.c | 4 +- .../net/ethernet/pensando/ionic/ionic_txrx.c | 22 ++- include/linux/ethtool.h | 4 + include/uapi/linux/ethtool_netlink.h | 1 + net/ethtool/netlink.h | 2 +- net/ethtool/rings.c | 17 +- 16 files changed, 438 insertions(+), 35 deletions(-)