| Message ID | 20230212132520.12571-1-ozsh@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add support for per action hw stats | expand |
Hello: This series was applied to netdev/net-next.git (master) by Paolo Abeni <pabeni@redhat.com>: On Sun, 12 Feb 2023 15:25:11 +0200 you wrote: > There are currently two mechanisms for populating hardware stats: > 1. Using flow_offload api to query the flow's statistics. > The api assumes that the same stats values apply to all > the flow's actions. > This assumption breaks when action drops or jumps over following > actions. > 2. Using hw_action api to query specific action stats via a driver > callback method. This api assures the correct action stats for > the offloaded action, however, it does not apply to the rest of the > actions in the flow's actions array, as elaborated below. > > [...] Here is the summary with links: - [net-next,v4,1/9] net/sched: optimize action stats api calls https://git.kernel.org/netdev/net-next/c/8f2ca70c07f4 - [net-next,v4,2/9] net/sched: act_pedit, setup offload action for action stats query https://git.kernel.org/netdev/net-next/c/3320f36fd8ad - [net-next,v4,3/9] net/sched: pass flow_stats instead of multiple stats args https://git.kernel.org/netdev/net-next/c/ac7d27907d54 - [net-next,v4,4/9] net/sched: introduce flow_offload action cookie https://git.kernel.org/netdev/net-next/c/d307b2c6f962 - [net-next,v4,5/9] net/sched: support per action hw stats https://git.kernel.org/netdev/net-next/c/5246c896b805 - [net-next,v4,6/9] net/mlx5e: TC, add hw counter to branching actions https://git.kernel.org/netdev/net-next/c/e9d1061d8727 - [net-next,v4,7/9] net/mlx5e: TC, store tc action cookies per attr https://git.kernel.org/netdev/net-next/c/cca7eac13856 - [net-next,v4,8/9] net/mlx5e: TC, map tc action cookie to a hw counter https://git.kernel.org/netdev/net-next/c/d13674b1d14c - [net-next,v4,9/9] net/mlx5e: TC, support per action stats https://git.kernel.org/netdev/net-next/c/2b68d659a704 You are awesome, thank you!
There are currently two mechanisms for populating hardware stats: 1. Using flow_offload api to query the flow's statistics. The api assumes that the same stats values apply to all the flow's actions. This assumption breaks when action drops or jumps over following actions. 2. Using hw_action api to query specific action stats via a driver callback method. This api assures the correct action stats for the offloaded action, however, it does not apply to the rest of the actions in the flow's actions array, as elaborated below. The current hw_action api does not apply to the following use cases: 1. Actions that are implicitly created by filters (aka bind actions). In the following example only one counter will apply to the rule: tc filter add dev $DEV prio 2 protocol ip parent ffff: \ flower ip_proto tcp dst_ip $IP2 \ action police rate 1mbit burst 100k conform-exceed drop/pipe \ action mirred egress redirect dev $DEV2 2. Action preceding a hw action. In the following example the same flow stats will apply to the sample and mirred actions: tc action add police rate 1mbit burst 100k conform-exceed drop / pipe tc filter add dev $DEV prio 2 protocol ip parent ffff: \ flower ip_proto tcp dst_ip $IP2 \ action sample rate 1 group 10 trunc 60 pipe \ action police index 1 \ action mirred egress redirect dev $DEV2 3. Meter action using jump control. In the following example the same flow stats will apply to both mirred actions: tc action add police rate 1mbit burst 100k conform-exceed jump 2 / pipe tc filter add dev $DEV prio 2 protocol ip parent ffff: \ flower ip_proto tcp dst_ip $IP2 \ action police index 1 \ action mirred egress redirect dev $DEV2 action mirred egress redirect dev $DEV3 This series provides the platform to query per action stats for in_hw flows. The first four patches are preparation patches with no functionality change. The fifth patch re-uses the existing flow action stats api to query action stats for both classifier and action dumps. The rest of the patches add per action stats support to the Mellanox driver. Oz Shlomo (9): net/sched: optimize action stats api calls net/sched: act_pedit, setup offload action for action stats query net/sched: pass flow_stats instead of multiple stats args net/sched: introduce flow_offload action cookie net/sched: support per action hw stats net/mlx5e: TC, add hw counter to branching actions net/mlx5e: TC, store tc action cookies per attr net/mlx5e: TC, map tc action cookie to a hw counter net/mlx5e: TC, support per action stats drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- .../net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 2 +- .../ethernet/mellanox/mlx5/core/en/tc/act_stats.c | 197 +++++++++++++++++++++ .../ethernet/mellanox/mlx5/core/en/tc/act_stats.h | 27 +++ .../net/ethernet/mellanox/mlx5/core/en/tc_priv.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_rep.h | 3 + drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 91 ++++++++-- drivers/net/ethernet/mellanox/mlx5/core/en_tc.h | 4 + .../net/ethernet/mellanox/mlx5/core/fs_counters.c | 10 ++ include/linux/mlx5/fs.h | 2 + include/net/flow_offload.h | 3 + include/net/pkt_cls.h | 30 ++-- net/sched/act_api.c | 14 +- net/sched/act_pedit.c | 23 ++- net/sched/cls_api.c | 1 + net/sched/cls_flower.c | 7 +- net/sched/cls_matchall.c | 6 +- 17 files changed, 375 insertions(+), 48 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en/tc/act_stats.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en/tc/act_stats.h