| Message ID | 20230306041535.73319-1-xuanzhuo@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add checking sq is full inside xdp xmit | expand |
On Mon, 2023-03-06 at 12:15 +0800, Xuan Zhuo wrote: > If the queue of xdp xmit is not an independent queue, then when the xdp > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > the following error. > > net ens4: Unexpected TXQ (0) queue failure: -28 > > This patch adds a check whether sq is full in XDP Xmit. > > Thanks. > > Xuan Zhuo (2): > virtio_net: separate the logic of checking whether sq is full > virtio_net: add checking sq is full inside xdp xmit > > drivers/net/virtio_net.c | 78 ++++++++++++++++++++++++---------------- > 1 file changed, 47 insertions(+), 31 deletions(-) > > -- > 2.32.0.3.g01195cf9f > Series looks good to me. Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > If the queue of xdp xmit is not an independent queue, then when the xdp > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > the following error. > > net ens4: Unexpected TXQ (0) queue failure: -28 > > This patch adds a check whether sq is full in XDP Xmit. > > Thanks. Acked-by: Michael S. Tsirkin <mst@redhat.com> needed for stable? > Xuan Zhuo (2): > virtio_net: separate the logic of checking whether sq is full > virtio_net: add checking sq is full inside xdp xmit > > drivers/net/virtio_net.c | 78 ++++++++++++++++++++++++---------------- > 1 file changed, 47 insertions(+), 31 deletions(-) > > -- > 2.32.0.3.g01195cf9f
On Mon, 6 Mar 2023 12:58:22 -0500, "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > > If the queue of xdp xmit is not an independent queue, then when the xdp > > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > > the following error. > > > > net ens4: Unexpected TXQ (0) queue failure: -28 > > > > This patch adds a check whether sq is full in XDP Xmit. > > > > Thanks. > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > needed for stable? Yes i think. Thanks. > > > Xuan Zhuo (2): > > virtio_net: separate the logic of checking whether sq is full > > virtio_net: add checking sq is full inside xdp xmit > > > > drivers/net/virtio_net.c | 78 ++++++++++++++++++++++++---------------- > > 1 file changed, 47 insertions(+), 31 deletions(-) > > > > -- > > 2.32.0.3.g01195cf9f >
Hi, On Tue, 2023-03-07 at 09:49 +0800, Xuan Zhuo wrote: > On Mon, 6 Mar 2023 12:58:22 -0500, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > > > If the queue of xdp xmit is not an independent queue, then when the xdp > > > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > > > the following error. > > > > > > net ens4: Unexpected TXQ (0) queue failure: -28 > > > > > > This patch adds a check whether sq is full in XDP Xmit. > > > > > > Thanks. > > > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > > > needed for stable? > > Yes i think. Could you please re-post including a suitable 'Fixes' tag? That would address stable, too. Additionally you could rename check_sq_full() in patch 1, perhaps 'check_disable_sq_full()' would do. You can retain the already collected tags. Thanks! Paolo
On Tue, 07 Mar 2023 10:53:41 +0100, Paolo Abeni <pabeni@redhat.com> wrote: > Hi, > On Tue, 2023-03-07 at 09:49 +0800, Xuan Zhuo wrote: > > On Mon, 6 Mar 2023 12:58:22 -0500, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > > > > If the queue of xdp xmit is not an independent queue, then when the xdp > > > > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > > > > the following error. > > > > > > > > net ens4: Unexpected TXQ (0) queue failure: -28 > > > > > > > > This patch adds a check whether sq is full in XDP Xmit. > > > > > > > > Thanks. > > > > > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > > > > > needed for stable? > > > > Yes i think. > > Could you please re-post including a suitable 'Fixes' tag? That would > address stable, too. Additionally you could rename check_sq_full() in > patch 1, perhaps 'check_disable_sq_full()' would do. > > You can retain the already collected tags. OK Thanks. > > Thanks! > > Paolo >
On Tue, Mar 07, 2023 at 10:53:41AM +0100, Paolo Abeni wrote: > Hi, > On Tue, 2023-03-07 at 09:49 +0800, Xuan Zhuo wrote: > > On Mon, 6 Mar 2023 12:58:22 -0500, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > > > > If the queue of xdp xmit is not an independent queue, then when the xdp > > > > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > > > > the following error. > > > > > > > > net ens4: Unexpected TXQ (0) queue failure: -28 > > > > > > > > This patch adds a check whether sq is full in XDP Xmit. > > > > > > > > Thanks. > > > > > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > > > > > needed for stable? > > > > Yes i think. > > Could you please re-post including a suitable 'Fixes' tag? That would > address stable, too. Additionally you could rename check_sq_full() in > patch 1, perhaps 'check_disable_sq_full()' would do. Not that's even more confusing it sounds like it's checking that it's checking that sq is disabled unless one looks closely. I think check_sq_full_and_disable() is better. > You can retain the already collected tags. > > Thanks! > > Paolo