From patchwork Tue Mar 7 23:32:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kui-Feng Lee X-Patchwork-Id: 13164939 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E61A1C74A4B for ; Tue, 7 Mar 2023 23:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbjCGXdV (ORCPT ); Tue, 7 Mar 2023 18:33:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbjCGXdS (ORCPT ); Tue, 7 Mar 2023 18:33:18 -0500 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 430044ECCA for ; Tue, 7 Mar 2023 15:33:17 -0800 (PST) Received: from pps.filterd (m0109332.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 327KgDoX031247 for ; Tue, 7 Mar 2023 15:33:16 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=s2048-2021-q4; bh=JuUsaGjz0FOzsIY+YADBE00fZV81KJ1CbSmQq3049vc=; b=fDInSrXAg3loyphXJ26q5CoSYEpYs01ZzK7mVUB51QmO9s4/m3Loh+rAkJwXDcEiawQv fi2KbWNuDiCVv5UjW0XbrLXAZio8mP6YFL5oCDZTaFac4WCZ3TlwTP5QKvY0A9Rwgaa6 4vajzZyEuIsodK6HcqDPT2oNA4YhSMrWvzaaBmT2dYp0pNPLz4Y4bV7wyh3FOewAaZXW Ax++N8h9SZ1PYFbKA22+rPxw+yYjljQ6vts+sgJaBNwh5RQxJJigM/94eqOPI9QU8L4z iwcAHLkkTB7z3zHbCIyllJGZTmjOefd32eRQeGRRO6r6rwZdBy4daS1ky+MuUzJq4kjU MQ== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3p63bvdb47-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 07 Mar 2023 15:33:16 -0800 Received: from twshared21760.39.frc1.facebook.com (2620:10d:c085:208::11) by mail.thefacebook.com (2620:10d:c085:11d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Tue, 7 Mar 2023 15:33:15 -0800 Received: by devbig931.frc1.facebook.com (Postfix, from userid 460691) id 128B86C7C9B3; Tue, 7 Mar 2023 15:33:12 -0800 (PST) From: Kui-Feng Lee To: , , , , , , CC: Kui-Feng Lee Subject: [PATCH bpf-next v4 0/9] Transit between BPF TCP congestion controls. Date: Tue, 7 Mar 2023 15:32:58 -0800 Message-ID: <20230307233307.3626875-1-kuifeng@meta.com> X-Mailer: git-send-email 2.34.1 X-FB-Internal: Safe X-Proofpoint-GUID: LNFs4XxkTcqF_nTrc4tjQKU_LXzYUsl- X-Proofpoint-ORIG-GUID: LNFs4XxkTcqF_nTrc4tjQKU_LXzYUsl- X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-07_16,2023-03-07_01,2023-02-09_01 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net Major changes: - Create bpf_links in the kernel for BPF struct_ops to register and unregister it. - Enables switching between implementations of bpf-tcp-cc under a name instantly by replacing the backing struct_ops map of a bpf_link. Previously, BPF struct_ops didn't go off, as even when the user program creating it was terminated, none of these ever were pinned. For instance, the TCP congestion control subsystem indirectly maintains a reference count on the struct_ops of any registered BPF implemented algorithm. Thus, the algorithm won't be deactivated until someone deliberately unregisters it. For compatibility with other BPF programs, bpf_links have been created to work in coordination with struct_ops maps. This ensures that the registration and unregistration of these respective maps is carried out at the start and end of the bpf_link. We also faced complications when attempting to replace an existing TCP congestion control algorithm with a new implementation on the fly. A struct_ops map was used to register a TCP congestion control algorithm with a unique name. We had to either register the alternative implementation with a new name and move over or unregister the current one before being able to reregistration with the same name. To fix this problem, we can an option to migrate the registration of the algorithm from struct_ops maps to bpf_links. By modifying the backing map of a bpf_link, it suddenly becomes possible to replace an existing TCP congestion control algorithm with ease. The major differences from v3: - Remove bpf_struct_ops_map_free_rcu(), and use synchronize_rcu(). - Improve the commit log of the part 1. - Before transitioning to the READY state, we conduct a value check to ensure that struct_ops can be successfully utilized and links created later. The major differences from v2: - Simplify states - Remove TOBEUNREG. - Rename UNREG to READY. - Stop using the refcnt of the kvalue of a struct_ops. Explicitly increase and decrease the refcount of struct_ops. - Prepare kernel vdata during the load phase of libbpf. The major differences from v1: - Added bpf_struct_ops_link to replace the previous union-based approach. - Added UNREG and TOBEUNREG to the state of bpf_struct_ops_map. - bpf_struct_ops_transit_state() maintains state transitions. - Fixed synchronization issue. - Prepare kernel vdata of struct_ops during the loading phase of bpf_object. - Merged previous patch 3 to patch 1. v3: https://lore.kernel.org/all/20230303012122.852654-1-kuifeng@meta.com/ v2: https://lore.kernel.org/bpf/20230223011238.12313-1-kuifeng@meta.com/ v1: https://lore.kernel.org/bpf/20230214221718.503964-1-kuifeng@meta.com/ Kui-Feng Lee (9): bpf: Retire the struct_ops map kvalue->refcnt. bpf: Create links for BPF struct_ops maps. net: Update an existing TCP congestion control algorithm. bpf: Validate kdata of a struct_ops before transiting to READY. libbpf: Create a bpf_link in bpf_map__attach_struct_ops(). bpf: Update the struct_ops of a bpf_link. libbpf: Update a bpf_link with another struct_ops. libbpf: Use .struct_ops.link section to indicate a struct_ops with a link. selftests/bpf: Test switching TCP Congestion Control algorithms. include/linux/bpf.h | 16 ++ include/net/tcp.h | 3 + include/uapi/linux/bpf.h | 20 +- kernel/bpf/bpf_struct_ops.c | 218 +++++++++++++++--- kernel/bpf/syscall.c | 68 ++++-- net/bpf/bpf_dummy_struct_ops.c | 6 + net/ipv4/bpf_tcp_ca.c | 14 +- net/ipv4/tcp_cong.c | 57 ++++- tools/include/uapi/linux/bpf.h | 19 +- tools/lib/bpf/libbpf.c | 184 ++++++++++++--- tools/lib/bpf/libbpf.h | 1 + tools/lib/bpf/libbpf.map | 2 + .../selftests/bpf/prog_tests/bpf_tcp_ca.c | 38 +++ .../selftests/bpf/progs/tcp_ca_update.c | 62 +++++ 14 files changed, 616 insertions(+), 92 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/tcp_ca_update.c