| Message ID | 20230311181905.3593904-1-seanga2@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: sunhme: Probe/IRQ cleanups | expand |
On Sat, 11 Mar 2023 13:18:56 -0500 Sean Anderson wrote: > Well, I've had these patches kicking around in my tree since last October, so I > guess I had better get around to posting them. This series is mainly a > cleanup/consolidation of the probe process, with some interrupt changes as well. > Some of these changes are SBUS- (AKA SPARC-) specific, so this should really get > some testing there as well to ensure nothing breaks. I've CC'd a few SPARC > mailing lists in hopes that someone there can try this out. I also have an SBUS > card I ordered by mistake if anyone has a SPARC computer but lacks this card. > > I had originally planned on adding phylib support to this driver in the hopes of > being able to use real phy drivers, but I don't think I'm going to end up doing > that. I wanted to be able to use an external (homegrown) phy, but as it turns > out you can't buy MII cables in $CURRENTYEAR for under $250 a pop, and even if > you could get them you can't buy the connectors either. Oh well... Doesn't apply to net-next, please note we're using the branch called *main* now.
On 3/13/23 20:27, Jakub Kicinski wrote: > On Sat, 11 Mar 2023 13:18:56 -0500 Sean Anderson wrote: >> Well, I've had these patches kicking around in my tree since last October, so I >> guess I had better get around to posting them. This series is mainly a >> cleanup/consolidation of the probe process, with some interrupt changes as well. >> Some of these changes are SBUS- (AKA SPARC-) specific, so this should really get >> some testing there as well to ensure nothing breaks. I've CC'd a few SPARC >> mailing lists in hopes that someone there can try this out. I also have an SBUS >> card I ordered by mistake if anyone has a SPARC computer but lacks this card. >> >> I had originally planned on adding phylib support to this driver in the hopes of >> being able to use real phy drivers, but I don't think I'm going to end up doing >> that. I wanted to be able to use an external (homegrown) phy, but as it turns >> out you can't buy MII cables in $CURRENTYEAR for under $250 a pop, and even if >> you could get them you can't buy the connectors either. Oh well... > > Doesn't apply to net-next, please note we're using the branch called > *main* now. Looks like I based this on another patch but forgot to send it. I've resent the series with this patch squashed in. --Sean
Well, I've had these patches kicking around in my tree since last October, so I guess I had better get around to posting them. This series is mainly a cleanup/consolidation of the probe process, with some interrupt changes as well. Some of these changes are SBUS- (AKA SPARC-) specific, so this should really get some testing there as well to ensure nothing breaks. I've CC'd a few SPARC mailing lists in hopes that someone there can try this out. I also have an SBUS card I ordered by mistake if anyone has a SPARC computer but lacks this card. I had originally planned on adding phylib support to this driver in the hopes of being able to use real phy drivers, but I don't think I'm going to end up doing that. I wanted to be able to use an external (homegrown) phy, but as it turns out you can't buy MII cables in $CURRENTYEAR for under $250 a pop, and even if you could get them you can't buy the connectors either. Oh well... Changes in v2: - Move happy_meal_begin_auto_negotiation earlier and remove forward declaration - Make some more includes common - Clean up mac address init - Inline error returns Sean Anderson (9): net: sunhme: Just restart autonegotiation if we can't bring the link up net: sunhme: Remove residual polling code net: sunhme: Unify IRQ requesting net: sunhme: Alphabetize includes net: sunhme: Switch SBUS to devres net: sunhme: Consolidate mac address initialization net: sunhme: Clean up mac address init net: sunhme: Inline error returns net: sunhme: Consolidate common probe tasks drivers/net/ethernet/sun/sunhme.c | 1162 ++++++++++------------------- drivers/net/ethernet/sun/sunhme.h | 6 +- 2 files changed, 415 insertions(+), 753 deletions(-)