| Message ID | 20230316033753.2320557-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net/sched: fix parsing of TCA_EXT_WARN_MSG for tc action | expand |
On Thu, Mar 16, 2023 at 11:37:51AM +0800, Hangbin Liu wrote: > In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG > to report tc extact message") I didn't notice the tc action use different > enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action. > > Let's rever the previous fix 923b2e30dc9c ("net/sched: act_api: move > TCA_EXT_WARN_MSG to the correct hierarchy") and add a new > TCA_ROOT_EXT_WARN_MSG for tc action specifically. Sigh. Sorry I sent the mail too quick and forgot to add Reported-and-tested-by: Davide Caratti <dcaratti@redhat.com>
On Wed, Mar 15, 2023 at 11:55 PM Hangbin Liu <liuhangbin@gmail.com> wrote: > > On Thu, Mar 16, 2023 at 11:37:51AM +0800, Hangbin Liu wrote: > > In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG > > to report tc extact message") I didn't notice the tc action use different > > enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action. > > > > Let's rever the previous fix 923b2e30dc9c ("net/sched: act_api: move > > TCA_EXT_WARN_MSG to the correct hierarchy") and add a new > > TCA_ROOT_EXT_WARN_MSG for tc action specifically. > > Sigh. Sorry I sent the mail too quick and forgot to add > > Reported-and-tested-by: Davide Caratti <dcaratti@redhat.com> For next time: instead of saying in the commit message "suggested by foo" specify it using "suggested-by: foo" semantics. cheers, jamal
On Thu, Mar 16, 2023 at 05:45:28AM -0400, Jamal Hadi Salim wrote: > On Wed, Mar 15, 2023 at 11:55 PM Hangbin Liu <liuhangbin@gmail.com> wrote: > > > > On Thu, Mar 16, 2023 at 11:37:51AM +0800, Hangbin Liu wrote: > > > In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG > > > to report tc extact message") I didn't notice the tc action use different > > > enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action. > > > > > > Let's rever the previous fix 923b2e30dc9c ("net/sched: act_api: move > > > TCA_EXT_WARN_MSG to the correct hierarchy") and add a new > > > TCA_ROOT_EXT_WARN_MSG for tc action specifically. > > > > Sigh. Sorry I sent the mail too quick and forgot to add > > > > Reported-and-tested-by: Davide Caratti <dcaratti@redhat.com> > > For next time: instead of saying in the commit message "suggested by > foo" specify it using "suggested-by: foo" semantics. Sure, I will Thanks Hangbin
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 16 Mar 2023 11:37:51 +0800 you wrote: > In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG > to report tc extact message") I didn't notice the tc action use different > enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action. > > Let's rever the previous fix 923b2e30dc9c ("net/sched: act_api: move > TCA_EXT_WARN_MSG to the correct hierarchy") and add a new > TCA_ROOT_EXT_WARN_MSG for tc action specifically. > > [...] Here is the summary with links: - [PATCHv2,net,1/2] Revert "net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy" https://git.kernel.org/netdev/net/c/8de2bd02439e - [PATCHv2,net,2/2] net/sched: act_api: add specific EXT_WARN_MSG for tc action https://git.kernel.org/netdev/net/c/2f59823fe696 You are awesome, thank you!
In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG to report tc extact message") I didn't notice the tc action use different enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action. Let's rever the previous fix 923b2e30dc9c ("net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy") and add a new TCA_ROOT_EXT_WARN_MSG for tc action specifically. Here is the tdc test result: 1..1119 ok 1 d959 - Add cBPF action with valid bytecode ok 2 f84a - Add cBPF action with invalid bytecode ok 3 e939 - Add eBPF action with valid object-file ok 4 282d - Add eBPF action with invalid object-file ok 5 d819 - Replace cBPF bytecode and action control ok 6 6ae3 - Delete cBPF action ok 7 3e0d - List cBPF actions ok 8 55ce - Flush BPF actions ok 9 ccc3 - Add cBPF action with duplicate index ok 10 89c7 - Add cBPF action with invalid index [...] ok 1115 2348 - Show TBF class ok 1116 84a0 - Create TEQL with default setting ok 1117 7734 - Create TEQL with multiple device ok 1118 34a9 - Delete TEQL with valid handle ok 1119 6289 - Show TEQL stats Hangbin Liu (2): Revert "net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy" net/sched: act_api: add specific EXT_WARN_MSG for tc action include/uapi/linux/rtnetlink.h | 1 + net/sched/act_api.c | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-)