| Message ID | 20230322030308.16046-1-xuanzhuo@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | virtio_net: refactor xdp codes | expand |
On Wed, Mar 22, 2023 at 11:03:00AM +0800, Xuan Zhuo wrote: > Due to historical reasons, the implementation of XDP in virtio-net is relatively > chaotic. For example, the processing of XDP actions has two copies of similar > code. Such as page, xdp_page processing, etc. > > The purpose of this patch set is to refactor these code. Reduce the difficulty > of subsequent maintenance. Subsequent developers will not introduce new bugs > because of some complex logical relationships. > > In addition, the supporting to AF_XDP that I want to submit later will also need > to reuse the logic of XDP, such as the processing of actions, I don't want to > introduce a new similar code. In this way, I can reuse these codes in the > future. > > Please review. > > Thanks. I really want to see that code make progress though. Would it make sense to merge this one through the virtio tree? Then you will have all the pieces in one place and try to target next linux. > Xuan Zhuo (8): > virtio_net: mergeable xdp: put old page immediately > virtio_net: mergeable xdp: introduce mergeable_xdp_prepare > virtio_net: introduce virtnet_xdp_handler() to seprate the logic of > run xdp > virtio_net: separate the logic of freeing xdp shinfo > virtio_net: separate the logic of freeing the rest mergeable buf > virtio_net: auto release xdp shinfo > virtio_net: introduce receive_mergeable_xdp() > virtio_net: introduce receive_small_xdp() > > drivers/net/virtio_net.c | 615 +++++++++++++++++++++++---------------- > 1 file changed, 357 insertions(+), 258 deletions(-) > > -- > 2.32.0.3.g01195cf9f
On Tue, 21 Mar 2023 23:34:43 -0400, "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Wed, Mar 22, 2023 at 11:03:00AM +0800, Xuan Zhuo wrote: > > Due to historical reasons, the implementation of XDP in virtio-net is relatively > > chaotic. For example, the processing of XDP actions has two copies of similar > > code. Such as page, xdp_page processing, etc. > > > > The purpose of this patch set is to refactor these code. Reduce the difficulty > > of subsequent maintenance. Subsequent developers will not introduce new bugs > > because of some complex logical relationships. > > > > In addition, the supporting to AF_XDP that I want to submit later will also need > > to reuse the logic of XDP, such as the processing of actions, I don't want to > > introduce a new similar code. In this way, I can reuse these codes in the > > future. > > > > Please review. > > > > Thanks. > > I really want to see that code make progress though. I want to know, you refer to virtio-net + AF_XDP or refactor for XDP. > Would it make sense to merge this one through the virtio tree? There are some small problems that we merge this patch-set to Virtio Tree directly. Thanks. > > Then you will have all the pieces in one place and try to target > next linux. > > > > Xuan Zhuo (8): > > virtio_net: mergeable xdp: put old page immediately > > virtio_net: mergeable xdp: introduce mergeable_xdp_prepare > > virtio_net: introduce virtnet_xdp_handler() to seprate the logic of > > run xdp > > virtio_net: separate the logic of freeing xdp shinfo > > virtio_net: separate the logic of freeing the rest mergeable buf > > virtio_net: auto release xdp shinfo > > virtio_net: introduce receive_mergeable_xdp() > > virtio_net: introduce receive_small_xdp() > > > > drivers/net/virtio_net.c | 615 +++++++++++++++++++++++---------------- > > 1 file changed, 357 insertions(+), 258 deletions(-) > > > > -- > > 2.32.0.3.g01195cf9f >
On Wed, Mar 22, 2023 at 11:40:56AM +0800, Xuan Zhuo wrote: > On Tue, 21 Mar 2023 23:34:43 -0400, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > On Wed, Mar 22, 2023 at 11:03:00AM +0800, Xuan Zhuo wrote: > > > Due to historical reasons, the implementation of XDP in virtio-net is relatively > > > chaotic. For example, the processing of XDP actions has two copies of similar > > > code. Such as page, xdp_page processing, etc. > > > > > > The purpose of this patch set is to refactor these code. Reduce the difficulty > > > of subsequent maintenance. Subsequent developers will not introduce new bugs > > > because of some complex logical relationships. > > > > > > In addition, the supporting to AF_XDP that I want to submit later will also need > > > to reuse the logic of XDP, such as the processing of actions, I don't want to > > > introduce a new similar code. In this way, I can reuse these codes in the > > > future. > > > > > > Please review. > > > > > > Thanks. > > > > I really want to see that code make progress though. > > I want to know, you refer to virtio-net + AF_XDP or refactor for XDP. > > > Would it make sense to merge this one through the virtio tree? > > There are some small problems that we merge this patch-set to Virtio Tree > directly. > > Thanks. what exactly? is there a dependency on net-next? > > > > Then you will have all the pieces in one place and try to target > > next linux. > > > > > > > Xuan Zhuo (8): > > > virtio_net: mergeable xdp: put old page immediately > > > virtio_net: mergeable xdp: introduce mergeable_xdp_prepare > > > virtio_net: introduce virtnet_xdp_handler() to seprate the logic of > > > run xdp > > > virtio_net: separate the logic of freeing xdp shinfo > > > virtio_net: separate the logic of freeing the rest mergeable buf > > > virtio_net: auto release xdp shinfo > > > virtio_net: introduce receive_mergeable_xdp() > > > virtio_net: introduce receive_small_xdp() > > > > > > drivers/net/virtio_net.c | 615 +++++++++++++++++++++++---------------- > > > 1 file changed, 357 insertions(+), 258 deletions(-) > > > > > > -- > > > 2.32.0.3.g01195cf9f > >
On Tue, 21 Mar 2023 23:53:52 -0400, "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Wed, Mar 22, 2023 at 11:40:56AM +0800, Xuan Zhuo wrote: > > On Tue, 21 Mar 2023 23:34:43 -0400, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > On Wed, Mar 22, 2023 at 11:03:00AM +0800, Xuan Zhuo wrote: > > > > Due to historical reasons, the implementation of XDP in virtio-net is relatively > > > > chaotic. For example, the processing of XDP actions has two copies of similar > > > > code. Such as page, xdp_page processing, etc. > > > > > > > > The purpose of this patch set is to refactor these code. Reduce the difficulty > > > > of subsequent maintenance. Subsequent developers will not introduce new bugs > > > > because of some complex logical relationships. > > > > > > > > In addition, the supporting to AF_XDP that I want to submit later will also need > > > > to reuse the logic of XDP, such as the processing of actions, I don't want to > > > > introduce a new similar code. In this way, I can reuse these codes in the > > > > future. > > > > > > > > Please review. > > > > > > > > Thanks. > > > > > > I really want to see that code make progress though. > > > > I want to know, you refer to virtio-net + AF_XDP or refactor for XDP. > > > > > Would it make sense to merge this one through the virtio tree? > > > > There are some small problems that we merge this patch-set to Virtio Tree > > directly. > > > > Thanks. > > what exactly? is there a dependency on net-next? There will be a conflict, I submitted to net before. Now net-next includes it. [1]. https://lore.kernel.org/netdev/20230315015223.89137-1-xuanzhuo@linux.alibaba.com/ There are no other problems. Thanks. > > > > > > > Then you will have all the pieces in one place and try to target > > > next linux. > > > > > > > > > > Xuan Zhuo (8): > > > > virtio_net: mergeable xdp: put old page immediately > > > > virtio_net: mergeable xdp: introduce mergeable_xdp_prepare > > > > virtio_net: introduce virtnet_xdp_handler() to seprate the logic of > > > > run xdp > > > > virtio_net: separate the logic of freeing xdp shinfo > > > > virtio_net: separate the logic of freeing the rest mergeable buf > > > > virtio_net: auto release xdp shinfo > > > > virtio_net: introduce receive_mergeable_xdp() > > > > virtio_net: introduce receive_small_xdp() > > > > > > > > drivers/net/virtio_net.c | 615 +++++++++++++++++++++++---------------- > > > > 1 file changed, 357 insertions(+), 258 deletions(-) > > > > > > > > -- > > > > 2.32.0.3.g01195cf9f > > > >
On Tue, 21 Mar 2023 23:53:52 -0400 Michael S. Tsirkin wrote: > > > Would it make sense to merge this one through the virtio tree? > > > > There are some small problems that we merge this patch-set to Virtio Tree > > directly. > > what exactly? is there a dependency on net-next? XDP is very actively developed, this seems like a bad idea :( Is there a problem? Is it because the RFC was not getting much attention? RFCs are for interesting code, really, nobody was interested
Due to historical reasons, the implementation of XDP in virtio-net is relatively chaotic. For example, the processing of XDP actions has two copies of similar code. Such as page, xdp_page processing, etc. The purpose of this patch set is to refactor these code. Reduce the difficulty of subsequent maintenance. Subsequent developers will not introduce new bugs because of some complex logical relationships. In addition, the supporting to AF_XDP that I want to submit later will also need to reuse the logic of XDP, such as the processing of actions, I don't want to introduce a new similar code. In this way, I can reuse these codes in the future. Please review. Thanks. Xuan Zhuo (8): virtio_net: mergeable xdp: put old page immediately virtio_net: mergeable xdp: introduce mergeable_xdp_prepare virtio_net: introduce virtnet_xdp_handler() to seprate the logic of run xdp virtio_net: separate the logic of freeing xdp shinfo virtio_net: separate the logic of freeing the rest mergeable buf virtio_net: auto release xdp shinfo virtio_net: introduce receive_mergeable_xdp() virtio_net: introduce receive_small_xdp() drivers/net/virtio_net.c | 615 +++++++++++++++++++++++---------------- 1 file changed, 357 insertions(+), 258 deletions(-) -- 2.32.0.3.g01195cf9f