From patchwork Thu Mar 23 16:36:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shay Agroskin X-Patchwork-Id: 13185835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44DBFC74A5B for ; Thu, 23 Mar 2023 16:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232304AbjCWQlN (ORCPT ); Thu, 23 Mar 2023 12:41:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232291AbjCWQk4 (ORCPT ); Thu, 23 Mar 2023 12:40:56 -0400 Received: from smtp-fw-80006.amazon.com (smtp-fw-80006.amazon.com [99.78.197.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C11BD39B96 for ; Thu, 23 Mar 2023 09:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1679589534; x=1711125534; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=r4K272kicTGLbeQ6Lqc8HQD8lu40D5bEXugEZrQY+ic=; b=L3anzzeuVURQt0V0u8A5dRDuWz6lT+miYqfYDDmxAW3L4xoEgjeU3ZvD Wud3z6HiVRE16ITAu1zXYgmu5tcSEi5hcCG65xNA0DMSrLagt/8F39CTx GiElzCqsQ0VvSVtl56Nk7si6/029J95TpLM95XnJAwxY6SDtlEFhxOa26 w=; X-IronPort-AV: E=Sophos;i="5.98,285,1673913600"; d="scan'208";a="196739799" Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-pdx-2c-m6i4x-dc7c3f8b.us-west-2.amazon.com) ([10.25.36.210]) by smtp-border-fw-80006.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 16:36:52 +0000 Received: from EX19D008EUA001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2c-m6i4x-dc7c3f8b.us-west-2.amazon.com (Postfix) with ESMTPS id 63953A05E6; Thu, 23 Mar 2023 16:36:50 +0000 (UTC) Received: from EX19D028EUB003.ant.amazon.com (10.252.61.31) by EX19D008EUA001.ant.amazon.com (10.252.50.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.24; Thu, 23 Mar 2023 16:36:49 +0000 Received: from u570694869fb251.ant.amazon.com (10.85.143.177) by EX19D028EUB003.ant.amazon.com (10.252.61.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.24; Thu, 23 Mar 2023 16:36:38 +0000 From: Shay Agroskin To: David Miller , Jakub Kicinski , CC: Shay Agroskin , "Woodhouse, David" , "Machulsky, Zorik" , "Matushevsky, Alexander" , Saeed Bshara , "Wilson, Matt" , "Liguori, Anthony" , "Bshara, Nafea" , "Belgazal, Netanel" , "Saidi, Ali" , "Herrenschmidt, Benjamin" , "Kiyanovski, Arthur" , "Dagan, Noam" , "Arinzon, David" , "Itzko, Shahar" , "Abboud, Osama" , Eric Dumazet , Paolo Abeni , Vladimir Oltean , Andrew Lunn , Guangbin Huang , "Jie Wang" , Johannes Berg , Edward Cree , Florian Westphal Subject: [PATCH v7 net-next 0/7] Add tx push buf len param to ethtool Date: Thu, 23 Mar 2023 18:36:03 +0200 Message-ID: <20230323163610.1281468-1-shayagr@amazon.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 X-Originating-IP: [10.85.143.177] X-ClientProxiedBy: EX19D032UWB002.ant.amazon.com (10.13.139.190) To EX19D028EUB003.ant.amazon.com (10.252.61.31) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Changes since v6: - Modify netlink policy macro to avoid evaluating the macro argument more than once. Changes since v5: - Added a print of the maximum tx-push-buf-len when user tries to configure a value which exceeds it. Changes since v4: - Added advertisement for tx-push-mode in ENA driver - Modified the documentation to make the distinction from tx-copybreak clearer Changes since v3: - Removed RFC tag and added a Jakub's signoff on one of the first patch Changes since v2: - Added a check that the driver advertises support for TX push buffer instead of defaulting the response to 0. - Moved cosmetic changes to their own commits - Removed usage of gotos which goes against Linux coding style - Make ENA driver reject an attempt to configure TX push buffer when it's not supported (no LLQ is used) Changes since v1: - Added the new ethtool param to generic netlink specs - Dropped dynamic advertisement of tx push buff support in ENA. The driver will advertise it for all platforms This patchset adds a new sub-configuration to ethtool get/set queue params (ethtool -g) called 'tx-push-buf-len'. This configuration specifies the maximum number of bytes of a transmitted packet a driver can push directly to the underlying device ('push' mode). The motivation for pushing some of the bytes to the device has the advantages of - Allowing a smart device to take fast actions based on the packet's header - Reducing latency for small packets that can be copied completely into the device This new param is practically similar to tx-copybreak value that can be set using ethtool's tunable but conceptually serves a different purpose. While tx-copybreak is used to reduce the overhead of DMA mapping and makes no sense to use if less than the whole segment gets copied, tx-push-buf-len allows to improve performance by analyzing the packet's data (usually headers) before performing the DMA operation. The configuration can be queried and set using the commands: $ ethtool -g [interface] # ethtool -G [interface] tx-push-buf-len [number of bytes] This patchset also adds support for the new configuration in ENA driver for which this parameter ensures efficient resources management on the device side. David Arinzon (1): net: ena: Add an option to configure large LLQ headers Shay Agroskin (6): netlink: Add a macro to set policy message with format string ethtool: Add support for configuring tx_push_buf_len net: ena: Make few cosmetic preparations to support large LLQ net: ena: Recalculate TX state variables every device reset net: ena: Add support to changing tx_push_buf_len net: ena: Advertise TX push support Documentation/netlink/specs/ethtool.yaml | 8 + Documentation/networking/ethtool-netlink.rst | 47 ++-- drivers/net/ethernet/amazon/ena/ena_eth_com.h | 4 + drivers/net/ethernet/amazon/ena/ena_ethtool.c | 66 ++++- drivers/net/ethernet/amazon/ena/ena_netdev.c | 259 +++++++++++------- drivers/net/ethernet/amazon/ena/ena_netdev.h | 15 +- include/linux/ethtool.h | 14 +- include/linux/netlink.h | 22 ++ include/uapi/linux/ethtool_netlink.h | 2 + net/ethtool/netlink.h | 2 +- net/ethtool/rings.c | 34 ++- 11 files changed, 349 insertions(+), 124 deletions(-)