| Message ID | 20230326170052.2065791-1-jiri@resnulli.us (mailing list archive) |
|---|---|
| Headers | show |
| Series | dpll: initial patchset extension by mlx5 implementation | expand |
On 26/03/2023 18:00, Jiri Pirko wrote: > From: Jiri Pirko <jiri@nvidia.com> > > Hi. > > This is extending your patchset. Basically, I do this on top of the > changes I pointed out during review. For example patch #6 is exposing > pin handle which is going to change, etc (there, I put a note). > > First 5 patches are just needed dependencies and you can squash them > into your patch/patches. Last two patches should go in separatelly. > > Please note that the patch #6 is replacing the need to pass the rclk > device during pin registration by putting a link between netdev and dpll > pin. > > Please merge this into your dpll patchset and include it in the next > RFC. Thanks! > Hi Jiri! Thanks for the patch set. It looks like it covers some changes that I have also done to address the comments. I'll try to combine everything in a couple of days and will re-spin series and we restart review process. I think that there are open question still in the conversation which were not answered. Best, Vadim
Tue, Mar 28, 2023 at 06:36:13PM CEST, vadim.fedorenko@linux.dev wrote: >On 26/03/2023 18:00, Jiri Pirko wrote: >> From: Jiri Pirko <jiri@nvidia.com> >> >> Hi. >> >> This is extending your patchset. Basically, I do this on top of the >> changes I pointed out during review. For example patch #6 is exposing >> pin handle which is going to change, etc (there, I put a note). >> >> First 5 patches are just needed dependencies and you can squash them >> into your patch/patches. Last two patches should go in separatelly. >> >> Please note that the patch #6 is replacing the need to pass the rclk >> device during pin registration by putting a link between netdev and dpll >> pin. >> >> Please merge this into your dpll patchset and include it in the next >> RFC. Thanks! >> > >Hi Jiri! > >Thanks for the patch set. It looks like it covers some changes that I have >also done to address the comments. I'll try to combine everything in a couple >of days and will re-spin series and we restart review process. I think that >there are open question still in the conversation which were not answered. I hope I didn't miss anything. I believe I replied to every comment. Please tell me if not. Thanks! > >Best, >Vadim
From: Jiri Pirko <jiri@nvidia.com> Hi. This is extending your patchset. Basically, I do this on top of the changes I pointed out during review. For example patch #6 is exposing pin handle which is going to change, etc (there, I put a note). First 5 patches are just needed dependencies and you can squash them into your patch/patches. Last two patches should go in separatelly. Please note that the patch #6 is replacing the need to pass the rclk device during pin registration by putting a link between netdev and dpll pin. Please merge this into your dpll patchset and include it in the next RFC. Thanks! Jiri Pirko (7): dpll: make ops function args const dpll: allow to call device register multiple times dpll: introduce a helper to get first dpll ref and use it dpll: allow to call pin register multiple times dpll: export dpll_pin_notify() netdev: expose DPLL pin handle for netdevice mlx5: Implement SyncE support using DPLL infrastructure drivers/dpll/dpll_core.c | 334 ++++++++++---- drivers/dpll/dpll_core.h | 25 +- drivers/dpll/dpll_netlink.c | 161 ++++--- drivers/dpll/dpll_netlink.h | 3 - drivers/net/ethernet/intel/ice/ice_dpll.c | 22 +- .../net/ethernet/mellanox/mlx5/core/Kconfig | 8 + .../net/ethernet/mellanox/mlx5/core/Makefile | 3 + drivers/net/ethernet/mellanox/mlx5/core/dev.c | 17 + .../net/ethernet/mellanox/mlx5/core/dpll.c | 429 ++++++++++++++++++ drivers/ptp/ptp_ocp.c | 2 +- include/linux/dpll.h | 46 +- include/linux/mlx5/driver.h | 2 + include/linux/mlx5/mlx5_ifc.h | 59 ++- include/linux/netdevice.h | 7 + include/uapi/linux/if_link.h | 2 + net/core/dev.c | 20 + net/core/rtnetlink.c | 38 ++ 17 files changed, 1008 insertions(+), 170 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/dpll.c