mbox series

[PATCHv2,net,0/3] bonding: fix ns validation on backup slaves

Message ID 20230406082352.986477-1-liuhangbin@gmail.com (mailing list archive)
Headers show
Series bonding: fix ns validation on backup slaves | expand

Message

Hangbin Liu April 6, 2023, 8:23 a.m. UTC 
The first patch fixed a ns validation issue on backup slaves. The second
patch re-format the bond option test and add a test lib file. The third
patch add the arp validate regression test for the kernel patch.

Here is the new bonding option test without the kernel fix:

]# ./bond_options.sh
TEST: prio (active-backup miimon primary_reselect 0)           [ OK ]
TEST: prio (active-backup miimon primary_reselect 1)           [ OK ]
TEST: prio (active-backup miimon primary_reselect 2)           [ OK ]
TEST: prio (active-backup arp_ip_target primary_reselect 0)    [ OK ]
TEST: prio (active-backup arp_ip_target primary_reselect 1)    [ OK ]
TEST: prio (active-backup arp_ip_target primary_reselect 2)    [ OK ]
TEST: prio (active-backup ns_ip6_target primary_reselect 0)    [ OK ]
TEST: prio (active-backup ns_ip6_target primary_reselect 1)    [ OK ]
TEST: prio (active-backup ns_ip6_target primary_reselect 2)    [ OK ]
TEST: prio (balance-tlb miimon primary_reselect 0)             [ OK ]
TEST: prio (balance-tlb miimon primary_reselect 1)             [ OK ]
TEST: prio (balance-tlb miimon primary_reselect 2)             [ OK ]
TEST: prio (balance-tlb arp_ip_target primary_reselect 0)      [ OK ]
TEST: prio (balance-tlb arp_ip_target primary_reselect 1)      [ OK ]
TEST: prio (balance-tlb arp_ip_target primary_reselect 2)      [ OK ]
TEST: prio (balance-tlb ns_ip6_target primary_reselect 0)      [ OK ]
TEST: prio (balance-tlb ns_ip6_target primary_reselect 1)      [ OK ]
TEST: prio (balance-tlb ns_ip6_target primary_reselect 2)      [ OK ]
TEST: prio (balance-alb miimon primary_reselect 0)             [ OK ]
TEST: prio (balance-alb miimon primary_reselect 1)             [ OK ]
TEST: prio (balance-alb miimon primary_reselect 2)             [ OK ]
TEST: prio (balance-alb arp_ip_target primary_reselect 0)      [ OK ]
TEST: prio (balance-alb arp_ip_target primary_reselect 1)      [ OK ]
TEST: prio (balance-alb arp_ip_target primary_reselect 2)      [ OK ]
TEST: prio (balance-alb ns_ip6_target primary_reselect 0)      [ OK ]
TEST: prio (balance-alb ns_ip6_target primary_reselect 1)      [ OK ]
TEST: prio (balance-alb ns_ip6_target primary_reselect 2)      [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 0)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 1)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 2)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 3)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 4)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 5)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 6)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 0)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 1)  [ OK ]
TEST: arp_validate (interface eth1 mii_status DOWN)                 [FAIL]
TEST: arp_validate (interface eth2 mii_status DOWN)                 [FAIL]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 2)  [FAIL]
TEST: arp_validate (interface eth1 mii_status DOWN)                 [FAIL]
TEST: arp_validate (interface eth2 mii_status DOWN)                 [FAIL]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 3)  [FAIL]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 4)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 5)  [ OK ]
TEST: arp_validate (interface eth1 mii_status DOWN)                 [FAIL]
TEST: arp_validate (interface eth2 mii_status DOWN)                 [FAIL]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 6)  [FAIL]

Here is the test result after the kernel fix:
TEST: arp_validate (active-backup arp_ip_target arp_validate 0)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 1)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 2)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 3)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 4)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 5)  [ OK ]
TEST: arp_validate (active-backup arp_ip_target arp_validate 6)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 0)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 1)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 2)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 3)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 4)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 5)  [ OK ]
TEST: arp_validate (active-backup ns_ip6_target arp_validate 6)  [ OK ]

Hangbin Liu (3):
  bonding: fix ns validation on backup slaves
  selftests: bonding: re-format bond option tests
  selftests: bonding: add arp validate test

 drivers/net/bonding/bond_main.c               |   5 +-
 include/net/bonding.h                         |   8 +-
 .../selftests/drivers/net/bonding/Makefile    |   3 +-
 .../drivers/net/bonding/bond_options.sh       | 264 ++++++++++++++++++
 .../drivers/net/bonding/bond_topo_3d1c.sh     | 143 ++++++++++
 .../drivers/net/bonding/option_prio.sh        | 245 ----------------
 6 files changed, 418 insertions(+), 250 deletions(-)
 create mode 100755 tools/testing/selftests/drivers/net/bonding/bond_options.sh
 create mode 100644 tools/testing/selftests/drivers/net/bonding/bond_topo_3d1c.sh
 delete mode 100755 tools/testing/selftests/drivers/net/bonding/option_prio.sh

Comments

patchwork-bot+netdevbpf@kernel.org April 7, 2023, 8:10 a.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu,  6 Apr 2023 16:23:49 +0800 you wrote:
> The first patch fixed a ns validation issue on backup slaves. The second
> patch re-format the bond option test and add a test lib file. The third
> patch add the arp validate regression test for the kernel patch.
> 
> Here is the new bonding option test without the kernel fix:
> 
> ]# ./bond_options.sh
> TEST: prio (active-backup miimon primary_reselect 0)           [ OK ]
> TEST: prio (active-backup miimon primary_reselect 1)           [ OK ]
> TEST: prio (active-backup miimon primary_reselect 2)           [ OK ]
> TEST: prio (active-backup arp_ip_target primary_reselect 0)    [ OK ]
> TEST: prio (active-backup arp_ip_target primary_reselect 1)    [ OK ]
> TEST: prio (active-backup arp_ip_target primary_reselect 2)    [ OK ]
> TEST: prio (active-backup ns_ip6_target primary_reselect 0)    [ OK ]
> TEST: prio (active-backup ns_ip6_target primary_reselect 1)    [ OK ]
> TEST: prio (active-backup ns_ip6_target primary_reselect 2)    [ OK ]
> TEST: prio (balance-tlb miimon primary_reselect 0)             [ OK ]
> TEST: prio (balance-tlb miimon primary_reselect 1)             [ OK ]
> TEST: prio (balance-tlb miimon primary_reselect 2)             [ OK ]
> TEST: prio (balance-tlb arp_ip_target primary_reselect 0)      [ OK ]
> TEST: prio (balance-tlb arp_ip_target primary_reselect 1)      [ OK ]
> TEST: prio (balance-tlb arp_ip_target primary_reselect 2)      [ OK ]
> TEST: prio (balance-tlb ns_ip6_target primary_reselect 0)      [ OK ]
> TEST: prio (balance-tlb ns_ip6_target primary_reselect 1)      [ OK ]
> TEST: prio (balance-tlb ns_ip6_target primary_reselect 2)      [ OK ]
> TEST: prio (balance-alb miimon primary_reselect 0)             [ OK ]
> TEST: prio (balance-alb miimon primary_reselect 1)             [ OK ]
> TEST: prio (balance-alb miimon primary_reselect 2)             [ OK ]
> TEST: prio (balance-alb arp_ip_target primary_reselect 0)      [ OK ]
> TEST: prio (balance-alb arp_ip_target primary_reselect 1)      [ OK ]
> TEST: prio (balance-alb arp_ip_target primary_reselect 2)      [ OK ]
> TEST: prio (balance-alb ns_ip6_target primary_reselect 0)      [ OK ]
> TEST: prio (balance-alb ns_ip6_target primary_reselect 1)      [ OK ]
> TEST: prio (balance-alb ns_ip6_target primary_reselect 2)      [ OK ]
> TEST: arp_validate (active-backup arp_ip_target arp_validate 0)  [ OK ]
> TEST: arp_validate (active-backup arp_ip_target arp_validate 1)  [ OK ]
> TEST: arp_validate (active-backup arp_ip_target arp_validate 2)  [ OK ]
> TEST: arp_validate (active-backup arp_ip_target arp_validate 3)  [ OK ]
> TEST: arp_validate (active-backup arp_ip_target arp_validate 4)  [ OK ]
> TEST: arp_validate (active-backup arp_ip_target arp_validate 5)  [ OK ]
> TEST: arp_validate (active-backup arp_ip_target arp_validate 6)  [ OK ]
> TEST: arp_validate (active-backup ns_ip6_target arp_validate 0)  [ OK ]
> TEST: arp_validate (active-backup ns_ip6_target arp_validate 1)  [ OK ]
> TEST: arp_validate (interface eth1 mii_status DOWN)                 [FAIL]
> TEST: arp_validate (interface eth2 mii_status DOWN)                 [FAIL]
> TEST: arp_validate (active-backup ns_ip6_target arp_validate 2)  [FAIL]
> TEST: arp_validate (interface eth1 mii_status DOWN)                 [FAIL]
> TEST: arp_validate (interface eth2 mii_status DOWN)                 [FAIL]
> TEST: arp_validate (active-backup ns_ip6_target arp_validate 3)  [FAIL]
> TEST: arp_validate (active-backup ns_ip6_target arp_validate 4)  [ OK ]
> TEST: arp_validate (active-backup ns_ip6_target arp_validate 5)  [ OK ]
> TEST: arp_validate (interface eth1 mii_status DOWN)                 [FAIL]
> TEST: arp_validate (interface eth2 mii_status DOWN)                 [FAIL]
> TEST: arp_validate (active-backup ns_ip6_target arp_validate 6)  [FAIL]
> 
> [...]

Here is the summary with links:
  - [PATCHv2,net,1/3] bonding: fix ns validation on backup slaves
    https://git.kernel.org/netdev/net/c/4598380f9c54
  - [PATCHv2,net,2/3] selftests: bonding: re-format bond option tests
    https://git.kernel.org/netdev/net/c/481b56e0391e
  - [PATCHv2,net,3/3] selftests: bonding: add arp validate test
    https://git.kernel.org/netdev/net/c/2e825f8accb4

You are awesome, thank you!