[net-next,RFC,v4,0/5] net: Make MAC/PHY time stamping selectable

Message

Kory Maincent April 6, 2023, 5:33 p.m. UTC

From: Kory Maincent <[e-mail]>

Up until now, there was no way to let the user select the layer at
which time stamping occurs.  The stack assumed that PHY time stamping
is always preferred, but some MAC/PHY combinations were buggy.

This series aims to allow the user to select the desired layer
administratively.

- Patch 1 refactors get_ts_info copy/paste code.

- Patch 2 introduces sysfs files that reflect the current, static
  preference of PHY over MAC.

- Patch 3 add devicetree binding to select the default time stamping.

- Patch 4 makes the layer selectable at run time.

- Patch 5 fixes up MAC drivers that attempt to defer to the PHY layer.
  This patch is broken out for review, but it will eventually be
  squashed into Patch 4 after comments come in.

Changes in v2:
- Move selected_timestamping_layer variable of the concerned patch.
- Use sysfs_streq instead of strmcmp.
- Use the PHY timestamp only if available.

Changes in v3:
- Expose the PTP choice to ethtool instead of sysfs.
  You can test it with the ethtool source on branch feature_ptp of:
  https://github.com/kmaincent/ethtool
- Added a devicetree binding to select the preferred timestamp.

Changes in v4:
- Move on to ethtool netlink instead of ioctl.
- Add a netdev notifier to allow packet trapping by the MAC in case of PHY
  time stamping.
- Add a PHY whitelist to not break the old PHY default time-stamping
  preference API.

Kory Maincent (3):
  net: Expose available time stamping layers to user space.
  dt-bindings: net: phy: add timestamp preferred choice property
  net: Let the active time stamping layer be selectable.

Richard Cochran (2):
  net: ethtool: Refactor identical get_ts_info implementations.
  net: fix up drivers WRT phy time stamping

 .../devicetree/bindings/net/ethernet-phy.yaml |   7 +
 Documentation/networking/ethtool-netlink.rst  |  53 ++++++
 drivers/net/bonding/bond_main.c               |  14 +-
 drivers/net/ethernet/freescale/fec_main.c     |  23 ++-
 drivers/net/ethernet/mscc/ocelot_net.c        |  21 +--
 drivers/net/ethernet/ti/cpsw_priv.c           |  12 +-
 drivers/net/ethernet/ti/netcp_ethss.c         |  26 +--
 drivers/net/macvlan.c                         |  14 +-
 drivers/net/phy/phy_device.c                  |  85 +++++++++
 include/linux/ethtool.h                       |   8 +
 include/linux/netdevice.h                     |  12 ++
 include/uapi/linux/ethtool_netlink.h          |  17 ++
 include/uapi/linux/net_tstamp.h               |   8 +
 net/8021q/vlan_dev.c                          |  15 +-
 net/core/dev.c                                |   2 +-
 net/core/dev_ioctl.c                          |  56 +++++-
 net/core/timestamping.c                       |   6 +
 net/ethtool/Makefile                          |   2 +-
 net/ethtool/common.c                          |  21 ++-
 net/ethtool/netlink.c                         |  30 ++++
 net/ethtool/netlink.h                         |   4 +
 net/ethtool/ts.c                              | 168 ++++++++++++++++++
 22 files changed, 506 insertions(+), 98 deletions(-)
 create mode 100644 net/ethtool/ts.c

Comments

Kory Maincent April 6, 2023, 5:59 p.m. UTC | #1

On Thu,  6 Apr 2023 19:33:03 +0200
Köry Maincent <[e-mail]> wrote:

> From: Kory Maincent <[e-mail]>
> 
> Up until now, there was no way to let the user select the layer at
> which time stamping occurs.  The stack assumed that PHY time stamping
> is always preferred, but some MAC/PHY combinations were buggy.
> 
> This series aims to allow the user to select the desired layer
> administratively.

Forgot to run the checkpatch script, sorry for that. There is few coding
style issues.

Köry