[net,v2,0/9] Macsec fixes for CN10KB

Message

Geetha sowjanya April 26, 2023, 6:25 a.m. UTC

This patch set has fixes for the issues encountered while
testing macsec on CN10KB silicon. Below is the description
of patches:

Patch 1: For each LMAC two MCSX_MCS_TOP_SLAVE_CHANNEL_CFG registers exist
	 in CN10KB. Bypass has to be disabled in two registers.

Patch 2: Add workaround for errata w.r.t accessing TCAM DATA and MASK registers.

Patch 3: Fixes the parser configuration to allow PTP traffic.

Patch 4: Addresses the IP vector and block level interrupt mask changes.
 
Patch 5: Fix NULL pointer crashes when rebooting

Patch 6: Since MCS is global block shared by all LMACS the TCAM match
	 must include macsec DMAC also to distinguish each macsec interface

Patch 7: Before freeing MCS hardware resource to AF clear the stats also.

Patch 8: Stats which share single counter in hardware are tracked in software.
	 This tracking was based on wrong secy mode params.
	 Use correct secy mode params

Patch 9: When updating secy mode params, PN number was also reset to
	 initial values. Hence do not write to PN value register when
	 updating secy.


Geetha sowjanya (3):
  octeonxt2-af: mcs: Fix per port bypass config
  octeontx2-af: mcs: Config parser to skip 8B header
  octeontx2-af: mcs: Fix MCS block interrupt  

Subbaraya Sundeep (6):
  octeontx2-af: mcs: Write TCAM_DATA and TCAM_MASK registers at once
  octeontx2-pf: mcs: Fix NULL pointer dereferences
  octeontx2-pf: mcs: Match macsec ethertype along with DMAC
  octeontx2-pf: mcs: Clear stats before freeing resource
  octeontx2-pf: mcs: Fix shared counters logic
  octeontx2-pf: mcs: Do not reset PN when updating secy

---
v1-v2:
 -Added Reviewed-by: Leon Romanovsky <[e-mail]>
 -Corrected the sequence of tear down to fix null pointer dereferences.

 .../net/ethernet/marvell/octeontx2/af/mcs.c   | 106 +++++++++---------
 .../net/ethernet/marvell/octeontx2/af/mcs.h   |  26 ++---
 .../marvell/octeontx2/af/mcs_cnf10kb.c        |  63 +++++++++++
 .../ethernet/marvell/octeontx2/af/mcs_reg.h   |   6 +-
 .../marvell/octeontx2/af/mcs_rvu_if.c         |  37 ++++++
 .../net/ethernet/marvell/octeontx2/af/rvu.h   |   1 +
 .../ethernet/marvell/octeontx2/af/rvu_cgx.c   |   2 +
 .../marvell/octeontx2/af/rvu_debugfs.c        |   4 +-
 .../marvell/octeontx2/nic/cn10k_macsec.c      |  54 ++++++---
 .../marvell/octeontx2/nic/otx2_common.h       |   2 +-
 10 files changed, 217 insertions(+), 84 deletions(-)

Comments

[e-mail] April 27, 2023, 11 a.m. UTC | #1

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <[e-mail]>:

On Wed, 26 Apr 2023 11:55:19 +0530 you wrote:
> This patch set has fixes for the issues encountered while
> testing macsec on CN10KB silicon. Below is the description
> of patches:
> 
> Patch 1: For each LMAC two MCSX_MCS_TOP_SLAVE_CHANNEL_CFG registers exist
> 	 in CN10KB. Bypass has to be disabled in two registers.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/9] octeonxt2-af: mcs: Fix per port bypass config
    https://git.kernel.org/netdev/net/c/c222b292a356
  - [net,v2,2/9] octeontx2-af: mcs: Write TCAM_DATA and TCAM_MASK registers at once
    https://git.kernel.org/netdev/net/c/b51612198603
  - [net,v2,3/9] octeontx2-af: mcs: Config parser to skip 8B header
    https://git.kernel.org/netdev/net/c/65cdc2b637a5
  - [net,v2,4/9] octeontx2-af: mcs: Fix MCS block interrupt
    https://git.kernel.org/netdev/net/c/b8aebeaaf9ff
  - [net,v2,5/9] octeontx2-pf: mcs: Fix NULL pointer dereferences
    https://git.kernel.org/netdev/net/c/699af748c615
  - [net,v2,6/9] octeontx2-pf: mcs: Match macsec ethertype along with DMAC
    https://git.kernel.org/netdev/net/c/57d00d4364f3
  - [net,v2,7/9] octeontx2-pf: mcs: Clear stats before freeing resource
    https://git.kernel.org/netdev/net/c/815debbbf7b5
  - [net,v2,8/9] octeontx2-pf: mcs: Fix shared counters logic
    https://git.kernel.org/netdev/net/c/9bdfe61054fb
  - [net,v2,9/9] octeontx2-pf: mcs: Do not reset PN while updating secy
    https://git.kernel.org/netdev/net/c/3c99bace4ad0

You are awesome, thank you!