From patchwork Wed Apr 26 06:25:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geetha sowjanya X-Patchwork-Id: 13224141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0676FC7618E for ; Wed, 26 Apr 2023 06:25:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239488AbjDZGZp (ORCPT ); Wed, 26 Apr 2023 02:25:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239384AbjDZGZo (ORCPT ); Wed, 26 Apr 2023 02:25:44 -0400 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA7B32134; Tue, 25 Apr 2023 23:25:43 -0700 (PDT) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33Q64Kfk001000; Tue, 25 Apr 2023 23:25:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0220; bh=sTSuZ7sUzdC+Zxyb8IFNPQ7YZ/BApBN++Ta63Z3LULg=; b=jsd9yEKViDKd7MGha9VyED1flfFTKOXt8pH1Hco8w2/cBnURsaC7uB7+1PtncaLwxXwm sw4GdFf5aiDzjiGzRT79ur/YaNOj4L9XeX6KmDZ72WjXIuf1XBClSKcytl+AnPvhHktj O/iR2nJeRPBNWO8r89Euhw9dv+0GJLYvmU/T+J4Zgi+ZErlxVGDkfrULC6AWijvy/xve 1Aw3cY5iZuLQ+r6WYdoawrl3TVHbFqQoRX+5Nb5/g5bcSZpJ/LWkoQ7mWVI3rQ70TJQj wbAWRBXdYHnt4GMsX3TrZzmoHt4n6XcS3ia9E6486lUxRRqiwdUDQ475DyWjKk0ESs+v AA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3q4f3pdcvu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 25 Apr 2023 23:25:34 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 25 Apr 2023 23:25:32 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 25 Apr 2023 23:25:32 -0700 Received: from hyd1soter3.marvell.com (unknown [10.29.37.12]) by maili.marvell.com (Postfix) with ESMTP id 3C0AE3F703F; Tue, 25 Apr 2023 23:25:29 -0700 (PDT) From: Geetha sowjanya To: , CC: , , , , , , , , Subject: [net PATCH v2 0/9] Macsec fixes for CN10KB Date: Wed, 26 Apr 2023 11:55:19 +0530 Message-ID: <20230426062528.20575-1-gakula@marvell.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: r5hee5INQSL5FeYQidzWHU_llSPj1xRm X-Proofpoint-GUID: r5hee5INQSL5FeYQidzWHU_llSPj1xRm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-26_02,2023-04-25_01,2023-02-09_01 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org This patch set has fixes for the issues encountered while testing macsec on CN10KB silicon. Below is the description of patches: Patch 1: For each LMAC two MCSX_MCS_TOP_SLAVE_CHANNEL_CFG registers exist in CN10KB. Bypass has to be disabled in two registers. Patch 2: Add workaround for errata w.r.t accessing TCAM DATA and MASK registers. Patch 3: Fixes the parser configuration to allow PTP traffic. Patch 4: Addresses the IP vector and block level interrupt mask changes. Patch 5: Fix NULL pointer crashes when rebooting Patch 6: Since MCS is global block shared by all LMACS the TCAM match must include macsec DMAC also to distinguish each macsec interface Patch 7: Before freeing MCS hardware resource to AF clear the stats also. Patch 8: Stats which share single counter in hardware are tracked in software. This tracking was based on wrong secy mode params. Use correct secy mode params Patch 9: When updating secy mode params, PN number was also reset to initial values. Hence do not write to PN value register when updating secy. Geetha sowjanya (3): octeonxt2-af: mcs: Fix per port bypass config octeontx2-af: mcs: Config parser to skip 8B header octeontx2-af: mcs: Fix MCS block interrupt Subbaraya Sundeep (6): octeontx2-af: mcs: Write TCAM_DATA and TCAM_MASK registers at once octeontx2-pf: mcs: Fix NULL pointer dereferences octeontx2-pf: mcs: Match macsec ethertype along with DMAC octeontx2-pf: mcs: Clear stats before freeing resource octeontx2-pf: mcs: Fix shared counters logic octeontx2-pf: mcs: Do not reset PN when updating secy --- v1-v2: -Added Reviewed-by: Leon Romanovsky -Corrected the sequence of tear down to fix null pointer dereferences. .../net/ethernet/marvell/octeontx2/af/mcs.c | 106 +++++++++--------- .../net/ethernet/marvell/octeontx2/af/mcs.h | 26 ++--- .../marvell/octeontx2/af/mcs_cnf10kb.c | 63 +++++++++++ .../ethernet/marvell/octeontx2/af/mcs_reg.h | 6 +- .../marvell/octeontx2/af/mcs_rvu_if.c | 37 ++++++ .../net/ethernet/marvell/octeontx2/af/rvu.h | 1 + .../ethernet/marvell/octeontx2/af/rvu_cgx.c | 2 + .../marvell/octeontx2/af/rvu_debugfs.c | 4 +- .../marvell/octeontx2/nic/cn10k_macsec.c | 54 ++++++--- .../marvell/octeontx2/nic/otx2_common.h | 2 +- 10 files changed, 217 insertions(+), 84 deletions(-)