[bpf-next,v3,0/5] Dynptr Verifier Adjustments

Message

Daniel Rosenberg May 6, 2023, 1:31 a.m. UTC

These patches relax a few verifier requirements around dynptrs.
Patches 1-3 are unchanged from v2, apart from rebasing
Patch 4 is the same as in v1, see
https://lore.kernel.org/bpf/CA+PiJmST4WUH061KaxJ4kRL=[e-mail]/
Patch 5 adds a test for the change in Patch 4

Daniel Rosenberg (5):
  bpf: Allow NULL buffers in bpf_dynptr_slice(_rw)
  selftests/bpf: Test allowing NULL buffer in dynptr slice
  selftests/bpf: Check overflow in optional buffer
  bpf: verifier: Accept dynptr mem as mem in helpers
  selftests/bpf: Accept mem from dynptr in helper funcs

 Documentation/bpf/kfuncs.rst                  | 23 ++++++++++-
 include/linux/skbuff.h                        |  2 +-
 kernel/bpf/helpers.c                          | 30 +++++++++------
 kernel/bpf/verifier.c                         | 21 ++++++++--
 .../testing/selftests/bpf/prog_tests/dynptr.c |  2 +
 .../testing/selftests/bpf/progs/dynptr_fail.c | 20 ++++++++++
 .../selftests/bpf/progs/dynptr_success.c      | 38 +++++++++++++++++++
 7 files changed, 118 insertions(+), 18 deletions(-)


base-commit: f4dea9689c5fea3d07170c2cb0703e216f1a0922

Comments

[e-mail] May 7, 2023, midnight UTC | #1

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <[e-mail]>:

On Fri,  5 May 2023 18:31:29 -0700 you wrote:
> These patches relax a few verifier requirements around dynptrs.
> Patches 1-3 are unchanged from v2, apart from rebasing
> Patch 4 is the same as in v1, see
> https://lore.kernel.org/bpf/CA+PiJmST4WUH061KaxJ4kRL=[e-mail]/
> Patch 5 adds a test for the change in Patch 4
> 
> Daniel Rosenberg (5):
>   bpf: Allow NULL buffers in bpf_dynptr_slice(_rw)
>   selftests/bpf: Test allowing NULL buffer in dynptr slice
>   selftests/bpf: Check overflow in optional buffer
>   bpf: verifier: Accept dynptr mem as mem in helpers
>   selftests/bpf: Accept mem from dynptr in helper funcs
> 
> [...]

Here is the summary with links:
  - [bpf-next,v3,1/5] bpf: Allow NULL buffers in bpf_dynptr_slice(_rw)
    https://git.kernel.org/bpf/bpf-next/c/3bda08b63670
  - [bpf-next,v3,2/5] selftests/bpf: Test allowing NULL buffer in dynptr slice
    https://git.kernel.org/bpf/bpf-next/c/1ce33b6c846f
  - [bpf-next,v3,3/5] selftests/bpf: Check overflow in optional buffer
    https://git.kernel.org/bpf/bpf-next/c/3881fdfed21f
  - [bpf-next,v3,4/5] bpf: verifier: Accept dynptr mem as mem in helpers
    https://git.kernel.org/bpf/bpf-next/c/2012c867c800
  - [bpf-next,v3,5/5] selftests/bpf: Accept mem from dynptr in helper funcs
    https://git.kernel.org/bpf/bpf-next/c/798e48fc28fa

You are awesome, thank you!