mbox series

[v2,bpf-next,00/11] bpf: Support ->fill_link_info for kprobe_multi and perf_event links

Message ID 20230608103523.102267-1-laoar.shao@gmail.com (mailing list archive)
Headers show
Series bpf: Support ->fill_link_info for kprobe_multi and perf_event links | expand

Message

Yafang Shao June 8, 2023, 10:35 a.m. UTC
This patchset enhances the usability of kprobe_multi programs by introducing
support for ->fill_link_info. This allows users to easily determine the
probed functions associated with a kprobe_multi program. While
`bpftool perf show` already provides information about functions probed by
perf_event programs, supporting ->fill_link_info ensures consistent access to
this information across all bpf links.

In addition, this patch extends support to generic perf events, which are
currently not covered by `bpftool perf show`. While userspace is exposed to
only the perf type and config, other attributes such as sample_period and
sample_freq are disregarded.

To ensure accurate identification of probed functions, it is preferable to
expose the address directly rather than relying solely on the symbol name.
However, this implementation respects the kptr_restrict setting and avoids
exposing the address if it is not permitted.

v1->v2:
- Fix sparse warning (Stanislav, lkp@intel.com)
- Fix BPF CI build error
- Reuse kernel_syms_load() (Alexei)
- Print 'name' instead of 'func' (Alexei)
- Show whether the probe is retprobe or not (Andrii)
- Add comment for the meaning of perf_event name (Andrii)
- Add support for generic perf event
- Adhere to the kptr_restrict setting

RFC->v1:
- Use a single copy_to_user() instead (Jiri)
- Show also the symbol name in bpftool (Quentin, Alexei)
- Use calloc() instead of malloc() in bpftool (Quentin)
- Avoid having conditional entries in the JSON output (Quentin)
- Drop ->show_fdinfo (Alexei)
- Use __u64 instead of __aligned_u64 for the field addr (Alexei)
- Avoid the contradiction in perf_event name length (Alexei)
- Address a build warning reported by kernel test robot <lkp@intel.com>

Yafang Shao (11):
  bpf: Support ->fill_link_info for kprobe_multi
  bpftool: Add address filtering in kernel_syms_load()
  bpftool: Show probed function in kprobe_multi link info
  bpf: Protect probed address based on kptr_restrict setting
  bpf: Clear the probe_addr for uprobe
  bpf: Expose symbol addresses for precise identification
  bpf: Add a common helper bpf_copy_to_user()
  bpf: Support ->fill_link_info for perf_event
  libbpf: Add perf event names
  bpftool: Move get_prog_info() into do_show_link()
  bpftool: Show probed function in perf_event link info

 include/uapi/linux/bpf.h          |  27 ++++
 kernel/bpf/syscall.c              | 132 +++++++++++++++--
 kernel/trace/bpf_trace.c          |  34 ++++-
 kernel/trace/trace_kprobe.c       |   6 +-
 tools/bpf/bpftool/link.c          | 299 +++++++++++++++++++++++++++++++++++---
 tools/bpf/bpftool/prog.c          |   6 +-
 tools/bpf/bpftool/xlated_dumper.c |  72 +++++++--
 tools/bpf/bpftool/xlated_dumper.h |   3 +-
 tools/include/uapi/linux/bpf.h    |  27 ++++
 tools/lib/bpf/libbpf.c            | 107 ++++++++++++++
 tools/lib/bpf/libbpf.h            |  56 +++++++
 tools/lib/bpf/libbpf.map          |   6 +
 12 files changed, 719 insertions(+), 56 deletions(-)